[SSSD] [PATCH] Fix SASL authentication

2010-06-28 Thread Sumit Bose
Hi, Alexander Gordeev lasa...@lvk.cs.msu.su helped to find a bug in SASL interactive callback which became visible with and OpenLDAP server. The attached patch should fix it. bye, Sumit From 9de4f6fddc0d1484ca554b3a3f9dab831106ff4e Mon Sep 17 00:00:00 2001 From: Sumit Bose sb...@redhat.com Date:

Re: [SSSD] [PATCH] Fix SASL authentication

2010-06-28 Thread Stephen Gallagher
On 06/28/2010 08:19 AM, Sumit Bose wrote: Hi, Alexander Gordeevlasa...@lvk.cs.msu.su helped to find a bug in SASL interactive callback which became visible with and OpenLDAP server. The attached patch should fix it. Ack. Good work! -- Stephen Gallagher RHCE 804006346421761 Delivering

Re: [SSSD] [PATCH] [INI] Memory leak in case of empty value

2010-06-28 Thread Stephen Gallagher
On 06/21/2010 09:17 AM, Stephen Gallagher wrote: On 06/10/2010 12:40 PM, Dmitri Pal wrote: The rebased patches that should apply to paster are attached. Ack to both. Pushed to master. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value

Re: [SSSD] [PATCH] Replace %define with %global in example spec

2010-06-28 Thread Stephen Gallagher
On 06/21/2010 10:55 AM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/21/2010 04:28 PM, Stephen Gallagher wrote: RPM guidelines strongly advise the use of %global instead of %define, as they are safer when RPM macros are used. Ack Pushed to master. -- Stephen

Re: [SSSD] [PATCHES] Fixes for the collection

2010-06-28 Thread Stephen Gallagher
On 06/22/2010 11:08 AM, Stephen Gallagher wrote: On 06/21/2010 11:37 AM, Dmitri Pal wrote: Stephen Gallagher wrote: On 06/19/2010 11:24 AM, Dmitri Pal wrote: 0001 - #547 Nack. Please update contrib/sssd.spec.in to require the correct minimum collection version. Otherwise it looks fine.

Re: [SSSD] [PATCH] Fix SASL authentication

2010-06-28 Thread Stephen Gallagher
On 06/28/2010 08:22 AM, Stephen Gallagher wrote: On 06/28/2010 08:19 AM, Sumit Bose wrote: Hi, Alexander Gordeevlasa...@lvk.cs.msu.su helped to find a bug in SASL interactive callback which became visible with and OpenLDAP server. The attached patch should fix it. Ack. Good work!

Re: [SSSD] [PATCH] Resend SIGINT as SIGTERM in services

2010-06-28 Thread Stephen Gallagher
On 06/25/2010 01:46 PM, Stephen Gallagher wrote: On 06/25/2010 02:39 PM, Jakub Hrozek wrote: A new patch is attached. Ack. Pushed to master. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors.

Re: [SSSD] [PATCHES] Fix libini_config versions

2010-06-28 Thread Stephen Gallagher
On 06/25/2010 09:47 AM, Dmitri Pal wrote: Stephen Gallagher wrote: I realized today that the RPM packages for SSSD had the wrong version for libini_config. The upstream project revision was 0.4.0, but we were building RPMs that claimed it was 0.5.0. To further confuse things, in the master

Re: [SSSD] [PATCHv3] Add explicit requests for several operational attrs

2010-06-28 Thread Simo Sorce
On Fri, 25 Jun 2010 09:50:53 +0200 Sumit Bose sb...@redhat.com wrote: Hi, Thank you, I agree with this patch, but I would like to see if Simo has some comments about it, e.g. if he knows about other attributes we want to include. He is away from keyboard most of this week, so I don't

Re: [SSSD] [PATCH] Make RootDSE optional (master and sssd-1-2)

2010-06-28 Thread Simo Sorce
On Thu, 24 Jun 2010 14:17:08 -0400 Stephen Gallagher sgall...@redhat.com wrote: In violation of the standard, some LDAP servers control access to the RootDSE, thus preventing us from being able to read it before performing a bind. This patch will allow us to continue on if the RootDSE was

Re: [SSSD] [PATCH] Make RootDSE optional (master and sssd-1-2)

2010-06-28 Thread Stephen Gallagher
On 06/28/2010 10:10 AM, Simo Sorce wrote: Code looks good, but please change this message: Check ACIs on RootDSE\n to something like: Please check that anonymous access to RootDSE is allowed\n. Thank you for the review. New patch attached. -- Stephen Gallagher RHCE 804006346421761 Delivering

Re: [SSSD] [PATCH] Make RootDSE optional (master and sssd-1-2)

2010-06-28 Thread Simo Sorce
On Mon, 28 Jun 2010 10:16:45 -0400 Stephen Gallagher sgall...@redhat.com wrote: On 06/28/2010 10:10 AM, Simo Sorce wrote: Code looks good, but please change this message: Check ACIs on RootDSE\n to something like: Please check that anonymous access to RootDSE is allowed\n. Thank you

Re: [SSSD] [PATCHv3] Add explicit requests for several operational attrs

2010-06-28 Thread Stephen Gallagher
On 06/28/2010 09:22 AM, Simo Sorce wrote: On Fri, 25 Jun 2010 09:50:53 +0200 Sumit Bosesb...@redhat.com wrote: Hi, Thank you, I agree with this patch, but I would like to see if Simo has some comments about it, e.g. if he knows about other attributes we want to include. He is away from

Re: [SSSD] [PATCH] Make RootDSE optional (master and sssd-1-2)

2010-06-28 Thread Stephen Gallagher
On 06/28/2010 10:34 AM, Simo Sorce wrote: On Mon, 28 Jun 2010 10:16:45 -0400 Stephen Gallaghersgall...@redhat.com wrote: On 06/28/2010 10:10 AM, Simo Sorce wrote: Code looks good, but please change this message: Check ACIs on RootDSE\n to something like: Please check that anonymous access

Re: [SSSD] [PATCHES] Refactor proxy.c

2010-06-28 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/25/2010 05:47 PM, Stephen Gallagher wrote: Patch 0001: Rename proxy_ctx to proxy_id_ctx for clarity Patch 0002: Split proxy.c into smaller files proxy.c was growing too large to manage (and some graphical development tools could no