On 07/06/2010 11:17 PM, Stephen Gallagher wrote:
...
0005-Use-new-LDAP-connection-framework-to-get-user-accoun.patch
Nitpick: in users_connect_get_done()
+int ret, dp_error = DP_ERR_FATAL;
Please either use:
int ret, dp_error;
or
int ret;
int dp_error = DP_ERR_FATAL;
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/02/2010 10:36 AM, Dmitri Pal wrote:
The terminology is more developer specific IMO. And the admin who is
troubleshooting the issue might not be familiar with the terminology
that OpenLDAP internally uses.
I can give functional visual ack but
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/07/2010 04:06 AM, Eugene Indenbom wrote:
On 07/06/2010 11:17 PM, Stephen Gallagher wrote:
However, since dp_error is assigned in the very next line (in a way that
can't fail) I don't see a good reason to initialize it here.
It's a bit
On 07/07/2010 04:02 PM, Stephen Gallagher wrote:
Using hbac_ctx-sdap_op == NULL to mean operating in offline mode is
very hard to read. Please just set a boolean state like
hbac_ctx-offline instead. When I read if (!hbac_ctx-sdap_op), my
natural expectation is for the following lines to set
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Sounds good. I just want a confirmation that it is in line with tevent
coding style to pass pointer to higher level state (hbac_ctx) into
sub-operations (hbac_get_host_info_send() and others).
It's fine to percolate it down where necessary,
On Fri, Jul 02, 2010 at 10:29:47AM -0400, Dmitri Pal wrote:
Stephen Gallagher wrote:
On 07/02/2010 09:37 AM, Dmitri Pal wrote:
Nack
You are leaking entry in success scenario.
I suggest a little bit cleaner approach:
while((ret = krb5_kt_next_entry(context, keytab, entry,
On 07/07/2010 04:43 PM, Stephen Gallagher wrote:
Sounds good. I just want a confirmation that it is in line with tevent
coding style to pass pointer to higher level state (hbac_ctx) into
sub-operations (hbac_get_host_info_send() and others).
It's fine to percolate it down where
On 07/07/2010 04:43 PM, Stephen Gallagher wrote:
Sounds good. I just want a confirmation that it is in line with tevent
coding style to pass pointer to higher level state (hbac_ctx) into
sub-operations (hbac_get_host_info_send() and others).
It's fine to percolate it down where necessary,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/05/2010 08:21 AM, Jakub Hrozek wrote:
Integrates libnl to detect adding routes. When a route is added, the
offline status of all back ends is reset. This patch adds no heuristics
to detect whether back end went offline.
Fixes: #456
Nack.
