Re: [SSSD] [PATCH] RPM: Create ghost files during install

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 09:23:41PM +0200, Pavel Březina wrote: > On 09/24/2012 08:28 PM, Jakub Hrozek wrote: > >My previous patch that ghosted the fastcache files broke the RPM build, > >because as Stephen noted, the old rpmbuild version shipped with RHEL5 > >requires that the ghost files must be p

Re: [SSSD] [PATCH] Detect LDAPDerefRes in configure script

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 06:43:56PM +0200, Sumit Bose wrote: > On Mon, Sep 24, 2012 at 12:46:51PM +0200, Jakub Hrozek wrote: > > On Mon, Sep 24, 2012 at 12:18:36PM +0200, Sumit Bose wrote: > > > On Sun, Sep 23, 2012 at 09:10:04PM +0200, Jakub Hrozek wrote: > > > > To test, remove the openldap24 RPMs

Re: [SSSD] [PATCH] RPM: Create ghost files during install

2012-09-24 Thread Pavel Březina
On 09/24/2012 08:28 PM, Jakub Hrozek wrote: My previous patch that ghosted the fastcache files broke the RPM build, because as Stephen noted, the old rpmbuild version shipped with RHEL5 requires that the ghost files must be present in the buildroot. A patch is attached. Ack. _

[SSSD] [PATCH] RPM: Create ghost files during install

2012-09-24 Thread Jakub Hrozek
My previous patch that ghosted the fastcache files broke the RPM build, because as Stephen noted, the old rpmbuild version shipped with RHEL5 requires that the ghost files must be present in the buildroot. A patch is attached. >From d1a70c9fe3f2572ba92c64dc5c2c5be3baef1ef0 Mon Sep 17 00:00:00 2001

Re: [SSSD] [PATCH] Detect LDAPDerefRes in configure script

2012-09-24 Thread Sumit Bose
On Mon, Sep 24, 2012 at 12:46:51PM +0200, Jakub Hrozek wrote: > On Mon, Sep 24, 2012 at 12:18:36PM +0200, Sumit Bose wrote: > > On Sun, Sep 23, 2012 at 09:10:04PM +0200, Jakub Hrozek wrote: > > > To test, remove the openldap24 RPMs on RHEL5 systems and attempt to > > > build the SSSD. Without the p

Re: [SSSD] [PATCH] KRB5: Recover gracefully if the ccache file could not be reused

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 03:55:39PM +0200, Jakub Hrozek wrote: > On Mon, Sep 24, 2012 at 12:35:50PM +0200, Sumit Bose wrote: > > On Sun, Sep 23, 2012 at 11:12:30PM +0200, Jakub Hrozek wrote: > > > https://fedorahosted.org/sssd/ticket/1384 > > > > > > I tested by logging in from one terminal, then c

Re: [SSSD] [PATCH] Bad debug message when no dns_discovery_domain specified.

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 04:45:54PM +0200, Michal Židek wrote: > https://fedorahosted.org/sssd/ticket/920 > > The debug message was simplified and two new debug messages were added. > > Patch is attached. > > Michal Ack and pushed to master. ___ sssd-d

Re: [SSSD] [PATCH] SYSDB: Remove unnecessary domain parameter from several sysdb calls

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 04:58:35PM +0200, Michal Židek wrote: > On 09/24/2012 03:35 PM, Jakub Hrozek wrote: > >On Mon, Sep 24, 2012 at 01:24:15PM +0200, Michal Židek wrote: > >>On 09/23/2012 09:02 PM, Jakub Hrozek wrote: > >>>The domain can be read from the sysdb object. Removing the domain string

Re: [SSSD] AUTOFS: Store entry objects below map objects

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 04:53:46PM +0200, Pavel Březina wrote: > >New patches attached again. > > Ack. Good job. Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] sdap_get_ad_tokengroups_initgroups_lookup_done(): fix group_name may be uninitialized warning

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 11:32:52AM -0400, Stephen Gallagher wrote: > On Mon 24 Sep 2012 11:24:59 AM EDT, Stephen Gallagher wrote: > >On Mon 24 Sep 2012 11:01:20 AM EDT, Pavel Březina wrote: > >>Recent AD patches introduced another warning. > >> > >>If I read the code correctly it is safe to just in

Re: [SSSD] [PATCH] Make subdomain discovery less noisy

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 05:54:28PM +0200, Pavel Březina wrote: > On 09/24/2012 04:25 PM, Sumit Bose wrote: > >On Mon, Sep 24, 2012 at 01:03:44PM +0200, Jakub Hrozek wrote: > >>On Mon, Sep 24, 2012 at 12:41:07PM +0200, Pavel Březina wrote: > >>>On 09/21/2012 06:42 PM, Sumit Bose wrote: > On Fri,

Re: [SSSD] [PATCH] Make subdomain discovery less noisy

2012-09-24 Thread Pavel Březina
On 09/24/2012 04:25 PM, Sumit Bose wrote: On Mon, Sep 24, 2012 at 01:03:44PM +0200, Jakub Hrozek wrote: On Mon, Sep 24, 2012 at 12:41:07PM +0200, Pavel Březina wrote: On 09/21/2012 06:42 PM, Sumit Bose wrote: On Fri, Sep 21, 2012 at 11:06:28AM +0200, Pavel Březina wrote: On 09/20/2012 09:16 P

Re: [SSSD] [PATCH] sdap_get_ad_tokengroups_initgroups_lookup_done(): fix group_name may be uninitialized warning

2012-09-24 Thread Stephen Gallagher
On Mon 24 Sep 2012 11:24:59 AM EDT, Stephen Gallagher wrote: On Mon 24 Sep 2012 11:01:20 AM EDT, Pavel Březina wrote: Recent AD patches introduced another warning. If I read the code correctly it is safe to just initialize the variable to NULL. Nack, this would not be safe. We would then be

[SSSD] [PATCH] sdap_get_ad_tokengroups_initgroups_lookup_done(): fix group_name may be uninitialized warning

2012-09-24 Thread Pavel Březina
Recent AD patches introduced another warning. If I read the code correctly it is safe to just initialize the variable to NULL. From 21f905fb991abb089191f8aba1aeebb8e0cef35b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Mon, 24 Sep 2012 16:58:46 +0200 Subject: [PATCH] sda

Re: [SSSD] [PATCH] SYSDB: Remove unnecessary domain parameter from several sysdb calls

2012-09-24 Thread Michal Židek
On 09/24/2012 03:35 PM, Jakub Hrozek wrote: On Mon, Sep 24, 2012 at 01:24:15PM +0200, Michal Židek wrote: On 09/23/2012 09:02 PM, Jakub Hrozek wrote: The domain can be read from the sysdb object. Removing the domain string makes the API more self-contained. The second patch just changes void *

Re: [SSSD] AUTOFS: Store entry objects below map objects

2012-09-24 Thread Pavel Březina
On 09/24/2012 04:52 PM, Jakub Hrozek wrote: On Mon, Sep 24, 2012 at 04:41:51PM +0200, Pavel Březina wrote: On 09/24/2012 03:44 PM, Jakub Hrozek wrote: On Mon, Sep 24, 2012 at 01:12:51PM +0200, Pavel Březina wrote: On 09/23/2012 08:47 PM, Jakub Hrozek wrote: [PATCH 1/5] AUTOFS: Do not fail if

Re: [SSSD] [PATCH] Mark the fastcache files in the spec file as %ghost

2012-09-24 Thread Stephen Gallagher
On 09/23/2012 03:34 PM, Jakub Hrozek wrote: https://fedorahosted.org/sssd/ticket/1487 In order to support building on RHEL5, we need to 'touch' the fastcache files in the build root, otherwise the old rpmbuild on RHEL 5 will fail. ___ sssd-devel m

Re: [SSSD] AUTOFS: Store entry objects below map objects

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 04:41:51PM +0200, Pavel Březina wrote: > On 09/24/2012 03:44 PM, Jakub Hrozek wrote: > >On Mon, Sep 24, 2012 at 01:12:51PM +0200, Pavel Březina wrote: > >>On 09/23/2012 08:47 PM, Jakub Hrozek wrote: > >>>[PATCH 1/5] AUTOFS: Do not fail if search base is not provided > >>>We

[SSSD] [PATCH] Bad debug message when no dns_discovery_domain specified.

2012-09-24 Thread Michal Židek
https://fedorahosted.org/sssd/ticket/920 The debug message was simplified and two new debug messages were added. Patch is attached. Michal >From 1ede60421b67ed985267bb407cd13dfeb6380ceb Mon Sep 17 00:00:00 2001 From: Michal Zidek Date: Mon, 24 Sep 2012 16:30:57 +0200 Subject: [PATCH] Bad debug

Re: [SSSD] AUTOFS: Store entry objects below map objects

2012-09-24 Thread Pavel Březina
On 09/24/2012 03:44 PM, Jakub Hrozek wrote: On Mon, Sep 24, 2012 at 01:12:51PM +0200, Pavel Březina wrote: On 09/23/2012 08:47 PM, Jakub Hrozek wrote: [PATCH 1/5] AUTOFS: Do not fail if search base is not provided We need to fall back to rootDSE provided search base instead of failing Ack.

Re: [SSSD] [PATCH] Make subdomain discovery less noisy

2012-09-24 Thread Sumit Bose
On Mon, Sep 24, 2012 at 01:03:44PM +0200, Jakub Hrozek wrote: > On Mon, Sep 24, 2012 at 12:41:07PM +0200, Pavel Březina wrote: > > On 09/21/2012 06:42 PM, Sumit Bose wrote: > > >On Fri, Sep 21, 2012 at 11:06:28AM +0200, Pavel Březina wrote: > > >>On 09/20/2012 09:16 PM, Sumit Bose wrote: > > >>>Hi,

Re: [SSSD] [PATCH] KRB5: Recover gracefully if the ccache file could not be reused

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 12:35:50PM +0200, Sumit Bose wrote: > On Sun, Sep 23, 2012 at 11:12:30PM +0200, Jakub Hrozek wrote: > > https://fedorahosted.org/sssd/ticket/1384 > > > > I tested by logging in from one terminal, then chowning the ccache to > > root.root to make the existing ccache unusable

Re: [SSSD] [PATCHES] SSH: Expire hosts in known_hosts

2012-09-24 Thread Jan Cholasta
Dne 24.9.2012 15:03, Pavel Březina napsal(a): On 09/19/2012 12:09 PM, Jan Cholasta wrote: Hi, this patch set changes the way the known_hosts file is updated so that only entries for hosts that were requested recently (in the last 5 minutes) are written to the file. There is no need to keep olde

Re: [SSSD] AUTOFS: Store entry objects below map objects

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 01:12:51PM +0200, Pavel Březina wrote: > On 09/23/2012 08:47 PM, Jakub Hrozek wrote: > >[PATCH 1/5] AUTOFS: Do not fail if search base is not provided > >We need to fall back to rootDSE provided search base instead of failing > > Ack. > > >[PATCH 2/5] AUTOFS: Add sysdb tes

Re: [SSSD] [PATCH] SYSDB: Remove unnecessary domain parameter from several sysdb calls

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 01:24:15PM +0200, Michal Židek wrote: > On 09/23/2012 09:02 PM, Jakub Hrozek wrote: > >The domain can be read from the sysdb object. Removing the domain string > >makes the API more self-contained. > > > >The second patch just changes void * to TALLOC_CTX * on several places

Re: [SSSD] [PATCH] autofs, sudo and ssh are not experimental anymore

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 02:09:33PM +0200, Pavel Březina wrote: > On 09/24/2012 02:04 PM, Jakub Hrozek wrote: > >On Mon, Sep 24, 2012 at 01:58:51PM +0200, Pavel Březina wrote: > >>On 09/21/2012 02:34 PM, Jakub Hrozek wrote: > >>>The autofs integration, ssh integration and the PAC responder are not >

Re: [SSSD] [PATCH] sdap_add_incomplete_groups(): fix ret may be uninitialized warning

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 03:05:20PM +0200, Jakub Hrozek wrote: > On Mon, Sep 24, 2012 at 02:24:03PM +0200, Pavel Březina wrote: > > This warning was seen with: > > -m64 -mtune=generic -O3 -D_FORTIFY_SOURCE=2 -fstack-protector-all > > -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter > > Ack. I

Re: [SSSD] [PATCH] sdap_add_incomplete_groups(): fix ret may be uninitialized warning

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 02:24:03PM +0200, Pavel Březina wrote: > This warning was seen with: > -m64 -mtune=generic -O3 -D_FORTIFY_SOURCE=2 -fstack-protector-all > -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter Ack. I could swear we fixed this a long time ago. ___

Re: [SSSD] [PATCHES] SSH: Expire hosts in known_hosts

2012-09-24 Thread Pavel Březina
On 09/19/2012 12:09 PM, Jan Cholasta wrote: Hi, this patch set changes the way the known_hosts file is updated so that only entries for hosts that were requested recently (in the last 5 minutes) are written to the file. There is no need to keep older entries in the file, as host keys are needed

Re: [SSSD] [PATCHES] Performance enhancements for AD provider

2012-09-24 Thread Jakub Hrozek
On Fri, Sep 21, 2012 at 02:49:27PM +0200, Jakub Hrozek wrote: > Ack to both patches. Pushed to master. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

[SSSD] [PATCH] sdap_add_incomplete_groups(): fix ret may be uninitialized warning

2012-09-24 Thread Pavel Březina
This warning was seen with: -m64 -mtune=generic -O3 -D_FORTIFY_SOURCE=2 -fstack-protector-all -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter From 5432d4d6dc42771f76db1bec7005d683976087e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Mon, 24 Sep 2012 14:21:53 +0200

Re: [SSSD] [PATCH] autofs, sudo and ssh are not experimental anymore

2012-09-24 Thread Pavel Březina
On 09/24/2012 02:04 PM, Jakub Hrozek wrote: On Mon, Sep 24, 2012 at 01:58:51PM +0200, Pavel Březina wrote: On 09/21/2012 02:34 PM, Jakub Hrozek wrote: The autofs integration, ssh integration and the PAC responder are not experimental in the 1.9.0 release anymore. The features are now built by

Re: [SSSD] [PATCH] autofs, sudo and ssh are not experimental anymore

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 01:58:51PM +0200, Pavel Březina wrote: > On 09/21/2012 02:34 PM, Jakub Hrozek wrote: > >The autofs integration, ssh integration and the PAC responder are not > >experimental in the 1.9.0 release anymore. > > > >The features are now built by default. I was wondering if that w

Re: [SSSD] [PATCH] autofs, sudo and ssh are not experimental anymore

2012-09-24 Thread Pavel Březina
On 09/21/2012 02:34 PM, Jakub Hrozek wrote: The autofs integration, ssh integration and the PAC responder are not experimental in the 1.9.0 release anymore. The features are now built by default. I was wondering if that was a good idea because other platforms than Fedora would have to turn the f

Re: [SSSD] [PATCHES] sss_cache tool invalidates records in memory cache

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 01:13:47PM +0200, Jakub Hrozek wrote: > On Mon, Sep 24, 2012 at 12:15:06PM +0200, Michal Židek wrote: > > On 09/20/2012 07:12 PM, Jakub Hrozek wrote: > > >On Tue, Sep 18, 2012 at 01:26:20PM +0200, Michal Židek wrote: > > >>On 09/17/2012 06:02 PM, Simo Sorce wrote: > > >>> >

Re: [SSSD] [PATCH] SYSDB: Remove unnecessary domain parameter from several sysdb calls

2012-09-24 Thread Michal Židek
On 09/23/2012 09:02 PM, Jakub Hrozek wrote: The domain can be read from the sysdb object. Removing the domain string makes the API more self-contained. The second patch just changes void * to TALLOC_CTX * on several places. ___ sssd-devel mailing li

Re: [SSSD] [PATCHES] sss_cache tool invalidates records in memory cache

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 12:15:06PM +0200, Michal Židek wrote: > On 09/20/2012 07:12 PM, Jakub Hrozek wrote: > >On Tue, Sep 18, 2012 at 01:26:20PM +0200, Michal Židek wrote: > >>On 09/17/2012 06:02 PM, Simo Sorce wrote: > >>> > >>>Hi Michal, > >>>you bring up a good point about the race with startup

Re: [SSSD] AUTOFS: Store entry objects below map objects

2012-09-24 Thread Pavel Březina
On 09/23/2012 08:47 PM, Jakub Hrozek wrote: [PATCH 1/5] AUTOFS: Do not fail if search base is not provided We need to fall back to rootDSE provided search base instead of failing Ack. [PATCH 2/5] AUTOFS: Add sysdb tests I knew I would be changing the sysdb interface so I coded up tests to avo

Re: [SSSD] [PATCH] Mark the fastcache files in the spec file as %ghost

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 12:19:34PM +0200, Sumit Bose wrote: > On Sun, Sep 23, 2012 at 09:34:13PM +0200, Jakub Hrozek wrote: > > https://fedorahosted.org/sssd/ticket/1487 > > ACK > > bye, > Sumit Pushed to master. ___ sssd-devel mailing list sssd-devel@

Re: [SSSD] [PATCH] AD: autorid compatibility should recommend the use of, default domain

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 01:04:30PM +0200, Jakub Hrozek wrote: > On Fri, Sep 21, 2012 at 11:12:37AM -0400, Stephen Gallagher wrote: > > On 09/21/2012 10:19 AM, Stephen Gallagher wrote: > > >Previously, we were failing to start if ldap_idmap_autorid_compat > > >was True but the default domain SID was

Re: [SSSD] [PATCH] AD: autorid compatibility should recommend the use of, default domain

2012-09-24 Thread Jakub Hrozek
On Fri, Sep 21, 2012 at 11:12:37AM -0400, Stephen Gallagher wrote: > On 09/21/2012 10:19 AM, Stephen Gallagher wrote: > >Previously, we were failing to start if ldap_idmap_autorid_compat > >was True but the default domain SID was unspecified. This is the > >recommended configuration, but it is func

Re: [SSSD] [PATCH] Make subdomain discovery less noisy

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 12:41:07PM +0200, Pavel Březina wrote: > On 09/21/2012 06:42 PM, Sumit Bose wrote: > >On Fri, Sep 21, 2012 at 11:06:28AM +0200, Pavel Březina wrote: > >>On 09/20/2012 09:16 PM, Sumit Bose wrote: > >>>Hi, > >>> > >>>this patch fixeshttps://fedorahosted.org/sssd/ticket/1517 b

Re: [SSSD] [PATCH] Detect LDAPDerefRes in configure script

2012-09-24 Thread Jakub Hrozek
On Mon, Sep 24, 2012 at 12:18:36PM +0200, Sumit Bose wrote: > On Sun, Sep 23, 2012 at 09:10:04PM +0200, Jakub Hrozek wrote: > > To test, remove the openldap24 RPMs on RHEL5 systems and attempt to > > build the SSSD. Without the patch, compilation fails because there's no > > LDAPDerefRes. With the

Re: [SSSD] [PATCH] Make subdomain discovery less noisy

2012-09-24 Thread Pavel Březina
On 09/21/2012 06:42 PM, Sumit Bose wrote: On Fri, Sep 21, 2012 at 11:06:28AM +0200, Pavel Březina wrote: On 09/20/2012 09:16 PM, Sumit Bose wrote: Hi, this patch fixeshttps://fedorahosted.org/sssd/ticket/1517 by increasing some of the debug levels and print a log messages about the actual req

Re: [SSSD] [PATCH] KRB5: Recover gracefully if the ccache file could not be reused

2012-09-24 Thread Sumit Bose
On Sun, Sep 23, 2012 at 11:12:30PM +0200, Jakub Hrozek wrote: > https://fedorahosted.org/sssd/ticket/1384 > > I tested by logging in from one terminal, then chowning the ccache to > root.root to make the existing ccache unusable by the krb5_child process > and attempting to log in from another ter

Re: [SSSD] [PATCH] Mark the fastcache files in the spec file as %ghost

2012-09-24 Thread Sumit Bose
On Sun, Sep 23, 2012 at 09:34:13PM +0200, Jakub Hrozek wrote: > https://fedorahosted.org/sssd/ticket/1487 ACK bye, Sumit ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Detect LDAPDerefRes in configure script

2012-09-24 Thread Sumit Bose
On Sun, Sep 23, 2012 at 09:10:04PM +0200, Jakub Hrozek wrote: > To test, remove the openldap24 RPMs on RHEL5 systems and attempt to > build the SSSD. Without the patch, compilation fails because there's no > LDAPDerefRes. With the patch, the build process fails during configure. > > https://fedora

Re: [SSSD] [PATCHES] sss_cache tool invalidates records in memory cache

2012-09-24 Thread Michal Židek
On 09/20/2012 07:12 PM, Jakub Hrozek wrote: On Tue, Sep 18, 2012 at 01:26:20PM +0200, Michal Židek wrote: On 09/17/2012 06:02 PM, Simo Sorce wrote: Hi Michal, you bring up a good point about the race with startup, but I am not totally convinced about the approach you used to address it. The r