Re: [SSSD] [PATCH] SERVER: Check the return value of waitpid

2012-11-19 Thread Ondrej Kos
On 11/19/2012 12:05 AM, Jakub Hrozek wrote: We should at least print an error message and error out if waitpid() fails. https://fedorahosted.org/sssd/ticket/1651 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

[SSSD] [PATCH] LDAP: Make it possible to use full principal in ldap_sasl_authid again

2012-11-19 Thread Jakub Hrozek
The behaviour of ldap_sasl_authid was changed in e81a816cddab4a62f263d1a0274d5d3f101e8e0f so that it no longer accepted full principal, but only hostname. The realm was read from the (undocumented) ldap_sasl_realm option. Moreover the hostname had to be specified in exactly the format that would

Re: [SSSD] [PATCH] SERVER: Check the return value of waitpid

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 10:23:45AM +0100, Ondrej Kos wrote: On 11/19/2012 12:05 AM, Jakub Hrozek wrote: We should at least print an error message and error out if waitpid() fails. https://fedorahosted.org/sssd/ticket/1651 ___ sssd-devel

Re: [SSSD] [PATCH 0/1] Simplify writing update functions

2012-11-19 Thread Sumit Bose
On Wed, Nov 14, 2012 at 09:17:53AM -0500, Simo Sorce wrote: While approaching the problem of updating the DB after a patch I am working on I noticed that we do have a lot of biolerplate code in there that could very simply be tucked into 2 helper functions, simplifying writing upgrade

Re: [SSSD] [PATCH] Fix saving empty LDAP groups

2012-11-19 Thread Pavel Březina
On 11/16/2012 02:35 PM, Simo Sorce wrote: On Fri, 2012-11-16 at 12:22 +0100, Pavel Březina wrote: On 11/16/2012 12:06 PM, Jakub Hrozek wrote: On Thu, Nov 15, 2012 at 12:55:37PM +0100, Jakub Hrozek wrote: On Thu, Nov 15, 2012 at 10:57:37AM +0100, Jakub Hrozek wrote: We broke saving nested

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 08:45:35AM +0100, Ondrej Kos wrote: On 11/16/2012 04:40 PM, Jan Cholasta wrote: On 16.11.2012 15:25, Ondrej Kos wrote: On 11/15/2012 03:03 PM, Jan Cholasta wrote: On 14.11.2012 16:20, Ondrej Kos wrote: On 11/14/2012 03:38 PM, Simo Sorce wrote: On Wed, 2012-11-14 at

Re: [SSSD] [PATCH] Fix saving empty LDAP groups

2012-11-19 Thread Pavel Březina
On 11/16/2012 02:35 PM, Simo Sorce wrote: On Fri, 2012-11-16 at 12:22 +0100, Pavel Březina wrote: On 11/16/2012 12:06 PM, Jakub Hrozek wrote: On Thu, Nov 15, 2012 at 12:55:37PM +0100, Jakub Hrozek wrote: On Thu, Nov 15, 2012 at 10:57:37AM +0100, Jakub Hrozek wrote: We broke saving nested

Re: [SSSD] [PATCH] Restart services with a delay in case they are restarted too often

2012-11-19 Thread Pavel Březina
On 11/18/2012 06:09 PM, Jakub Hrozek wrote: On Fri, Nov 16, 2012 at 11:41:50AM +0100, Pavel Březina wrote: On 11/15/2012 07:51 PM, Jakub Hrozek wrote: In case a service is restarted while the DP is not ready yet, it gets restarted again immediatelly, which means the DP might still not be

[SSSD] [PATCH] debug: print fatal and critical errors if debug level is, unresolved

2012-11-19 Thread Michal Židek
https://fedorahosted.org/sssd/ticket/1345 https://bugzilla.redhat.com/show_bug.cgi?id=824244 With this patch, macro DEBUG_IS_SET returns true if debug_level has value SSSDBG_UNRESOLVED and the message is of level SSSDBG_CRITICAL_FAILURE or SSSDBG_FATAL_FAILURE. Patch is in attachment.

[SSSD] [PATCH] SYSDB: Don't operate with aliases same as name

2012-11-19 Thread Ondrej Kos
On 11/16/2012 05:02 PM, Jakub Hrozek wrote: On Fri, Nov 16, 2012 at 03:53:07PM +0100, Jakub Hrozek wrote: On Fri, Nov 16, 2012 at 02:04:57PM +0100, Ondrej Kos wrote: fixes https://fedorahosted.org/sssd/ticket/1628 When user's alias was the same as pw_name, the sysdb search was failing. This

Re: [SSSD] [PATCH] Display more information on DB version crash

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 01:22:21PM +0100, Jakub Hrozek wrote: Thank you. Replace this: +ERROR(Higher version of database is expected!\n); \ +SYSDB_VERSION_ERROR_HINT; \ +ERROR(In this case, you could also try running SSSD, \ + which should

Re: [SSSD] [PATCH] SYSDB: Don't operate with aliases same as name

2012-11-19 Thread Ondrej Kos
On 11/19/2012 01:36 PM, Ondrej Kos wrote: On 11/16/2012 05:02 PM, Jakub Hrozek wrote: On Fri, Nov 16, 2012 at 03:53:07PM +0100, Jakub Hrozek wrote: On Fri, Nov 16, 2012 at 02:04:57PM +0100, Ondrej Kos wrote: fixes https://fedorahosted.org/sssd/ticket/1628 When user's alias was the same as

Re: [SSSD] [PATCH] SERVER: Check the return value of waitpid

2012-11-19 Thread Ondrej Kos
On 11/19/2012 12:15 PM, Jakub Hrozek wrote: On Mon, Nov 19, 2012 at 10:23:45AM +0100, Ondrej Kos wrote: On 11/19/2012 12:05 AM, Jakub Hrozek wrote: We should at least print an error message and error out if waitpid() fails. https://fedorahosted.org/sssd/ticket/1651

Re: [SSSD] [PATCH] debug: print fatal and critical errors if debug level is, unresolved

2012-11-19 Thread Michal Židek
On 11/19/2012 01:32 PM, Michal Židek wrote: https://fedorahosted.org/sssd/ticket/1345 https://bugzilla.redhat.com/show_bug.cgi?id=824244 With this patch, macro DEBUG_IS_SET returns true if debug_level has value SSSDBG_UNRESOLVED and the message is of level SSSDBG_CRITICAL_FAILURE or

Re: [SSSD] [PATCH] debug: print fatal and critical errors if debug level is, unresolved

2012-11-19 Thread Michal Židek
On 11/19/2012 01:54 PM, Michal Židek wrote: On 11/19/2012 01:32 PM, Michal Židek wrote: https://fedorahosted.org/sssd/ticket/1345 https://bugzilla.redhat.com/show_bug.cgi?id=824244 With this patch, macro DEBUG_IS_SET returns true if debug_level has value SSSDBG_UNRESOLVED and the message is of

Re: [SSSD] [PATCH] SERVER: Check the return value of waitpid

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 01:43:45PM +0100, Ondrej Kos wrote: On 11/19/2012 12:15 PM, Jakub Hrozek wrote: On Mon, Nov 19, 2012 at 10:23:45AM +0100, Ondrej Kos wrote: On 11/19/2012 12:05 AM, Jakub Hrozek wrote: We should at least print an error message and error out if waitpid() fails.

Re: [SSSD] [PATCH] LDAP: Make it possible to use full principal in ldap_sasl_authid again

2012-11-19 Thread Pavel Březina
On 11/19/2012 11:53 AM, Jakub Hrozek wrote: The behaviour of ldap_sasl_authid was changed in e81a816cddab4a62f263d1a0274d5d3f101e8e0f so that it no longer accepted full principal, but only hostname. The realm was read from the (undocumented) ldap_sasl_realm option. Moreover the hostname had to

Re: [SSSD] [PATCH] debug: print fatal and critical errors if debug level is, unresolved

2012-11-19 Thread Simo Sorce
On Mon, 2012-11-19 at 14:13 +0100, Michal Židek wrote: SSSDBG_CRITICAL_FAILURE or SSSDBG_FATAL_FAILURE It seem that you are expanding the set of errors printed when no debug level is set. Before it was just the old level 0, now it's the old level 0 and 1. Why ? Simo. -- Simo Sorce * Red Hat,

Re: [SSSD] [PATCH 0/1] Simplify writing update functions

2012-11-19 Thread Simo Sorce
On Mon, 2012-11-19 at 12:37 +0100, Sumit Bose wrote: On Wed, Nov 14, 2012 at 09:17:53AM -0500, Simo Sorce wrote: While approaching the problem of updating the DB after a patch I am working on I noticed that we do have a lot of biolerplate code in there that could very simply be tucked into

Re: [SSSD] [PATCH] Fix saving empty LDAP groups

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 12:30:36PM +0100, Pavel Březina wrote: On 11/16/2012 02:35 PM, Simo Sorce wrote: On Fri, 2012-11-16 at 12:22 +0100, Pavel Březina wrote: On 11/16/2012 12:06 PM, Jakub Hrozek wrote: On Thu, Nov 15, 2012 at 12:55:37PM +0100, Jakub Hrozek wrote: On Thu, Nov 15, 2012 at

Re: [SSSD] [PATCH 0/1] Simplify writing update functions

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 08:41:25AM -0500, Simo Sorce wrote: On Mon, 2012-11-19 at 12:37 +0100, Sumit Bose wrote: On Wed, Nov 14, 2012 at 09:17:53AM -0500, Simo Sorce wrote: While approaching the problem of updating the DB after a patch I am working on I noticed that we do have a lot

Re: [SSSD] [PATCH] debug: print fatal and critical errors if debug level is, unresolved

2012-11-19 Thread Michal Židek
On 11/19/2012 02:38 PM, Simo Sorce wrote: On Mon, 2012-11-19 at 14:13 +0100, Michal Židek wrote: SSSDBG_CRITICAL_FAILURE or SSSDBG_FATAL_FAILURE It seem that you are expanding the set of errors printed when no debug level is set. Before it was just the old level 0, now it's the old level 0

Re: [SSSD] [PATCH 0/3] Fix group memberships and hbac rules in subdomains

2012-11-19 Thread Jakub Hrozek
On Sun, Nov 18, 2012 at 10:29:46PM +0100, Jakub Hrozek wrote: On Sun, Nov 18, 2012 at 03:54:54PM -0500, Simo Sorce wrote: On Sun, 2012-11-18 at 18:27 +0100, Jakub Hrozek wrote: On Sun, Nov 18, 2012 at 06:05:45PM +0100, Sumit Bose wrote: On Fri, Nov 16, 2012 at 04:25:41PM -0500, Simo

Re: [SSSD] [PATCHES] Fix password change for trusted AD users

2012-11-19 Thread Jakub Hrozek
On Wed, Nov 14, 2012 at 06:33:04PM +0100, Sumit Bose wrote: On Wed, Nov 14, 2012 at 12:03:14PM -0500, Simo Sorce wrote: On Wed, 2012-11-14 at 17:27 +0100, Sumit Bose wrote: Hi, the following three patches make password changes for trusted AD users work and fix

Re: [SSSD] [PATCH] Restart services with a delay in case they are restarted too often

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 01:29:39PM +0100, Pavel Březina wrote: Hi, nitpicks... +/* TODO: get the restart related values from config */ +#define MONITOR_RESTART_CNT_RESET 30 I had some troubles interpreting this macro. Can you change the name in such way that it is more clear that we

Re: [SSSD] [PATCH] LDAP: Make it possible to use full principal in ldap_sasl_authid again

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 02:29:59PM +0100, Pavel Březina wrote: On 11/19/2012 11:53 AM, Jakub Hrozek wrote: The behaviour of ldap_sasl_authid was changed in e81a816cddab4a62f263d1a0274d5d3f101e8e0f so that it no longer accepted full principal, but only hostname. The realm was read from the

[SSSD] [PATCH] BUILD: Temporary workaround for Kerberos build

2012-11-19 Thread Stephen Gallagher
This patch extends the Kerberos version check to support Kerberos version 1.11 alpha and later. It is a temporary measure until we can redesign the configure checks for better granularity. From 3d85867e0946c75a3581e05e3d32e99cdbcaad01 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher

Re: [SSSD] simple access provider / non-sss users

2012-11-19 Thread Dmitri Pal
On 11/16/2012 07:12 PM, Paul B. Henson wrote: On 11/16/2012 12:55 PM, Dmitri Pal wrote: Would moving such accounts into local sssd provider help? Hmm, that would be similar in concept to proxying nss_files, although certainly less kludgy on the sss side. However, we have existing procedures

Re: [SSSD] [PATCH] BUILD: Temporary workaround for Kerberos build

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 10:42:34AM -0500, Stephen Gallagher wrote: This patch extends the Kerberos version check to support Kerberos version 1.11 alpha and later. It is a temporary measure until we can redesign the configure checks for better granularity. Ack

Re: [SSSD] [PATCH] LDAP: Make it possible to use full principal in ldap_sasl_authid again

2012-11-19 Thread Stephen Gallagher
On Mon 19 Nov 2012 10:35:43 AM EST, Jakub Hrozek wrote: On Mon, Nov 19, 2012 at 02:29:59PM +0100, Pavel Březina wrote: On 11/19/2012 11:53 AM, Jakub Hrozek wrote: The behaviour of ldap_sasl_authid was changed in e81a816cddab4a62f263d1a0274d5d3f101e8e0f so that it no longer accepted full

[SSSD] [PATCH] warn user if password is about to expire

2012-11-19 Thread Pavel Březina
https://fedorahosted.org/sssd/ticket/1638 From a545faa3aa0c13cc32cd0c0a0e880a311aa0f2de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= pbrez...@redhat.com Date: Mon, 19 Nov 2012 16:52:36 +0100 Subject: [PATCH] warn user if password is about to expire

Re: [SSSD] [PATCH] Restart services with a delay in case they are restarted too often

2012-11-19 Thread Pavel Březina
On 11/19/2012 03:55 PM, Jakub Hrozek wrote: On Mon, Nov 19, 2012 at 01:29:39PM +0100, Pavel Březina wrote: Hi, nitpicks... +/* TODO: get the restart related values from config */ +#define MONITOR_RESTART_CNT_RESET 30 I had some troubles interpreting this macro. Can you change the name in

Re: [SSSD] [PATCH] LDAP: Only convert direct parents' ghost attribute to member

2012-11-19 Thread Pavel Březina
On 11/18/2012 11:58 PM, Jakub Hrozek wrote: [PATCH 1/2] SYSDB: Use the add_string convenience functions for managing ghost user attribute Using the convenience function instead of low-level ldb calls makes the code more compact and more readable. [PATCH 2/2] LDAP: Only convert direct parents'

Re: [SSSD] [PATCHES] Fix password change for trusted AD users

2012-11-19 Thread Sumit Bose
On Mon, Nov 19, 2012 at 03:45:06PM +0100, Jakub Hrozek wrote: On Wed, Nov 14, 2012 at 06:33:04PM +0100, Sumit Bose wrote: On Wed, Nov 14, 2012 at 12:03:14PM -0500, Simo Sorce wrote: On Wed, 2012-11-14 at 17:27 +0100, Sumit Bose wrote: Hi, the following three patches make

Re: [SSSD] [PATCH] Restart services with a delay in case they are restarted too often

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 05:04:43PM +0100, Pavel Březina wrote: On 11/19/2012 03:55 PM, Jakub Hrozek wrote: On Mon, Nov 19, 2012 at 01:29:39PM +0100, Pavel Březina wrote: Hi, nitpicks... +/* TODO: get the restart related values from config */ +#define MONITOR_RESTART_CNT_RESET 30 I had

Re: [SSSD] [PATCH] LDAP: Make it possible to use full principal in ldap_sasl_authid again

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 10:54:43AM -0500, Stephen Gallagher wrote: On Mon 19 Nov 2012 10:35:43 AM EST, Jakub Hrozek wrote: On Mon, Nov 19, 2012 at 02:29:59PM +0100, Pavel Březina wrote: On 11/19/2012 11:53 AM, Jakub Hrozek wrote: The behaviour of ldap_sasl_authid was changed in

[SSSD] [PATCH] KRB5: Fix UPN size check

2012-11-19 Thread Jakub Hrozek
Compare_principal_realm ran a sanity check on UPN size and realm size, but the check was not correct in case the realms were different and the UPN realm was much shorter then the realm parameter. From 153208abeb8d325026084b03371104a4b4cdda2b Mon Sep 17 00:00:00 2001 From: Jakub Hrozek

Re: [SSSD] [PATCH] KRB5: Fix UPN size check

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 09:42:04PM +0100, Jakub Hrozek wrote: Compare_principal_realm ran a sanity check on UPN size and realm size, but the check was not correct in case the realms were different and the UPN realm was much shorter then the realm parameter. Self-nack. This is fixed elsewhere

Re: [SSSD] [PATCHES] Fix password change for trusted AD users

2012-11-19 Thread Sumit Bose
On Mon, Nov 19, 2012 at 10:15:48PM +0100, Jakub Hrozek wrote: On Mon, Nov 19, 2012 at 05:53:38PM +0100, Sumit Bose wrote: On Mon, Nov 19, 2012 at 03:45:06PM +0100, Jakub Hrozek wrote: On Wed, Nov 14, 2012 at 06:33:04PM +0100, Sumit Bose wrote: On Wed, Nov 14, 2012 at 12:03:14PM -0500,

[SSSD] Wrong DB version (got 0.13 expected 0.10)

2012-11-19 Thread Ariel Barria
Hi. for orientation please. I do this ./sssd -d9 -i and output is this Wrong DB version (got 0.13 expected 0.10) What should I upgrade? thanks [root@dev1 parallelbuilddir]# ./sssd -d9 -i (Mon Nov 19 15:39:53:858674 2012) [sssd] [check_file]

Re: [SSSD] [PATCHES] Fix password change for trusted AD users

2012-11-19 Thread Jakub Hrozek
On Wed, Nov 14, 2012 at 06:33:04PM +0100, Sumit Bose wrote: On Wed, Nov 14, 2012 at 12:03:14PM -0500, Simo Sorce wrote: On Wed, 2012-11-14 at 17:27 +0100, Sumit Bose wrote: Hi, the following three patches make password changes for trusted AD users work and fix

Re: [SSSD] [PATCHES] Fix password change for trusted AD users

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 10:15:48PM +0100, Jakub Hrozek wrote: On Mon, Nov 19, 2012 at 05:53:38PM +0100, Sumit Bose wrote: On Mon, Nov 19, 2012 at 03:45:06PM +0100, Jakub Hrozek wrote: On Wed, Nov 14, 2012 at 06:33:04PM +0100, Sumit Bose wrote: On Wed, Nov 14, 2012 at 12:03:14PM -0500,

Re: [SSSD] [PATCH] LDAP: Only convert direct parents' ghost attribute to member

2012-11-19 Thread Jakub Hrozek
On Mon, Nov 19, 2012 at 05:51:53PM +0100, Pavel Březina wrote: On 11/18/2012 11:58 PM, Jakub Hrozek wrote: [PATCH 1/2] SYSDB: Use the add_string convenience functions for managing ghost user attribute Using the convenience function instead of low-level ldb calls makes the code more compact

Re: [SSSD] [PATCH] LDAP: Only convert direct parents' ghost attribute to member

2012-11-19 Thread Simo Sorce
On Mon, 2012-11-19 at 23:31 +0100, Jakub Hrozek wrote: On Mon, Nov 19, 2012 at 05:51:53PM +0100, Pavel Březina wrote: On 11/18/2012 11:58 PM, Jakub Hrozek wrote: [PATCH 1/2] SYSDB: Use the add_string convenience functions for managing ghost user attribute Using the convenience function

Re: [SSSD] Wrong DB version (got 0.13 expected 0.10)

2012-11-19 Thread Ondrej Kos
On 11/19/2012 10:26 PM, Ariel Barria wrote: Hi. for orientation please. I do this ./sssd -d9 -i and output is this *Wrong DB version (got 0.13 expected 0.10)* What should I upgrade? thanks ___ sssd-devel mailing list