Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-14 Thread Sumit Bose
On Fri, Oct 11, 2013 at 05:08:17PM -0400, Dmitri Pal wrote: > On 10/11/2013 07:47 AM, Sumit Bose wrote: > > On Fri, Oct 11, 2013 at 12:53:48PM +0200, Benjamin Franzke wrote: > >> 2013/10/11 Sumit Bose > >> > >>> On Thu, Oct 10, 2013 at 02:41:54PM +0200, Benjamin Franzke wrote: > Thanks for yo

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-14 Thread Sumit Bose
On Sat, Oct 12, 2013 at 06:21:26AM +0200, Benjamin Franzke wrote: > Hi Dmitri, > > > 2013/10/11 Dmitri Pal > > > On 10/11/2013 07:47 AM, Sumit Bose wrote: > > > On Fri, Oct 11, 2013 at 12:53:48PM +0200, Benjamin Franzke wrote: > > >> 2013/10/11 Sumit Bose > > >> > > >>> On Thu, Oct 10, 2013 at

Re: [SSSD] Fwd: [sudo-users] objectClass=sudoRule vs objectClass=sudoRole in AD

2013-10-14 Thread Pavel Březina
On 10/12/2013 04:43 PM, JR Aquino wrote: This feels like a valid bug/typo. I think it may be worth a ticket Hi, Benjamin is correct that it is a query to SSSD cache (sysdb). LDAP attributes are mapped to sysdb attributes on the fly. Sysdb schema doesn't necessarily have to correspond with LD

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-14 Thread Benjamin Franzke
Oh, sorry, I shared an old branch between my devel machine and the testing virtual machine, where i did some other changes, which i merged later on, which caused this. Sorry.. I've merge the changes again.. And gone through the notes in this thread, to ensure they are all included now. 2013/10/14

[SSSD] [PATCH] krb5: Use right function to free data

2013-10-14 Thread Lukas Slebodnik
ehlo, This patch fixes warning reported by clang static analyzer. Simple patch is attached. LS >From 3c910455b63348e52026d9d61870ed44380e44e2 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 14 Oct 2013 11:08:48 +0200 Subject: [PATCH] krb5: Use right function to free data. In function

[SSSD] [PATCH] krb5: Check return value of sss_krb5_princ_realm

2013-10-14 Thread Lukas Slebodnik
ehlo, yet another warning from clang static analyser. sss_krb5_princ_realm set output parameter realm to NULL and len to 0 in case of failure. Clang static analysers repoted warning "Null pointer passed as an argument to a 'nonnull' parameter" in function match_principal. It was possible, that re

Re: [SSSD] [PATCH] krb5: Use right function to free data

2013-10-14 Thread Sumit Bose
On Mon, Oct 14, 2013 at 11:16:41AM +0200, Lukas Slebodnik wrote: > ehlo, > > This patch fixes warning reported by clang static analyzer. > Simple patch is attached. > > LS > From 3c910455b63348e52026d9d61870ed44380e44e2 Mon Sep 17 00:00:00 2001 > From: Lukas Slebodnik > Date: Mon, 14 Oct 2013 1

Re: [SSSD] [PATCH] CIFS idmap Plugin using SSSD

2013-10-14 Thread Sumit Bose
On Mon, Oct 14, 2013 at 11:00:44AM +0200, Benjamin Franzke wrote: > Oh, sorry, I shared an old branch between my devel machine and the testing > virtual machine, where i did some other changes, which i merged later on, > which caused this. Sorry.. > I've merge the changes again.. And gone through t

[SSSD] [PATCH] Spec file changes for cifs-utils plugin

2013-10-14 Thread Sumit Bose
Hi, as promised I created the spec file changes to include the cifs-utils plugin into the sssd-client package on Fedora and RHEL platforms where recent cifs-utils are available. bye, Sumit ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org ht

Re: [SSSD] [PATCH] Spec file changes for cifs-utils plugin

2013-10-14 Thread Sumit Bose
and now with the patch included :-) On Mon, Oct 14, 2013 at 01:08:39PM +0200, Sumit Bose wrote: > Hi, > > as promised I created the spec file changes to include the cifs-utils > plugin into the sssd-client package on Fedora and RHEL platforms where > recent cifs-utils are available. > > bye, > S

Re: [SSSD] [PATCH] Spec file changes for cifs-utils plugin

2013-10-14 Thread Benjamin Franzke
Hi Sumit, Should the spec file also include an /etc/alternatives integration, like cifs-utils has? http://pkgs.fedoraproject.org/cgit/cifs-utils.git/tree/cifs-utils.spec#n90 2013/10/14 Sumit Bose > and now with the patch included :-) > > On Mon, Oct 14, 2013 at 01:08:39PM +0200, Sumit Bose wro

Re: [SSSD] [PATCH] Spec file changes for cifs-utils plugin

2013-10-14 Thread Sumit Bose
On Mon, Oct 14, 2013 at 01:15:02PM +0200, Benjamin Franzke wrote: > Hi Sumit, > > Should the spec file also include an /etc/alternatives integration, like > cifs-utils has? > http://pkgs.fedoraproject.org/cgit/cifs-utils.git/tree/cifs-utils.spec#n90 yes, my plan was to include this into the spec

Re: [SSSD] [PATCH] krb5: Use right function to free data

2013-10-14 Thread Lukas Slebodnik
On (14/10/13 12:32), Sumit Bose wrote: >On Mon, Oct 14, 2013 at 11:16:41AM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> This patch fixes warning reported by clang static analyzer. >> Simple patch is attached. >> >> LS > >> From 3c910455b63348e52026d9d61870ed44380e44e2 Mon Sep 17 00:00:00 2001 >>

[SSSD] [PATCH] LDAP: Set default value for dyndns update to false

2013-10-14 Thread Lukas Slebodnik
ehlo, In some cases, local boolean variable "do_update" could be used without proper initialisation. Clang static analyser warning: "Assigned value is garbage or undefined" It was not a big problem, because non-zero value for boolean variable mean true. Simple patch is attached. LS >From 0325b79

Re: [SSSD] [PATCH] Spec file changes for cifs-utils plugin

2013-10-14 Thread Sumit Bose
On Mon, Oct 14, 2013 at 01:37:01PM +0200, Sumit Bose wrote: > On Mon, Oct 14, 2013 at 01:15:02PM +0200, Benjamin Franzke wrote: > > Hi Sumit, > > > > Should the spec file also include an /etc/alternatives integration, like > > cifs-utils has? > > http://pkgs.fedoraproject.org/cgit/cifs-utils.git/t

Re: [SSSD] [PATCH] Spec file changes for cifs-utils plugin

2013-10-14 Thread Lukas Slebodnik
On (14/10/13 16:48), Sumit Bose wrote: >On Mon, Oct 14, 2013 at 01:37:01PM +0200, Sumit Bose wrote: >> On Mon, Oct 14, 2013 at 01:15:02PM +0200, Benjamin Franzke wrote: >> > Hi Sumit, >> > >> > Should the spec file also include an /etc/alternatives integration, like >> > cifs-utils has? >> > http:

Re: [SSSD] [PATCH] Spec file changes for cifs-utils plugin

2013-10-14 Thread Lukas Slebodnik
On (14/10/13 16:48), Sumit Bose wrote: >On Mon, Oct 14, 2013 at 01:37:01PM +0200, Sumit Bose wrote: >> On Mon, Oct 14, 2013 at 01:15:02PM +0200, Benjamin Franzke wrote: >> > Hi Sumit, >> > >> > Should the spec file also include an /etc/alternatives integration, like >> > cifs-utils has? >> > http: