ehlo,
Static library libsss_test_common calls tevent functions directly (in module
common_tev.c), but it was not linked with tevent library.
Compilation will fail if sssd is linked with "-Wl,--as-needed"
CCLD test_utils
/usr/bin/ld: ./.libs/libsss_test_common.a(common_tev.o): undefined refe
On (16/11/13 09:39), Simo Sorce wrote:
>On Sat, 2013-11-16 at 19:16 +0530, Pallavi Jha wrote:
>> Hello,
>>
>> Please find the attachment below. Kindly review.
>>
>I am not really a fan of these null checks, I prefer the code to crash
>in this case because these functions should never be called wi
On Mon, Nov 18, 2013 at 10:41:45AM +0100, Lukas Slebodnik wrote:
> Simple patch is attached.
It's not :-)
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/sssd-devel
On 11/12/2013 01:32 PM, Jakub Hrozek wrote:
Hi,
we have a default_domain_suffix parameter in the SSSD with the following
description:
default_domain_suffix (string)
This string will be used as a default domain name for all names without a
domain name component. The main use cas
On (18/11/13 10:41), Lukas Slebodnik wrote:
>ehlo,
>
>Static library libsss_test_common calls tevent functions directly (in module
>common_tev.c), but it was not linked with tevent library.
>
>Compilation will fail if sssd is linked with "-Wl,--as-needed"
> CCLD test_utils
>/usr/bin/ld: ./.lib
On Sat, Nov 16, 2013 at 09:39:36AM -0500, Simo Sorce wrote:
> On Sat, 2013-11-16 at 19:16 +0530, Pallavi Jha wrote:
> > Hello,
> >
> > Please find the attachment below. Kindly review.
> >
> I am not really a fan of these null checks, I prefer the code to crash
> in this case because these functio
On 11/18/2013 10:49 AM, Lukas Slebodnik wrote:
On (16/11/13 09:39), Simo Sorce wrote:
On Sat, 2013-11-16 at 19:16 +0530, Pallavi Jha wrote:
Hello,
Please find the attachment below. Kindly review.
I am not really a fan of these null checks, I prefer the code to crash
in this case because thes
Spotted by Kaushik.
>From bb9291daf82a2dcf323d95e8e53c0e7128909e8f Mon Sep 17 00:00:00 2001
From: Jakub Hrozek
Date: Mon, 18 Nov 2013 11:05:04 +0100
Subject: [PATCH] AD: Fix a typo in the man page
https://fedorahosted.org/sssd/ticket/2154
---
src/man/sssd-ad.5.xml | 2 +-
1 file changed, 1 inser
On Sat, Nov 16, 2013 at 09:38:18AM -0500, Simo Sorce wrote:
> On Sat, 2013-11-16 at 13:06 +0100, Lukas Slebodnik wrote:
> > ehlo,
> >
> > We have a very big Makefile.am
> > bash$ wc -l Makefile.am
> > 2152 Makefile.am
> >
> > And it will be much bigger, because there is initiative to improve code
On (18/11/13 11:05), Pavel Březina wrote:
>On 11/18/2013 10:49 AM, Lukas Slebodnik wrote:
>>On (16/11/13 09:39), Simo Sorce wrote:
>>>On Sat, 2013-11-16 at 19:16 +0530, Pallavi Jha wrote:
Hello,
Please find the attachment below. Kindly review.
>>>I am not really a fan of these nul
On Mon, Nov 18, 2013 at 12:31:23PM +0100, Lukas Slebodnik wrote:
> BTW program will not crash, because printf can be safely caled with
> null argument.
>
> bash$ ./program
> before
> >>(null)<<
> after
This is getting off-topic but I think that calling printf with a NULL
parameter is undefined an
On Mon, 2013-11-18 at 11:02 +0100, Jakub Hrozek wrote:
> On Sat, Nov 16, 2013 at 09:39:36AM -0500, Simo Sorce wrote:
> > On Sat, 2013-11-16 at 19:16 +0530, Pallavi Jha wrote:
> > > Hello,
> > >
> > > Please find the attachment below. Kindly review.
> > >
> > I am not really a fan of these null ch
ehlo,
I have my buildir in /dev/shm, therefore I don't run configure with flag
--with-test-dir=/dev/shm. I noticed that directory tests_utils was not removed
after successful test execution. This patch add removing this directory,
similar behaviour is in test_dyndns and test_nss_srv
LS
>From 6fd3
On (15/11/13 17:28), Michal Židek wrote:
>On 11/14/2013 01:14 PM, Lukas Slebodnik wrote:>>From
>>> >-((uint32_t *)body)[0] = num-skipped; /* num results */
>>> >-((uint32_t *)body)[1] = 0; /* reserved */
>>> >+SAFEALIGN_SETMEM_UINT32(body, num - skipped, NULL); /* num
>results */
>>> >+
A RHEL customer was hitting this issue. To reproduce, just enable the
matching rule and request an empty group.
>From 143f2b5a87208508d2c5acb4dd7866c3ea52857c Mon Sep 17 00:00:00 2001
From: Jakub Hrozek
Date: Mon, 18 Nov 2013 16:38:34 +0100
Subject: [PATCH] LDAP: Initialize user count for AD match
On Mon, Nov 18, 2013 at 10:59:20AM +0100, Lukas Slebodnik wrote:
> On (18/11/13 10:41), Lukas Slebodnik wrote:
> >ehlo,
> >
> >Static library libsss_test_common calls tevent functions directly (in module
> >common_tev.c), but it was not linked with tevent library.
> >
> >Compilation will fail if ss
On Mon, Nov 18, 2013 at 03:38:51PM +0100, Lukas Slebodnik wrote:
> ehlo,
>
> I have my buildir in /dev/shm, therefore I don't run configure with flag
> --with-test-dir=/dev/shm. I noticed that directory tests_utils was not removed
> after successful test execution. This patch add removing this dir
On Mon, Nov 18, 2013 at 08:35:14AM -0500, Simo Sorce wrote:
> On Mon, 2013-11-18 at 11:02 +0100, Jakub Hrozek wrote:
> > On Sat, Nov 16, 2013 at 09:39:36AM -0500, Simo Sorce wrote:
> > > On Sat, 2013-11-16 at 19:16 +0530, Pallavi Jha wrote:
> > > > Hello,
> > > >
> > > > Please find the attachment
On Mon, Nov 18, 2013 at 04:44:46PM +0100, Jakub Hrozek wrote:
> A RHEL customer was hitting this issue. To reproduce, just enable the
> matching rule and request an empty group.
ACK.
But I think the main problem is that we are a bit inconsistent handling
ENOENT and the return values. If haven't c
On Mon, Nov 18, 2013 at 04:59:09PM +0100, Sumit Bose wrote:
> On Mon, Nov 18, 2013 at 04:44:46PM +0100, Jakub Hrozek wrote:
> > A RHEL customer was hitting this issue. To reproduce, just enable the
> > matching rule and request an empty group.
>
> ACK.
>
> But I think the main problem is that we
On Mon, Nov 18, 2013 at 04:55:32PM +0100, Jakub Hrozek wrote:
> On Mon, Nov 18, 2013 at 03:38:51PM +0100, Lukas Slebodnik wrote:
> > ehlo,
> >
> > I have my buildir in /dev/shm, therefore I don't run configure with flag
> > --with-test-dir=/dev/shm. I noticed that directory tests_utils was not
>
On Mon, Nov 18, 2013 at 04:55:14PM +0100, Jakub Hrozek wrote:
> On Mon, Nov 18, 2013 at 10:59:20AM +0100, Lukas Slebodnik wrote:
> > On (18/11/13 10:41), Lukas Slebodnik wrote:
> > >ehlo,
> > >
> > >Static library libsss_test_common calls tevent functions directly (in
> > >module
> > >common_tev.c
On Mon, Nov 18, 2013 at 10:56:16AM +0100, Pavel Březina wrote:
> On 11/12/2013 01:32 PM, Jakub Hrozek wrote:
> >Hi,
> >
> >we have a default_domain_suffix parameter in the SSSD with the following
> >description:
> >
> > default_domain_suffix (string)
> > This string will be used as a defaul
23 matches
Mail list logo
