Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 12:09), Nikolai Kondrashov wrote: >On 03/24/2015 05:47 PM, Pavel Reichl wrote: >>On 03/24/2015 04:33 PM, Lukas Slebodnik wrote: >>>On (24/03/15 16:25), Pavel Reichl wrote: On 03/24/2015 04:08 PM, Lukas Slebodnik wrote: >On (23/03/15 17:53), Jakub Hrozek wrote: >>On Mon, Mar

Re: [SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 21:53), Lukas Slebodnik wrote: >On (25/03/15 14:35), Pavel Reichl wrote: >> >> >>On 03/25/2015 02:21 PM, Lukas Slebodnik wrote: >>>On (25/03/15 14:05), Pavel Reichl wrote: On 03/25/2015 01:51 PM, Lukas Slebodnik wrote: >On (25/03/15 12:01), Pavel Reichl wrote: >>Hello

Re: [SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 14:35), Pavel Reichl wrote: > > >On 03/25/2015 02:21 PM, Lukas Slebodnik wrote: >>On (25/03/15 14:05), Pavel Reichl wrote: >>> >>>On 03/25/2015 01:51 PM, Lukas Slebodnik wrote: On (25/03/15 12:01), Pavel Reichl wrote: >Hello please see attached patch. > >The need for th

Re: [SSSD] [PATCH] pam_client: fix casting to const pointer

2015-03-25 Thread Sumit Bose
On Wed, Mar 25, 2015 at 05:20:35PM +0100, Lukas Slebodnik wrote: > On (25/03/15 15:35), Sumit Bose wrote: > >On Wed, Mar 25, 2015 at 03:03:15PM +0100, Lukas Slebodnik wrote: > >> ehlo, > >> > >> clang complains about remoing cant qualifier in casting > >> > >> src/sss_client/pam_sss.c:1461:73: >

Re: [SSSD] [RFC on PATCH] drop krb5-config and use pkg-config

2015-03-25 Thread Sumit Bose
On Wed, Mar 25, 2015 at 11:48:42AM -0400, Simo Sorce wrote: > On Wed, 2015-03-25 at 16:33 +0100, Lukas Slebodnik wrote: > > On (25/03/15 11:15), Simo Sorce wrote: > > >Hello team! > > >So ... :) > > >... yesterday I had to work around a bug in the rawhide build of libkrb5 > > >that rendered krb5-co

Re: [SSSD] [PATCH] pam_client: fix casting to const pointer

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 15:35), Sumit Bose wrote: >On Wed, Mar 25, 2015 at 03:03:15PM +0100, Lukas Slebodnik wrote: >> ehlo, >> >> clang complains about remoing cant qualifier in casting >> >> src/sss_client/pam_sss.c:1461:73: >> error: cast from 'int **' to 'const void **' must have all >> intermed

Re: [SSSD] [RFC on PATCH] drop krb5-config and use pkg-config

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 11:48), Simo Sorce wrote: >On Wed, 2015-03-25 at 16:33 +0100, Lukas Slebodnik wrote: >> On (25/03/15 11:15), Simo Sorce wrote: >> >Hello team! >> >So ... :) >> >... yesterday I had to work around a bug in the rawhide build of libkrb5 >> >that rendered krb5-config buggy and broke gsspro

Re: [SSSD] [PATCH 1/2] test_expire: Use right assertion macro for standard functions

2015-03-25 Thread Pavel Reichl
On 03/25/2015 05:09 PM, Lukas Slebodnik wrote: On (25/03/15 16:29), Pavel Reichl wrote: On 03/25/2015 03:21 PM, Lukas Slebodnik wrote: ehlo, Documentation to macro assert_return_code says: Assert that the return_code is greater than or equal to 0. The function prints an error message to sta

Re: [SSSD] [PATCH 1/2] test_expire: Use right assertion macro for standard functions

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 16:29), Pavel Reichl wrote: >On 03/25/2015 03:21 PM, Lukas Slebodnik wrote: >>ehlo, >> >>Documentation to macro assert_return_code says: >>Assert that the return_code is greater than or equal to 0. >> >>The function prints an error message to standard error and terminates the >>test by

Re: [SSSD] [RFC on PATCH] drop krb5-config and use pkg-config

2015-03-25 Thread Simo Sorce
On Wed, 2015-03-25 at 16:33 +0100, Lukas Slebodnik wrote: > On (25/03/15 11:15), Simo Sorce wrote: > >Hello team! > >So ... :) > >... yesterday I had to work around a bug in the rawhide build of libkrb5 > >that rendered krb5-config buggy and broke gssproxy 0.4.0 build. > >At the end I decided to av

Re: [SSSD] [RFC on PATCH] drop krb5-config and use pkg-config

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 11:15), Simo Sorce wrote: >Hello team! >So ... :) >... yesterday I had to work around a bug in the rawhide build of libkrb5 >that rendered krb5-config buggy and broke gssproxy 0.4.0 build. >At the end I decided to avoid the problem completely by switching the >gssproxy packages to buil

Re: [SSSD] [PATCH 1/2] test_expire: Use right assertion macro for standard functions

2015-03-25 Thread Pavel Reichl
On 03/25/2015 03:21 PM, Lukas Slebodnik wrote: ehlo, Documentation to macro assert_return_code says: Assert that the return_code is greater than or equal to 0. The function prints an error message to standard error and terminates the test by calling fail() if the return code is smaller than 0.

[SSSD] [RFC on PATCH] drop krb5-config and use pkg-config

2015-03-25 Thread Simo Sorce
Hello team! So ... :) ... yesterday I had to work around a bug in the rawhide build of libkrb5 that rendered krb5-config buggy and broke gssproxy 0.4.0 build. At the end I decided to avoid the problem completely by switching the gssproxy packages to build using pkg-config instead of krb5-config. G

Re: [SSSD] [PATCH] test_ldap_auth: Use right assertion for integer comparison

2015-03-25 Thread Pavel Reichl
On 03/25/2015 03:20 PM, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel Thanks! ci passed: http://sssd-ci.duckdns.org

Re: [SSSD] [PATCH] pam_client: fix casting to const pointer

2015-03-25 Thread Sumit Bose
On Wed, Mar 25, 2015 at 03:03:15PM +0100, Lukas Slebodnik wrote: > ehlo, > > clang complains about remoing cant qualifier in casting > > src/sss_client/pam_sss.c:1461:73: > error: cast from 'int **' to 'const void **' must have all > intermediate pointers const qualified to be safe [-Werr

[SSSD] [PATCH 1/2] test_expire: Use right assertion macro for standard functions

2015-03-25 Thread Lukas Slebodnik
ehlo, Documentation to macro assert_return_code says: Assert that the return_code is greater than or equal to 0. The function prints an error message to standard error and terminates the test by calling fail() if the return code is smaller than 0. If the function you check sets an errno if it fai

[SSSD] [PATCH] test_ldap_auth: Use right assertion for integer comparison

2015-03-25 Thread Lukas Slebodnik
ehlo, simple patch is attached. LS >From b226c943557de7755cb542aa99f0e9efaa597f0d Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Wed, 25 Mar 2015 15:14:59 +0100 Subject: [PATCH 2/2] test_ldap_auth: Use right assertion for integer comparison The macro assert_int_equal prints value of inte

[SSSD] [PATCH] pam_client: fix casting to const pointer

2015-03-25 Thread Lukas Slebodnik
ehlo, clang complains about remoing cant qualifier in casting src/sss_client/pam_sss.c:1461:73: error: cast from 'int **' to 'const void **' must have all intermediate pointers const qualified to be safe [-Werror,-Wcast-qual] pam_get_data(pamh, "pam_sss:password_expired_flag", (const

[SSSD] [PATCH] test_resolv_fake: Fix alignment warning

2015-03-25 Thread Lukas Slebodnik
ehlo, there is a problem with allignment in tests. patch is attached. LS >From 82e7579d88ac720c3dfcdfbf3b52781a10fc6d40 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 14 Mar 2015 16:29:36 +0100 Subject: [PATCH 1/2] test_resolv_fake: Fix alignment warning src/tests/cmocka/test_resolv

Re: [SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Pavel Reichl
On 03/25/2015 02:21 PM, Lukas Slebodnik wrote: On (25/03/15 14:05), Pavel Reichl wrote: On 03/25/2015 01:51 PM, Lukas Slebodnik wrote: On (25/03/15 12:01), Pavel Reichl wrote: Hello please see attached patch. The need for this patch was discussed in thread: SDAP: Lock out ssh keys when acc

Re: [SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 14:05), Pavel Reichl wrote: > > >On 03/25/2015 01:51 PM, Lukas Slebodnik wrote: >>On (25/03/15 12:01), Pavel Reichl wrote: >>>Hello please see attached patch. >>> >>>The need for this patch was discussed in thread: SDAP: Lock out ssh keys when >>>account naturally expires >>>This patch

Re: [SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Pavel Reichl
On 03/25/2015 02:04 PM, Lukas Slebodnik wrote: On (25/03/15 14:00), Jakub Hrozek wrote: On Wed, Mar 25, 2015 at 01:51:05PM +0100, Lukas Slebodnik wrote: On (25/03/15 12:01), Pavel Reichl wrote: Hello please see attached patch. The need for this patch was discussed in thread: SDAP: Lock out ss

Re: [SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Pavel Reichl
On 03/25/2015 01:51 PM, Lukas Slebodnik wrote: On (25/03/15 12:01), Pavel Reichl wrote: Hello please see attached patch. The need for this patch was discussed in thread: SDAP: Lock out ssh keys when account naturally expires This patch implements point number 3. I would prefer if we didn't

Re: [SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 14:00), Jakub Hrozek wrote: >On Wed, Mar 25, 2015 at 01:51:05PM +0100, Lukas Slebodnik wrote: >> On (25/03/15 12:01), Pavel Reichl wrote: >> >Hello please see attached patch. >> > >> >The need for this patch was discussed in thread: SDAP: Lock out ssh keys >> >when >> >account natural

Re: [SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Jakub Hrozek
On Wed, Mar 25, 2015 at 01:51:05PM +0100, Lukas Slebodnik wrote: > On (25/03/15 12:01), Pavel Reichl wrote: > >Hello please see attached patch. > > > >The need for this patch was discussed in thread: SDAP: Lock out ssh keys when > >account naturally expires > >This patch implements point number 3.

Re: [SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Lukas Slebodnik
On (25/03/15 12:01), Pavel Reichl wrote: >Hello please see attached patch. > >The need for this patch was discussed in thread: SDAP: Lock out ssh keys when >account naturally expires >This patch implements point number 3. > >>>I would prefer if we didn't add a new option as well, but since we >>>re

Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-25 Thread Jakub Hrozek
On Wed, Mar 25, 2015 at 12:09:14PM +0200, Nikolai Kondrashov wrote: > On 03/24/2015 05:47 PM, Pavel Reichl wrote: > > > > > >On 03/24/2015 04:33 PM, Lukas Slebodnik wrote: > >>On (24/03/15 16:25), Pavel Reichl wrote: > >>>On 03/24/2015 04:08 PM, Lukas Slebodnik wrote: > On (23/03/15 17:53), Jak

[SSSD] [PATCH] LDAP: drop lockout option from ldap_access_order

2015-03-25 Thread Pavel Reichl
Hello please see attached patch. The need for this patch was discussed in thread: SDAP: Lock out ssh keys when account naturally expires This patch implements point number 3. I would prefer if we didn't add a new option as well, but since we released a version that only supported the lockout

Re: [SSSD] Wiki pages on SSSD Troubleshooting and reporting bugs

2015-03-25 Thread Pavel Březina
On 03/24/2015 10:09 PM, Jakub Hrozek wrote: On Tue, Mar 24, 2015 at 12:57:05PM +0100, Pavel Březina wrote: On 03/19/2015 12:53 PM, Jakub Hrozek wrote: Hi, I created two wiki pages to help our users troubleshoot their setups and file better bug reports. I hope the information captured there wou

Re: [SSSD] [PATCH] LDAP: fix a typo in debug message

2015-03-25 Thread Pavel Březina
On 03/24/2015 07:42 PM, Pavel Reichl wrote: Hello, 1st patch fixes a typo in a debug message found by Kaushik. While grepping the code for the typo I found it at a few more places - please see 2nd patch. I we decide to to ack 2nd patch, please feel free to squash it into the first one. Thanks

Re: [SSSD] [PATCH] BUILD: Add missing header file to tarball

2015-03-25 Thread Nikolai Kondrashov
On 03/24/2015 05:47 PM, Pavel Reichl wrote: On 03/24/2015 04:33 PM, Lukas Slebodnik wrote: On (24/03/15 16:25), Pavel Reichl wrote: On 03/24/2015 04:08 PM, Lukas Slebodnik wrote: On (23/03/15 17:53), Jakub Hrozek wrote: On Mon, Mar 23, 2015 at 05:03:03PM +0200, Nikolai Kondrashov wrote: On

[SSSD] [PATCH] LDAP: warn about lockout option being deprecated

2015-03-25 Thread Pavel Reichl
Hello, attached patch deprecates lockout option in 1-12 branch. This was discussed in thread: SDAP: Lock out ssh keys when account naturally expires This patch implements point number 2. I would prefer if we didn't add a new option as well, but since we released a version that only supported