Re: [SSSD] [PATCH] TESTS: Add test for get_next_domain

2015-06-01 Thread Lukas Slebodnik
On (01/06/15 20:56), Jakub Hrozek wrote: >There is a strange construct in our sss_domain_info handling code: >while (dom && dom->disabled) { >dom = get_next_domain(dom, true); >} > >I wasn't sure if this code was valid at all, so I wrote a test. Turns >out the code is semi-valid --

Re: [SSSD] [PATCH] TESTS: Use the right testcase

2015-06-01 Thread Lukas Slebodnik
On (01/06/15 22:14), Jakub Hrozek wrote: >Please ack.. >From 5de728077cea111b9673b70f5267895afeb4ec66 Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Mon, 1 Jun 2015 22:09:14 +0200 >Subject: [PATCH] TESTS: Use the right testcase > >tc_autofs, not tc_subdomains.. >--- http://sssd-ci.duckdns.or

Re: [SSSD] [PATCHES] krb5: new option krb5_map_user

2015-06-01 Thread Simo Sorce
On Thu, 2015-05-28 at 11:29 +0200, Jakub Hrozek wrote: > On Thu, May 28, 2015 at 11:09:50AM +0200, Pavel Reichl wrote: > > > > > > On 05/28/2015 11:04 AM, Jakub Hrozek wrote: > > >On Wed, May 27, 2015 at 09:40:13AM +0200, Jakub Hrozek wrote: > > >>On Tue, May 26, 2015 at 04:36:18PM +0200, Pavel R

[SSSD] [PATCH] TESTS: Use the right testcase

2015-06-01 Thread Jakub Hrozek
Please ack.. >From 5de728077cea111b9673b70f5267895afeb4ec66 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 1 Jun 2015 22:09:14 +0200 Subject: [PATCH] TESTS: Use the right testcase tc_autofs, not tc_subdomains.. --- src/tests/sysdb-tests.c | 16 1 file changed, 8 insertio

[SSSD] [PATCH] TESTS: Add test for get_next_domain

2015-06-01 Thread Jakub Hrozek
There is a strange construct in our sss_domain_info handling code: while (dom && dom->disabled) { dom = get_next_domain(dom, true); } I wasn't sure if this code was valid at all, so I wrote a test. Turns out the code is semi-valid -- if the domain you pass in is disabled, which is

Re: [SSSD] [PATCH] dyndns: remove dupl declaration of ipa_dyndns_update

2015-06-01 Thread Jakub Hrozek
On Mon, Jun 01, 2015 at 05:44:12PM +0200, Pavel Reichl wrote: > Hello, > > function ipa_dyndns_update() was declared twice in ipa_dyndns.h. Please see > trivial patch attached. > > Thanks! ACK CI: http://sssd-ci.duckdns.org/logs/job/16/59/summary.html There are some other issues with the heade

[SSSD] [PATCH] dyndns: remove dupl declaration of ipa_dyndns_update

2015-06-01 Thread Pavel Reichl
Hello, function ipa_dyndns_update() was declared twice in ipa_dyndns.h. Please see trivial patch attached. Thanks! >From 2fd17eb2b5a486264d80a8896491c6e742842781 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Mon, 1 Jun 2015 11:36:44 -0400 Subject: [PATCH] dyndns: remove dupl declaration o

Re: [SSSD] [PATCH] SDAP: Check return value before using output arguments

2015-06-01 Thread Jakub Hrozek
On Mon, Jun 01, 2015 at 01:02:14PM +0200, Pavel Reichl wrote: > > > On 06/01/2015 12:56 PM, Lukas Slebodnik wrote: > >On (01/06/15 10:40), Pavel Reichl wrote: > >>On 05/30/2015 04:52 PM, Lukas Slebodnik wrote: > >>>ehlo, > >>> > >>>simple patch is attached. > >>> > >>>LS > >>> > >>> > >>LGTM, ci

Re: [SSSD] [PATCH] util-tests: Add validation of internal error messages

2015-06-01 Thread Jakub Hrozek
On Mon, Jun 01, 2015 at 11:43:33AM +0200, Pavel Březina wrote: > On 05/29/2015 08:25 AM, Lukas Slebodnik wrote: > >ehlo, > > > >I noticed that some internal error messages has "." at the end. > >We should do the same as strerror; return just a string and not a sentence. > > > >simple test is attach

Re: [SSSD] [PATCH] Fix enumeration for IPA providers

2015-06-01 Thread Jakub Hrozek
On Mon, Jun 01, 2015 at 11:35:02AM +0200, Sumit Bose wrote: > On Sun, May 31, 2015 at 07:50:10PM +0200, Jakub Hrozek wrote: > > On Mon, May 25, 2015 at 11:04:27AM +0200, Jakub Hrozek wrote: > > > Hi, > > > > > > I found out that the IPA provider segfaults when it receives an > > > enumeration requ

Re: [SSSD] [PATCH] Add Vagrant configuration for SSSD

2015-06-01 Thread Lukas Slebodnik
On (01/06/15 08:01), Stephen Gallagher wrote: >On Wed, 2015-05-27 at 15:54 -0400, Stephen Gallagher wrote: >> On Wed, 2015-05-27 at 21:36 +0200, Lukas Slebodnik wrote: >> > On (27/05/15 15:30), Stephen Gallagher wrote: >> > > On Wed, 2015-05-27 at 13:31 -0400, Stephen Gallagher wrote: >> > > > To s

Re: [SSSD] [PATCH] Add Vagrant configuration for SSSD

2015-06-01 Thread Stephen Gallagher
On Wed, 2015-05-27 at 15:54 -0400, Stephen Gallagher wrote: > On Wed, 2015-05-27 at 21:36 +0200, Lukas Slebodnik wrote: > > On (27/05/15 15:30), Stephen Gallagher wrote: > > > On Wed, 2015-05-27 at 13:31 -0400, Stephen Gallagher wrote: > > > > To set up a Vagrant development environment: > > > > *

Re: [SSSD] [PATCH] ldap: use proper sysdb name in groups_by_user_done()

2015-06-01 Thread Lukas Slebodnik
On (01/06/15 12:58), Lukas Slebodnik wrote: >On (01/06/15 10:24), Sumit Bose wrote: >>On Sat, May 30, 2015 at 09:25:58PM +0200, Lukas Slebodnik wrote: >>> On (29/05/15 18:20), Sumit Bose wrote: >>> >Hi, >>> > >>> >I came across this issue while testing one of Jakub's patches. You can >>> >reproduce

Re: [SSSD] [PATCH] SDAP: Check return value before using output arguments

2015-06-01 Thread Lukas Slebodnik
On (01/06/15 13:02), Pavel Reichl wrote: >On 06/01/2015 12:56 PM, Lukas Slebodnik wrote: >>On (01/06/15 10:40), Pavel Reichl wrote: >>>On 05/30/2015 04:52 PM, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS >>>LGTM, ci passed: >>>sssd-ci.duckdns.org/logs/jo

Re: [SSSD] Design Document: D-Bus Cached Objects

2015-06-01 Thread Jakub Hrozek
On Mon, Jun 01, 2015 at 12:31:54PM +0200, Pavel Březina wrote: > On 05/15/2015 11:30 AM, Jakub Hrozek wrote: > >On Fri, May 15, 2015 at 11:24:29AM +0200, Pavel Březina wrote: > >>On 05/15/2015 11:19 AM, Jakub Hrozek wrote: > >>>On Fri, May 15, 2015 at 11:07:05AM +0200, Pavel Březina wrote: > On

Re: [SSSD] [PATCH] SDAP: Check return value before using output arguments

2015-06-01 Thread Pavel Reichl
On 06/01/2015 12:56 PM, Lukas Slebodnik wrote: On (01/06/15 10:40), Pavel Reichl wrote: On 05/30/2015 04:52 PM, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS LGTM, ci passed: sssd-ci.duckdns.org/logs/job/16/47/summary.html You might consider changing: if (debug_level

Re: [SSSD] [PATCH] ldap: use proper sysdb name in groups_by_user_done()

2015-06-01 Thread Lukas Slebodnik
On (01/06/15 10:24), Sumit Bose wrote: >On Sat, May 30, 2015 at 09:25:58PM +0200, Lukas Slebodnik wrote: >> On (29/05/15 18:20), Sumit Bose wrote: >> >Hi, >> > >> >I came across this issue while testing one of Jakub's patches. You can >> >reproduce this e.g. with the AD provider when joined to a AD

Re: [SSSD] [PATCH] SDAP: Check return value before using output arguments

2015-06-01 Thread Lukas Slebodnik
On (01/06/15 10:40), Pavel Reichl wrote: >On 05/30/2015 04:52 PM, Lukas Slebodnik wrote: >>ehlo, >> >>simple patch is attached. >> >>LS >> >> >LGTM, ci passed: >sssd-ci.duckdns.org/logs/job/16/47/summary.html > >You might consider changing: >if (debug_level & SSSDBG_TRACE_ALL) { >in the ver

Re: [SSSD] Design Document: D-Bus Cached Objects

2015-06-01 Thread Pavel Březina
On 05/15/2015 11:30 AM, Jakub Hrozek wrote: On Fri, May 15, 2015 at 11:24:29AM +0200, Pavel Březina wrote: On 05/15/2015 11:19 AM, Jakub Hrozek wrote: On Fri, May 15, 2015 at 11:07:05AM +0200, Pavel Březina wrote: On 05/15/2015 10:46 AM, Jakub Hrozek wrote: On Fri, May 15, 2015 at 10:37:06AM

Re: [SSSD] [PATCH] util-tests: Add validation of internal error messages

2015-06-01 Thread Pavel Březina
On 05/29/2015 08:25 AM, Lukas Slebodnik wrote: ehlo, I noticed that some internal error messages has "." at the end. We should do the same as strerror; return just a string and not a sentence. simple test is attached. LS Ack. ___ sssd-devel mailin

Re: [SSSD] [PATCH] Fix enumeration for IPA providers

2015-06-01 Thread Sumit Bose
On Sun, May 31, 2015 at 07:50:10PM +0200, Jakub Hrozek wrote: > On Mon, May 25, 2015 at 11:04:27AM +0200, Jakub Hrozek wrote: > > Hi, > > > > I found out that the IPA provider segfaults when it receives an > > enumeration request. The first patch gets rid of the segfault, but there > > would still

Re: [SSSD] Design Document: D-Bus Domains

2015-06-01 Thread Jakub Hrozek
On Mon, Jun 01, 2015 at 11:09:45AM +0200, Pavel Březina wrote: > On 05/28/2015 10:20 AM, Jakub Hrozek wrote: > >On Mon, May 25, 2015 at 11:52:24AM +0200, Pavel Březina wrote: > >>https://fedorahosted.org/sssd/wiki/DesignDocs/DBusDomains > >> > >>Old design: > >>https://fedorahosted.org/sssd/wiki/D

Re: [SSSD] Design Document: D-Bus Domains

2015-06-01 Thread Pavel Březina
On 05/28/2015 10:20 AM, Jakub Hrozek wrote: On Mon, May 25, 2015 at 11:52:24AM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/wiki/DesignDocs/DBusDomains Old design: https://fedorahosted.org/sssd/wiki/DesignDocs/DBusResponder#Representingdomainobjectsonthebus Hi, I would like to ch

Re: [SSSD] [PATCH] SDAP: Check return value before using output arguments

2015-06-01 Thread Pavel Reichl
On 05/30/2015 04:52 PM, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel LGTM, ci passed: sssd-ci.duckdns.org/logs/job

Re: [SSSD] [PATCH] ldap: use proper sysdb name in groups_by_user_done()

2015-06-01 Thread Sumit Bose
On Sat, May 30, 2015 at 09:25:58PM +0200, Lukas Slebodnik wrote: > On (29/05/15 18:20), Sumit Bose wrote: > >Hi, > > > >I came across this issue while testing one of Jakub's patches. You can > >reproduce this e.g. with the AD provider when joined to a AD forest with > >multiple domains. Now calling