[SSSD] [PATCH] Amend debug messages after failure of unlink

2016-07-25 Thread Lukas Slebodnik
ehlo, Some messages did not have errno or name of problematic file. There was also improper use of negative value. The function strerror was called with -1 instead of errno. LS >From 7a27caa69292dbf5564f2d55f17722e03089daed Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 25 Jul 2016 09

[SSSD] Re: [PATCH] Amend debug messages after failure of unlink

2016-07-25 Thread Petr Cech
On 07/25/2016 09:38 AM, Lukas Slebodnik wrote: ehlo, Some messages did not have errno or name of problematic file. There was also improper use of negative value. The function strerror was called with -1 instead of errno. LS Hi Lukas, LGTM, just wait for CI. Regards -- Petr^4 Čech _

[SSSD] Re: [PATCH] SYSDB: Do not try to modify ts cache for unsupported DNs

2016-07-25 Thread Petr Cech
On 07/25/2016 08:47 AM, Petr Cech wrote: On 07/25/2016 08:41 AM, Lukas Slebodnik wrote: ehlo, There are some false positive debug messages when you try to invalidate automount entries. sh# sss_cache -A --debug=0x00f0 [sss_cache] [sysdb_set_cache_entry_attr] (0x0080): ldb_modify failed: [No suc

[SSSD] Re: The sorry state of code documentation

2016-07-25 Thread Pavel Březina
On 07/20/2016 02:53 PM, Nikolai Kondrashov wrote: Hi everyone, I've been acquainting myself with SSSD code the last few weeks. Particularly, the NSS responder, and what it uses down the stack. The SSSD code is sure complex and its asynchronous nature doesn't help. However, what struck me, and f

[SSSD] Re: [PATCHES] IPA: fix [capaths] output

2016-07-25 Thread Jakub Hrozek
On Wed, Jul 20, 2016 at 12:48:16PM +0200, Sumit Bose wrote: > Hi, > > please find attached a fix for https://fedorahosted.org/sssd/ticket/3103 > which turned out to be an issue with the way SSSD generates the capaths > section in the krb5.conf snippet. > > bye, > Sumit > Before the patch: [doma

[SSSD] Re: [PATCHES] sssctl: print active server and server list

2016-07-25 Thread Pavel Březina
On 07/20/2016 03:03 PM, Jakub Hrozek wrote: On Wed, Jul 20, 2016 at 03:00:14PM +0200, Jakub Hrozek wrote: On Tue, Jul 19, 2016 at 12:20:16PM +0200, Pavel Březina wrote: On 07/18/2016 03:23 PM, Jakub Hrozek wrote: On Thu, Jul 14, 2016 at 11:39:40AM +0200, Pavel Březina wrote: From 6af0640128

[SSSD] Re: [PATCHES] AD: netlogon_get_domain_info() allow missing arguments

2016-07-25 Thread Jakub Hrozek
On Wed, Jul 20, 2016 at 03:14:17PM +0200, Sumit Bose wrote: > Hi, > > it is possible that the CLAP/netlogon reply does not contain any site > data. In this case we should not fail but just use what we can get. > Especially when looking up the Global Catalog the forest name is needed. > If the site

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-25 Thread Jakub Hrozek
On Thu, Jul 21, 2016 at 02:13:40PM +0200, Sumit Bose wrote: > Hi, > > this is my suggestion to solve https://fedorahosted.org/sssd/ticket/2948 > "Handle overriden name of members in the memberUid attribute". So far I read them to get a grasp of what they do, but didn't do a full review. See some

[SSSD] Re: [PATCH] Amend debug messages after failure of unlink

2016-07-25 Thread Petr Cech
On 07/25/2016 09:41 AM, Petr Cech wrote: On 07/25/2016 09:38 AM, Lukas Slebodnik wrote: ehlo, Some messages did not have errno or name of problematic file. There was also improper use of negative value. The function strerror was called with -1 instead of errno. LS Hi Lukas, LGTM, just wait

[SSSD] [PATCH] sssctl: Consistent commands naming

2016-07-25 Thread Michal Židek
Hi, this patches makes the sssctl commands more similar to ipa tool commands. I also think this pattern makes it easier to remember the commands. Note that in the future, there will be more user-* group-* and netgroup-* commands (like seed for user, list of all etc.) Comments are welcome. Mich

[SSSD] Re: [PATCHES] IPA: fix [capaths] output

2016-07-25 Thread Lukas Slebodnik
On (25/07/16 12:15), Jakub Hrozek wrote: >On Wed, Jul 20, 2016 at 12:48:16PM +0200, Sumit Bose wrote: >> Hi, >> >> please find attached a fix for https://fedorahosted.org/sssd/ticket/3103 >> which turned out to be an issue with the way SSSD generates the capaths >> section in the krb5.conf snippet

[SSSD] Re: [PATCH] SYSDB: Do not try to modify ts cache for unsupported DNs

2016-07-25 Thread Lukas Slebodnik
On (25/07/16 09:53), Petr Cech wrote: >On 07/25/2016 08:47 AM, Petr Cech wrote: >> On 07/25/2016 08:41 AM, Lukas Slebodnik wrote: >> > ehlo, >> > >> > There are some false positive debug messages when you try >> > to invalidate automount entries. >> > >> > sh# sss_cache -A --debug=0x00f0 >> > [ss

[SSSD] Re: [PATCH] Amend debug messages after failure of unlink

2016-07-25 Thread Lukas Slebodnik
On (25/07/16 14:05), Petr Cech wrote: >On 07/25/2016 09:41 AM, Petr Cech wrote: >> On 07/25/2016 09:38 AM, Lukas Slebodnik wrote: >> > ehlo, >> > >> > Some messages did not have errno or name of problematic file. >> > There was also improper use of negative value. >> > The function strerror was ca

[SSSD] Re: [PATCHES] AD: netlogon_get_domain_info() allow missing arguments

2016-07-25 Thread Lukas Slebodnik
On (25/07/16 13:10), Jakub Hrozek wrote: >On Wed, Jul 20, 2016 at 03:14:17PM +0200, Sumit Bose wrote: >> Hi, >> >> it is possible that the CLAP/netlogon reply does not contain any site >> data. In this case we should not fail but just use what we can get. >> Especially when looking up the Global C

[SSSD] [PATCH] sysdb_master_domain_add_info: properly set do_update

2016-07-25 Thread Sumit Bose
Hi, this patch fixes and issue which was reported by Coverity. The fix was originally proposed by Lukas but he preferred that I send the patch. bye, Sumit From d081be21235425b9137ddb22941245f5677ca54a Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Mon, 25 Jul 2016 17:37:51 +0200 Subject: [PATCH

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-07-25 Thread Petr Cech
On 07/21/2016 10:21 AM, Jakub Hrozek wrote: On Wed, Jul 20, 2016 at 12:24:11PM +0200, Jakub Hrozek wrote: > On Fri, Jul 15, 2016 at 03:24:15PM +0200, Petr Cech wrote: > > > > On 07/12/2016 10:31 AM, Pavel Březina wrote: > > > On 07/11/2016 05:12 PM, Petr Cech wrote: > > > > > > > > On 07/05/2

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-25 Thread Jakub Hrozek
On Mon, Jul 25, 2016 at 01:45:13PM +0200, Jakub Hrozek wrote: > On Thu, Jul 21, 2016 at 02:13:40PM +0200, Sumit Bose wrote: > > Hi, > > > > this is my suggestion to solve https://fedorahosted.org/sssd/ticket/2948 > > "Handle overriden name of members in the memberUid attribute". > > So far I read

[SSSD] Re: [PATCH] sysdb_master_domain_add_info: properly set do_update

2016-07-25 Thread Lukas Slebodnik
On (25/07/16 17:44), Sumit Bose wrote: >Hi, > >this patch fixes and issue which was reported by Coverity. The fix was >originally proposed by Lukas but he preferred that I send the patch. > >bye, >Sumit >From d081be21235425b9137ddb22941245f5677ca54a Mon Sep 17 00:00:00 2001 >From: Sumit Bose >Dat

[SSSD] Re: [PATCH] sysdb_master_domain_add_info: properly set do_update

2016-07-25 Thread Lukas Slebodnik
On (25/07/16 21:19), Lukas Slebodnik wrote: >On (25/07/16 17:44), Sumit Bose wrote: >>Hi, >> >>this patch fixes and issue which was reported by Coverity. The fix was >>originally proposed by Lukas but he preferred that I send the patch. >> >>bye, >>Sumit > >>From d081be21235425b9137ddb22941245f5677

[SSSD] Re: [PATCHES] views: properly override group member names

2016-07-25 Thread Lukas Slebodnik
On (25/07/16 19:26), Jakub Hrozek wrote: >On Mon, Jul 25, 2016 at 01:45:13PM +0200, Jakub Hrozek wrote: >> On Thu, Jul 21, 2016 at 02:13:40PM +0200, Sumit Bose wrote: >> > Hi, >> > >> > this is my suggestion to solve https://fedorahosted.org/sssd/ticket/2948 >> > "Handle overriden name of members