On (25/07/16 13:10), Jakub Hrozek wrote: >On Wed, Jul 20, 2016 at 03:14:17PM +0200, Sumit Bose wrote: >> Hi, >> >> it is possible that the CLAP/netlogon reply does not contain any site >> data. In this case we should not fail but just use what we can get. >> Especially when looking up the Global Catalog the forest name is needed. >> If the site name is missing we still can use the forest name to lookup >> the Global Catalog in DNS. >> >> The first patch is not strictly related to the issue but since it fixes >> a potential memory leak (we currently do not have it because only >> short-lived memory contexts are used so far) I think it is worth adding >> it here. >> >> bye, >> Sumit >> > >> From a0cf3c4b04069a71a0d610e1164390ec8bab45ab Mon Sep 17 00:00:00 2001 >> From: Sumit Bose <sb...@redhat.com> >> Date: Tue, 12 Jul 2016 13:16:43 +0200 >> Subject: [PATCH 1/4] AD: avoid memory leak in netlogon_get_domain_info() and >> make it public > >ACK > >> From 56f0b52cc91580f2ee9216f16d809c3da866728d Mon Sep 17 00:00:00 2001 >> From: Sumit Bose <sb...@redhat.com> >> Date: Tue, 12 Jul 2016 13:29:33 +0200 >> Subject: [PATCH 2/4] AD: netlogon_get_domain_info() allow missing arguments >> and empty results > >ACK > >> From 0e4564b85f632adedd1129d6b8b200db2a7a87ee Mon Sep 17 00:00:00 2001 >> From: Sumit Bose <sb...@redhat.com> >> Date: Mon, 11 Jul 2016 17:05:29 +0200 >> Subject: [PATCH 3/4] tests: add tests for netlogon_get_domain_info > >ACK > > >> From 4b6b33eb18a3d9c40c26503a9c7b8ae80d998e15 Mon Sep 17 00:00:00 2001 >> From: Sumit Bose <sb...@redhat.com> >> Date: Mon, 18 Jul 2016 11:25:47 +0200 >> Subject: [PATCH 4/4] AD: replace ad_get_client_site_parse_ndr() with >> netlogon_get_domain_info() > >ACK > >I tested site resolution and basic lookups manually and everything seems >to be working. > >Coverity didn't report anything either. I will push this patch set once >the CI run finishes.
http://sssd-ci.duckdns.org/logs/job/50/12/summary.html master: * 3000d86bea2bae735175f93b0e013bbcb3979f1e * 7fe7073ad2c84946a699528a3bb79f7803c96b69 * 44656ce260030556820c4b6be519e66ffdacb408 * 74bef2150c76c8814bf4c1654ecd3660604eb4e6 LS _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
