[SSSD] Re: [PATCH] SYSDB: Sanitize dn in sysdb_get_user_members_recursively

2016-08-03 Thread Lukas Slebodnik
On (02/08/16 18:40), Lukas Slebodnik wrote: >On (02/08/16 15:54), Lukas Slebodnik wrote: >>ehlo, >> >>attached two patches fix a crash in nss responder, >>which was caused by recent Sumit's patches. >> >>The 1st patch cannot be applied to master because >>I plan do do some changes in ldap integrati

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-03 Thread Lukas Slebodnik
On (03/08/16 18:56), Lukas Slebodnik wrote: >On (29/07/16 16:41), Jakub Hrozek wrote: >>On Thu, Jul 28, 2016 at 01:56:50PM +0200, Jakub Hrozek wrote: >>> On Thu, Jul 28, 2016 at 01:33:32PM +0200, Lukas Slebodnik wrote: >>> > On (28/07/16 12:06), thierry bordaz wrote: >>> > >On 07/28/2016 09:39 AM,

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-03 Thread Fabiano Fidêncio
On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech wrote: > Hello list, > > attached patch fixes duplication of pid file declaration. I hope that the > util/util.h is the right place for it. Another opinion are welcome. LGTM! I'd wait till someone else reviews the patch, in case you want to be sure that

[SSSD] Re: [PATCH] LDAP: Improving debug message

2016-08-03 Thread Fabiano Fidêncio
On Thu, Aug 4, 2016 at 8:08 AM, Petr Cech wrote: > On 08/03/2016 09:54 AM, Fabiano Fidêncio wrote: >> >> Hey! >> >> I'd do it a bit differently. > > > Hello Fabiano, > > I am glad for another point of view. > > >> diff --git a/src/providers/ldap/sdap_async_users.c >> b/src/providers/ldap/sdap_asyn

[SSSD] Re: [PATCH] LDAP: Improving debug message

2016-08-03 Thread Petr Cech
On 08/03/2016 09:54 AM, Fabiano Fidêncio wrote: Hey! I'd do it a bit differently. Hello Fabiano, I am glad for another point of view. diff --git a/src/providers/ldap/sdap_async_users.c b/src/providers/ldap/sdap_async_users.c index e44c045b3f8ff6aed33a42cf2919bc01aa41a243..3a8efa4caacbad74

[SSSD] Re: [PATCH] PROVIDER: Conversion empty string from D-Bus to NULL

2016-08-03 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH SET] AD_PROVIDER: ad_enabled_domains

2016-08-03 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-03 Thread Petr Cech
bump -- Petr^4 Čech ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [PATCH] LDAP: Use FQDN when linking parent LDAP groups

2016-08-03 Thread Lukas Slebodnik
On (03/08/16 18:11), Lukas Slebodnik wrote: >On (03/08/16 15:07), Lukas Slebodnik wrote: >>On (03/08/16 14:02), Jakub Hrozek wrote: >>>Hi, >>> >>>see the attached patch. You can use Lukas' integration tests to help >>>with review. >> >>>From 46a705afa5c04399e8ae41bfa98836cf40803f0f Mon Sep 17 00:00

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-03 Thread Lukas Slebodnik
On (29/07/16 16:41), Jakub Hrozek wrote: >On Thu, Jul 28, 2016 at 01:56:50PM +0200, Jakub Hrozek wrote: >> On Thu, Jul 28, 2016 at 01:33:32PM +0200, Lukas Slebodnik wrote: >> > On (28/07/16 12:06), thierry bordaz wrote: >> > >On 07/28/2016 09:39 AM, Jakub Hrozek wrote: >> > >> On Wed, Jul 27, 2016

[SSSD] Re: [PATCH] LDAP: Use FQDN when linking parent LDAP groups

2016-08-03 Thread Lukas Slebodnik
On (03/08/16 15:07), Lukas Slebodnik wrote: >On (03/08/16 14:02), Jakub Hrozek wrote: >>Hi, >> >>see the attached patch. You can use Lukas' integration tests to help >>with review. > >>From 46a705afa5c04399e8ae41bfa98836cf40803f0f Mon Sep 17 00:00:00 2001 >>From: Jakub Hrozek >>Date: Wed, 3 Aug 20

[SSSD] Re: [PATCH] Two code-hardening patches

2016-08-03 Thread Lukas Slebodnik
On (03/08/16 18:05), Jakub Hrozek wrote: >Hi, > >these two patches add error handling to the code. The first prevents >operating on ldb_message if retrieving the message fails. I only tested >an SSH login with a UPN to make sure we actually hit this codepath. I >don't like the deep indendation nest

[SSSD] [PATCH] Two code-hardening patches

2016-08-03 Thread Jakub Hrozek
Hi, these two patches add error handling to the code. The first prevents operating on ldb_message if retrieving the message fails. I only tested an SSH login with a UPN to make sure we actually hit this codepath. I don't like the deep indendation nesting, so I welcome suggestions how to fix the co

[SSSD] [PATCH] SYSDB: Fix setting dataExpireTimestamp if sysdb is supposed to set the current time

2016-08-03 Thread Jakub Hrozek
Hi, please see the attached patch and the test. They should fix https://fedorahosted.org/sssd/ticket/3064. I don't think more explanation than what is in the ticket and in the commit message is needed :) >From 1507a9c0c461b2fa3bf4fe59358a5150cb57c5a4 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Da

[SSSD] Re: [PATCH] RESPONDER: Lower debug level for SELINUX_getpeercon() failure, be explicit that it may happen due to disabled SELinux and pass the proper parameter to strerror()

2016-08-03 Thread Fabiano Fidêncio
On Wed, Aug 3, 2016 at 5:10 PM, Jakub Hrozek wrote: > On Tue, Aug 02, 2016 at 04:08:03PM +0200, Fabiano Fidêncio wrote: >> So, sorry for the very long title and please, see the proposed patches >> for solving https://fedorahosted.org/sssd/ticket/3094 >> >> >> Best Regards, >> -- >> Fabiano Fidênci

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-03 Thread Lukas Slebodnik
On (03/08/16 13:29), Jakub Hrozek wrote: >On Wed, Aug 03, 2016 at 12:52:31PM +0200, Petr Cech wrote: >> On 08/03/2016 12:46 PM, Lukas Slebodnik wrote: >> > On (03/08/16 12:34), Michal Židek wrote: >> > > Two nitpicks, see inline. >> > > >> > > On 07/22/2016 02:34 PM, Petr Cech wrote: >> > > > >>

[SSSD] Re: [PATCHES] AD: netlogon_get_domain_info() allow missing arguments

2016-08-03 Thread Lukas Slebodnik
On (03/08/16 16:25), Jakub Hrozek wrote: >On Wed, Aug 03, 2016 at 02:28:40PM +0200, Lukas Slebodnik wrote: >> On (28/07/16 09:22), Jakub Hrozek wrote: >> >On Wed, Jul 27, 2016 at 05:56:48PM +0200, Lukas Slebodnik wrote: >> >> On (27/07/16 15:57), Jakub Hrozek wrote: >> >> >On Mon, Jul 25, 2016 at 0

[SSSD] Re: [PATCH] RESPONDER: Lower debug level for SELINUX_getpeercon() failure, be explicit that it may happen due to disabled SELinux and pass the proper parameter to strerror()

2016-08-03 Thread Jakub Hrozek
On Tue, Aug 02, 2016 at 04:08:03PM +0200, Fabiano Fidêncio wrote: > So, sorry for the very long title and please, see the proposed patches > for solving https://fedorahosted.org/sssd/ticket/3094 > > > Best Regards, > -- > Fabiano Fidêncio > From 7b04832fce0bdf7f8e86c30f60811f7d219e62fc Mon Sep

[SSSD] Re: [PATCHES] AD: netlogon_get_domain_info() allow missing arguments

2016-08-03 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 02:28:40PM +0200, Lukas Slebodnik wrote: > On (28/07/16 09:22), Jakub Hrozek wrote: > >On Wed, Jul 27, 2016 at 05:56:48PM +0200, Lukas Slebodnik wrote: > >> On (27/07/16 15:57), Jakub Hrozek wrote: > >> >On Mon, Jul 25, 2016 at 04:11:16PM +0200, Lukas Slebodnik wrote: > >> >

[SSSD] Re: [PATCH] LDAP: Use FQDN when linking parent LDAP groups

2016-08-03 Thread Lukas Slebodnik
On (03/08/16 14:02), Jakub Hrozek wrote: >Hi, > >see the attached patch. You can use Lukas' integration tests to help >with review. >From 46a705afa5c04399e8ae41bfa98836cf40803f0f Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Wed, 3 Aug 2016 13:18:51 +0200 >Subject: [PATCH] LDAP: Use FQDN wh

[SSSD] Re: [PATCHES] AD: netlogon_get_domain_info() allow missing arguments

2016-08-03 Thread Lukas Slebodnik
On (28/07/16 09:22), Jakub Hrozek wrote: >On Wed, Jul 27, 2016 at 05:56:48PM +0200, Lukas Slebodnik wrote: >> On (27/07/16 15:57), Jakub Hrozek wrote: >> >On Mon, Jul 25, 2016 at 04:11:16PM +0200, Lukas Slebodnik wrote: >> >> On (25/07/16 13:10), Jakub Hrozek wrote: >> >> >On Wed, Jul 20, 2016 at 0

[SSSD] [PATCH] LDAP: Use FQDN when linking parent LDAP groups

2016-08-03 Thread Jakub Hrozek
Hi, see the attached patch. You can use Lukas' integration tests to help with review. >From 46a705afa5c04399e8ae41bfa98836cf40803f0f Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Wed, 3 Aug 2016 13:18:51 +0200 Subject: [PATCH] LDAP: Use FQDN when linking parent LDAP groups Resolves: http

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-03 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 12:52:31PM +0200, Petr Cech wrote: > On 08/03/2016 12:46 PM, Lukas Slebodnik wrote: > > On (03/08/16 12:34), Michal Židek wrote: > > > Two nitpicks, see inline. > > > > > > On 07/22/2016 02:34 PM, Petr Cech wrote: > > > > > > > > +static errno_t add_to_missing_attrs (TALLO

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-03 Thread Petr Cech
On 08/03/2016 12:46 PM, Lukas Slebodnik wrote: On (03/08/16 12:34), Michal Židek wrote: Two nitpicks, see inline. On 07/22/2016 02:34 PM, Petr Cech wrote: +static errno_t add_to_missing_attrs (TALLOC_CTX * mem_ctx, + struct sysdb_attrs *attrs, +

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-03 Thread Lukas Slebodnik
On (03/08/16 12:34), Michal Židek wrote: >Two nitpicks, see inline. > >On 07/22/2016 02:34 PM, Petr Cech wrote: >> >> +static errno_t add_to_missing_attrs (TALLOC_CTX * mem_ctx, >> + struct sysdb_attrs *attrs, >> + const char

[SSSD] Re: [PATCH] LDAP: Fixing of removing netgroup from cache

2016-08-03 Thread Michal Židek
Two nitpicks, see inline. On 07/22/2016 02:34 PM, Petr Cech wrote: +static errno_t add_to_missing_attrs (TALLOC_CTX * mem_ctx, + struct sysdb_attrs *attrs, + const char *ext_key, + char *

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-03 Thread Lukas Slebodnik
On (13/07/16 17:48), Lukas Slebodnik wrote: >ehlo, > >attched patch is an integration test for regression #3093. >I prepared a test and I let someone else to fix it :-) > >I will try to find more bugs in downstream tests. > >BTW we might move test from test_ts_cache somewhere else. >But it was the

[SSSD] Re: [PATCH] LDAP: Improving debug message

2016-08-03 Thread Fabiano Fidêncio
Hey! I'd do it a bit differently. diff --git a/src/providers/ldap/sdap_async_users.c b/src/providers/ldap/sdap_async_users.c index e44c045b3f8ff6aed33a42cf2919bc01aa41a243..3a8efa4caacbad74f493de334a387104d0e7cec4 100644 --- a/src/providers/ldap/sdap_async_users.c +++ b/src/providers/ldap/sdap_a

[SSSD] Re: [PATCH] Fixed some typos in man pages

2016-08-03 Thread Fabiano Fidêncio
On Tue, Aug 2, 2016 at 2:16 PM, Thorsten Scherf wrote: > > > ___ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org > Acked-by: Fabiano Fidêncio A simple patch l