[SSSD] [PATCH] Fix offline resolution of autofs maps and netgroups

2016-08-04 Thread Jakub Hrozek
Hi, to reproduce the netgroups failure: * getent netgroup testngr # to verify the netgroup is there * sss_cache -E * pkill -USR1 sssd # make sssd go offline * getent netgroup testngr to reproduce the autofs maps failure: * automount -m # to verify the maps are there

[SSSD] Re: [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-04 Thread Petr Cech
On 08/04/2016 04:35 PM, Petr Cech wrote: Hi list, there is the first version of patch for [1]. I need to investigate if we have the same issue in other *_childs. I tested it with sleep() added into ldap_child code. [1] https://fedorahosted.org/sssd/ticket/3106 I know, it is not perfect.

[SSSD] [PATCH 1/2] LDAP: Adding support for SIGTERM signal

2016-08-04 Thread Petr Cech
Hi list, there is the first version of patch for [1]. I need to investigate if we have the same issue in other *_childs. I tested it with sleep() added into ldap_child code. [1] https://fedorahosted.org/sssd/ticket/3106 Regards -- Petr^4 Čech >From 50d83072b48b198284871a5c950982dfbeeab974

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-08-04 Thread Michal Židek
Hi, As was requested on devel meeting, I removed the compatibility with old commands. New patch attached. Michal >From 0c18c75e2b6a2e29f95b0e477369b5db766afbdb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Mon, 25 Jul 2016 13:50:13 +0200 Subject:

[SSSD] [PATCH] Fix typo

2016-08-04 Thread Pavel Březina
Simple one liner attached. From 6c3d8d6dba969960590d88bdd9a4ec2e9b4a1bb2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Thu, 4 Aug 2016 14:10:09 +0200 Subject: [PATCH] Fix typo in debug message --- src/providers/ipa/ipa_init.c | 2 +- 1 file changed,

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 12:55:02PM +0200, Lukas Slebodnik wrote: > On (04/08/16 12:16), Jakub Hrozek wrote: > >On Wed, Aug 03, 2016 at 09:56:40AM +0200, Lukas Slebodnik wrote: > >> On (13/07/16 17:48), Lukas Slebodnik wrote: > >> >ehlo, > >> > > >> >attched patch is an integration test for

[SSSD] Re: [PATCH] Change debug level of config error msgs

2016-08-04 Thread Lukas Slebodnik
On (04/08/16 13:14), Michal Židek wrote: >On 08/04/2016 12:53 PM, Lukas Slebodnik wrote: >> On (04/08/16 12:13), Michal Židek wrote: >> > On 07/27/2016 03:13 PM, Petr Cech wrote: >> > > On 07/27/2016 03:05 PM, Petr Cech wrote: >> > > > On 07/27/2016 02:32 PM, Michal Židek wrote: >> > > > > Hi, >>

[SSSD] Re: [PATCH] RESPONDER: Lower debug level for SELINUX_getpeercon() failure, be explicit that it may happen due to disabled SELinux and pass the proper parameter to strerror()

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 11:12:53AM +0200, Jakub Hrozek wrote: > ACK > > Just waiting for CI to finish before pushing.. CI: http://sssd-ci.duckdns.org/logs/job/50/80/summary.html * master: * ba3c902014ac0b04ec761296fdb1c3ede747a5f2 * 4b9ee02b1f5252b2a116adf0c0c6c7a4722bb2cf *

[SSSD] Re: [PATCH] Change debug level of config error msgs

2016-08-04 Thread Michal Židek
On 08/04/2016 12:53 PM, Lukas Slebodnik wrote: On (04/08/16 12:13), Michal Židek wrote: On 07/27/2016 03:13 PM, Petr Cech wrote: On 07/27/2016 03:05 PM, Petr Cech wrote: On 07/27/2016 02:32 PM, Michal Židek wrote: Hi, I believe that this patch makes pinpointing of config errors a little

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-04 Thread Lukas Slebodnik
On (04/08/16 11:38), Jakub Hrozek wrote: >On Thu, Aug 04, 2016 at 11:26:41AM +0200, Jakub Hrozek wrote: >> On Thu, Aug 04, 2016 at 11:19:36AM +0200, Lukas Slebodnik wrote: >> > On (04/08/16 11:15), Jakub Hrozek wrote: >> > >On Thu, Aug 04, 2016 at 08:45:00AM +0200, Lukas Slebodnik wrote: >> > >>

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-04 Thread Lukas Slebodnik
On (04/08/16 12:16), Jakub Hrozek wrote: >On Wed, Aug 03, 2016 at 09:56:40AM +0200, Lukas Slebodnik wrote: >> On (13/07/16 17:48), Lukas Slebodnik wrote: >> >ehlo, >> > >> >attched patch is an integration test for regression #3093. >> >I prepared a test and I let someone else to fix it :-) >> > >>

[SSSD] Re: [PATCH] Change debug level of config error msgs

2016-08-04 Thread Lukas Slebodnik
On (04/08/16 12:13), Michal Židek wrote: >On 07/27/2016 03:13 PM, Petr Cech wrote: >> On 07/27/2016 03:05 PM, Petr Cech wrote: >> > On 07/27/2016 02:32 PM, Michal Židek wrote: >> > > Hi, >> > > >> > > I believe that this patch makes pinpointing >> > > of config errors a little easier. Especially

[SSSD] Re: [PATCH] intg: test nested membership

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 09:56:40AM +0200, Lukas Slebodnik wrote: > On (13/07/16 17:48), Lukas Slebodnik wrote: > >ehlo, > > > >attched patch is an integration test for regression #3093. > >I prepared a test and I let someone else to fix it :-) > > > >I will try to find more bugs in downstream

[SSSD] Re: [PATCH] Change debug level of config error msgs

2016-08-04 Thread Michal Židek
On 07/27/2016 03:13 PM, Petr Cech wrote: On 07/27/2016 03:05 PM, Petr Cech wrote: On 07/27/2016 02:32 PM, Michal Židek wrote: Hi, I believe that this patch makes pinpointing of config errors a little easier. Especially when using sssctl tool that currently refuses to start a command when

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-08-04 Thread Michal Židek
On 08/02/2016 06:04 PM, Michal Židek wrote: On 07/29/2016 09:38 PM, Lukas Slebodnik wrote: On (29/07/16 15:54), Michal Židek wrote: On 07/29/2016 03:23 PM, Jakub Hrozek wrote: On Fri, Jul 29, 2016 at 03:06:47PM +0200, Lukas Slebodnik wrote: On (29/07/16 14:27), Jakub Hrozek wrote: On Fri,

[SSSD] Re: [PATCH] sssctl: Consistent commands naming

2016-08-04 Thread Marc Muehlfeld
Hi Michal, Am 02.08.2016 um 18:04 schrieb Michal Židek: Marc could you give us your opinion/blessing to this change? Long story short, we though the commands will be easier to understand if they follow similar pattern as the TOPIC-ACTION that ipa tool uses. This will help us create more

[SSSD] Re: [PATCH] config: Some fixes to schema

2016-08-04 Thread Michal Židek
On 08/04/2016 11:40 AM, Jakub Hrozek wrote: On Thu, Aug 04, 2016 at 11:35:30AM +0200, Michal Židek wrote: On 07/12/2016 06:38 PM, Lukas Slebodnik wrote: On (12/07/16 15:59), Michal Židek wrote: On 07/12/2016 03:36 PM, Lukas Slebodnik wrote: On (12/07/16 15:16), Michal Židek wrote: +#

[SSSD] Re: [PATCH] config: Some fixes to schema

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 11:35:30AM +0200, Michal Židek wrote: > On 07/12/2016 06:38 PM, Lukas Slebodnik wrote: > > On (12/07/16 15:59), Michal Židek wrote: > > > On 07/12/2016 03:36 PM, Lukas Slebodnik wrote: > > > > On (12/07/16 15:16), Michal Židek wrote: > > > > > +# secrets responder > > > > >

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 11:26:41AM +0200, Jakub Hrozek wrote: > On Thu, Aug 04, 2016 at 11:19:36AM +0200, Lukas Slebodnik wrote: > > On (04/08/16 11:15), Jakub Hrozek wrote: > > >On Thu, Aug 04, 2016 at 08:45:00AM +0200, Lukas Slebodnik wrote: > > >> On (03/08/16 18:56), Lukas Slebodnik wrote: > >

[SSSD] Re: [PATCH] config: Some fixes to schema

2016-08-04 Thread Michal Židek
On 07/12/2016 06:38 PM, Lukas Slebodnik wrote: On (12/07/16 15:59), Michal Židek wrote: On 07/12/2016 03:36 PM, Lukas Slebodnik wrote: On (12/07/16 15:16), Michal Židek wrote: +# secrets responder +option = provider + I think you need to also update "rule/allowed_sections" maybe you could

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 11:19:36AM +0200, Lukas Slebodnik wrote: > On (04/08/16 11:15), Jakub Hrozek wrote: > >On Thu, Aug 04, 2016 at 08:45:00AM +0200, Lukas Slebodnik wrote: > >> On (03/08/16 18:56), Lukas Slebodnik wrote: > >> >On (29/07/16 16:41), Jakub Hrozek wrote: > >> >>On Thu, Jul 28,

[SSSD] Re: [PATCH] Fixed some typos in man pages

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 09:46:46AM +0200, Fabiano Fidêncio wrote: > On Tue, Aug 2, 2016 at 2:16 PM, Thorsten Scherf wrote: > > > > > > ___ > > sssd-devel mailing list > > sssd-devel@lists.fedorahosted.org > >

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-04 Thread Lukas Slebodnik
On (04/08/16 11:15), Jakub Hrozek wrote: >On Thu, Aug 04, 2016 at 08:45:00AM +0200, Lukas Slebodnik wrote: >> On (03/08/16 18:56), Lukas Slebodnik wrote: >> >On (29/07/16 16:41), Jakub Hrozek wrote: >> >>On Thu, Jul 28, 2016 at 01:56:50PM +0200, Jakub Hrozek wrote: >> >>> On Thu, Jul 28, 2016 at

[SSSD] Re: [PATCH] LDAP: Use FQDN when linking parent LDAP groups

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 08:08:35PM +0200, Lukas Slebodnik wrote: > >So ACK to oneliner :-) > > > http://sssd-ci.duckdns.org/logs/job/50/79/summary.html > > LS * master: 6a89b38c032593ed705e679c23e6a4efce9f3def ___ sssd-devel mailing list

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 08:45:00AM +0200, Lukas Slebodnik wrote: > On (03/08/16 18:56), Lukas Slebodnik wrote: > >On (29/07/16 16:41), Jakub Hrozek wrote: > >>On Thu, Jul 28, 2016 at 01:56:50PM +0200, Jakub Hrozek wrote: > >>> On Thu, Jul 28, 2016 at 01:33:32PM +0200, Lukas Slebodnik wrote: > >>>

[SSSD] Re: [PATCH] RESPONDER: Lower debug level for SELINUX_getpeercon() failure, be explicit that it may happen due to disabled SELinux and pass the proper parameter to strerror()

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 05:21:53PM +0200, Fabiano Fidêncio wrote: > On Wed, Aug 3, 2016 at 5:10 PM, Jakub Hrozek wrote: > > On Tue, Aug 02, 2016 at 04:08:03PM +0200, Fabiano Fidêncio wrote: > >> So, sorry for the very long title and please, see the proposed patches > >> for

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-04 Thread Jakub Hrozek
On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote: > On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech wrote: > > Hello list, > > > > attached patch fixes duplication of pid file declaration. I hope that the > > util/util.h is the right place for it. Another opinion are

[SSSD] Re: [PATCH] Two code-hardening patches

2016-08-04 Thread Jakub Hrozek
On Wed, Aug 03, 2016 at 06:08:44PM +0200, Lukas Slebodnik wrote: > On (03/08/16 18:05), Jakub Hrozek wrote: > >Hi, > > > >these two patches add error handling to the code. The first prevents > >operating on ldb_message if retrieving the message fails. I only tested > >an SSH login with a UPN to

[SSSD] tasks for newcomers or non-developers

2016-08-04 Thread Jakub Hrozek
Hi, Over the last couple of weeks, I've talked to several people, mostly engineers with not too much development experience, who said they would like to start contributing little fixes to SSSD. I would like to find some tasks that they can easily handle without making their had spin from looking

[SSSD] Re: [PATCH] SYSDB: Sanitize dn in sysdb_get_user_members_recursively

2016-08-04 Thread Lukas Slebodnik
On (02/08/16 18:40), Lukas Slebodnik wrote: >On (02/08/16 15:54), Lukas Slebodnik wrote: >>ehlo, >> >>attached two patches fix a crash in nss responder, >>which was caused by recent Sumit's patches. >> >>The 1st patch cannot be applied to master because >>I plan do do some changes in ldap

[SSSD] Re: [PATCH] SYSDB: Check changed virtual attributes before modified timestamp

2016-08-04 Thread Lukas Slebodnik
On (03/08/16 18:56), Lukas Slebodnik wrote: >On (29/07/16 16:41), Jakub Hrozek wrote: >>On Thu, Jul 28, 2016 at 01:56:50PM +0200, Jakub Hrozek wrote: >>> On Thu, Jul 28, 2016 at 01:33:32PM +0200, Lukas Slebodnik wrote: >>> > On (28/07/16 12:06), thierry bordaz wrote: >>> > >On 07/28/2016 09:39 AM,

[SSSD] Re: [PATCH] UTILS: Fixing duplication of pid file declaration

2016-08-04 Thread Fabiano Fidêncio
On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech wrote: > Hello list, > > attached patch fixes duplication of pid file declaration. I hope that the > util/util.h is the right place for it. Another opinion are welcome. LGTM! I'd wait till someone else reviews the patch, in case you

[SSSD] Re: [PATCH] LDAP: Improving debug message

2016-08-04 Thread Fabiano Fidêncio
On Thu, Aug 4, 2016 at 8:08 AM, Petr Cech wrote: > On 08/03/2016 09:54 AM, Fabiano Fidêncio wrote: >> >> Hey! >> >> I'd do it a bit differently. > > > Hello Fabiano, > > I am glad for another point of view. > > >> diff --git a/src/providers/ldap/sdap_async_users.c >>

[SSSD] Re: [PATCH] LDAP: Improving debug message

2016-08-04 Thread Petr Cech
On 08/03/2016 09:54 AM, Fabiano Fidêncio wrote: Hey! I'd do it a bit differently. Hello Fabiano, I am glad for another point of view. diff --git a/src/providers/ldap/sdap_async_users.c b/src/providers/ldap/sdap_async_users.c index