On Thu, Aug 04, 2016 at 08:41:34AM +0200, Fabiano Fidêncio wrote: > On Tue, Jul 26, 2016 at 4:01 PM, Petr Cech <pc...@redhat.com> wrote: > > Hello list, > > > > attached patch fixes duplication of pid file declaration. I hope that the > > util/util.h is the right place for it. Another opinion are welcome. > > LGTM! > > I'd wait till someone else reviews the patch, in case you want to be > sure that util/util.h is the right place for the defines.
It is, but I don't think that MONITOR_NAME belongs there. I think the pidfile declaration can just use hardcoded sssd (or just #define PIDFILE_BASENAME to "sssd") and MONITOR_NAME should stay in monitor.c _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
