[SSSD] [sssd PR#108][comment] Partially revert "CONFIG: Use default config when none provided"

2016-12-12 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/108 Title: #108: Partially revert "CONFIG: Use default config when none provided" lslebodn commented: """ http://sssd-ci.duckdns.org/logs/job/58/76/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/108#issuecomment-266567268

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders fidencio commented: """ On Mon, Dec 12, 2016 at 7:13 PM, Fabiano Fidêncio wrote: > > > On Mon, Dec 12, 2016 at 2:26 PM, Fabiano Fidêncio > wrote: >

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders fidencio commented: """ On Mon, Dec 12, 2016 at 2:26 PM, Fabiano Fidêncio wrote: > > > On Mon, Dec 12, 2016 at 1:34 PM, Pavel Březina > wrote: >

[SSSD] [sssd PR#108][opened] Partially revert "CONFIG: Use default config when none provided"

2016-12-12 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/108 Author: lslebodn Title: #108: Partially revert "CONFIG: Use default config when none provided" Action: opened PR body: """ This reverts part of commit 59744cff6edb106ae799b2321cb8731edadf409a. Removed is copying of default configuration into

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ On Mon, Dec 12, 2016 at 07:30:30AM -0800, Simo Sorce wrote: > well you could have a globalk variable for the watchdog and change it from a > custom

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread simo5
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler simo5 commented: """ well you could have a globalk variable for the watchdog and change it from a custom signal handler, but the point of the watchdog is to go thorugh the

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ On Mon, Dec 12, 2016 at 06:55:13AM -0800, Simo Sorce wrote: > Yes we should ask, I think we really need to try to use monotonic clocks for > most tasks.

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread simo5
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler simo5 commented: """ Yes we should ask, I think we really need to try to use monotonic clocks for most tasks. """ See the full comment at

[SSSD] [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds

2016-12-12 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/100 Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds justin-stephenson commented: """ Okay from my perspective. """ See the full comment at https://github.com/SSSD/sssd/pull/100#issuecomment-266449797

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-12-12 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ I saw a crash as part of ad_testing. But it seems to be unrelated to AD tests. ``` #0 __strlen_sse2_pminub () at ../sysdeps/x86_64/multiarch/strlen-sse2-pminub.S:38 #1

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ I'm not sure I like the idea of killing a service because the admin runs ntpdate, even if the monitor should restart the service. @simo5 do you have a

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler fidencio commented: """ On Mon, Dec 12, 2016 at 3:37 PM, Jakub Hrozek wrote: > So..I wonder how much of a hack this is but if the intent here is to

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ So..I wonder how much of a hack this is but if the intent here is to reset the watchdog from a signal handler, could we send a signal to self

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders jhrozek commented: """ On Mon, Dec 12, 2016 at 05:19:18AM -0800, fidencio wrote: > >Would it make any sense to own the sockets by the sssd user as well? > >Currently it seems the sockets

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-12-12 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req lslebodn commented: """ I saw a crash as part of ad_testing. But it seems to be unrelated to AD tests. ``` #0 __strlen_sse2_pminub () at ../sysdeps/x86_64/multiarch/strlen-sse2-pminub.S:38 #1

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider jhrozek commented: """ On Mon, Dec 12, 2016 at 04:51:31AM -0800, Pavel Březina wrote: > I will try to do some review in this week. Thank you, but please note that I will try to implement Simo's suggestion to use

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler fidencio commented: """ On Mon, Dec 12, 2016 at 1:50 PM, Pavel Březina wrote: > *@pbrezina* commented on this pull request. >

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler fidencio commented: """ On Mon, Dec 12, 2016 at 1:22 PM, lslebodn wrote: > On (12/12/16 01:20), fidencio wrote: > >While debugging rhbz#1396912 some

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders fidencio commented: """ On Mon, Dec 12, 2016 at 1:34 PM, Pavel Březina wrote: > *Unit files* > I wonder if the user and group in unit files should take

[SSSD] [sssd PR#102][comment] Sssctl no case sensitive searches

2016-12-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches mzidek-rh commented: """ I see I forgot to remove the changes requested label. Doing so now. """ See the full comment at https://github.com/SSSD/sssd/pull/102#issuecomment-266430057

[SSSD] [sssd PR#102][-Changes requested] Sssctl no case sensitive searches

2016-12-12 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/102 Title: #102: Sssctl no case sensitive searches Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders fidencio commented: """ On Mon, Dec 12, 2016 at 12:40 PM, Jakub Hrozek wrote: > Hi, > I read the patches, so far I didn't do a whole lot of testing, so maybe > some

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2016-12-12 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider pbrezina commented: """ I will try to do some review in this week. """ See the full comment at https://github.com/SSSD/sssd/pull/106#issuecomment-266423740 ___

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders lslebodn commented: """ On (12/12/16 03:40), Jakub Hrozek wrote: >1. There were some SELinux denials on my test VM, but granted, I run F-24 >there. We need to make sure that no SELinux AVC

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders pbrezina commented: """ **Unit files** I wonder if the user and group in unit files should take --with-sssd-user value from configure. **MAN: Mention that the services' list is optional** It

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler lslebodn commented: """ On (12/12/16 01:20), fidencio wrote: >While debugging rhbz#1396912 some deadlock on sssd_be was noticed[0] and >it's been caused by the use of non

[SSSD] [sssd PR#100][comment] Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds

2016-12-12 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/100 Title: #100: Updation of sssd-ad man page for case when dyndns_refresh_interval < 60 seconds pbrezina commented: """ Hi, ack to the content. I have only one nitpick from the technical point of view, can you please squash those patches together? See:

[SSSD] [sssd PR#94][+Changes requested] Enable {socket, dbus}-activation for responders

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-12 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders jhrozek commented: """ Hi, I read the patches, so far I didn't do a whole lot of testing, so maybe some questions here are invalid, but nonetheless, here is my take on the patchset: 1.

[SSSD] [sssd PR#89][comment] nss: rewrite nss responder so it uses cache_req

2016-12-12 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/89 Title: #89: nss: rewrite nss responder so it uses cache_req pbrezina commented: """ Hi, I added: https://github.com/SSSD/sssd/pull/89/commits/a7dd2b118170e6dacaf41dba4874ad5754c25500 This should fix the AD failures, please test it again. """ See the

[SSSD] [sssd PR#107][opened] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-12 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Author: fidencio Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Action: opened PR body: """ While debugging rhbz#1396912 some deadlock on sssd_be was noticed[0] and it's been caused by the use of non async-signal-safe