[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ I have two comments: 1. The new debug message has "louder" debug level than the one that sets the port as non-working. I would suggest to also change the 'not working' debug

[SSSD] [sssd PR#112][+Changes requested] FAILOVER: Improve port status log messages

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorah

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ I wonder if @mzidek-rh has any more comments """ See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268471546 __

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders jhrozek commented: """ Coverity seems to have detected a warning: Error: CHECKED_RETURN (CWE-252): sssd-1.14.90/src/responder/autofs/autofssrv_cmd.c:323: check_return: Calling "sss_cmd_empt

[SSSD] [sssd PR#109][+Accepted] SSSCTL: fix netgroup-show parsing

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ Thank you, the patch works well. Just please note that after 7b293a5095ef3e63cd2e3f2ff01b7484bf6dcd38 was commited, this patch would only apply for sssd-1-14. That said, I'm not su

[SSSD] [sssd PR#109][comment] SSSCTL: fix netgroup-show parsing

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/109 Title: #109: SSSCTL: fix netgroup-show parsing jhrozek commented: """ btw I also added a test in PR #113 so that we don't regress again """ See the full comment at https://github.com/SSSD/sssd/pull/109#issuecomment-268489241 __

[SSSD] [sssd PR#113][opened] Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267.

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/113 Author: jhrozek Title: #113: Adds an integration test for sssctl netgroup-show so that we don't regress again like we did in ticket #3267. Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SS

[SSSD] [sssd PR#94][+Changes requested] Enable {socket, dbus}-activation for responders

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedor

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders fidencio commented: """ On Wed, Dec 21, 2016 at 10:59 AM, Jakub Hrozek wrote: > Coverity seems to have detected a warning: > > Error: CHECKED_RETURN (CWE-252): > sssd-1.14.90/src/responder/auto

[SSSD] [sssd PR#110][-Changes requested] Add more DEBUG messages to help admins diagnose Kerberos login failures

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/110 Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#110][synchronized] Add more DEBUG messages to help admins diagnose Kerberos login failures

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/110 Author: jhrozek Title: #110: Add more DEBUG messages to help admins diagnose Kerberos login failures Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/110/head:pr110 git checko

[SSSD] [sssd PR#94][comment] Enable {socket,dbus}-activation for responders

2016-12-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders fidencio commented: """ On Wed, Dec 21, 2016 at 11:32 AM, Fabiano Fidêncio wrote: > > > On Wed, Dec 21, 2016 at 10:59 AM, Jakub Hrozek > wrote: > >> Coverity seems to have detected a warning:

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler jhrozek commented: """ Hmm, I'm sorry, I think this is my fault for suggesting we move more stuff out of the POSIX signal handler, but I don't think we can remove the watchdog

[SSSD] [sssd PR#107][+Changes requested] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-

[SSSD] [sssd PR#107][synchronized] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Author: fidencio Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/107/head:pr107 git checkout pr107 F

[SSSD] [sssd PR#107][-Changes requested] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler fidencio commented: """ Okay, patch has been updated. """ See the full comment at https://github.com/SSSD/sssd/pull/107#issuecomment-268503583 _

[SSSD] releasing 1.15 (alpha?)

2016-12-21 Thread Jakub Hrozek
Hi, the NSS responder refactoring was merged, the socket activation patches are going to be merged soon, so here's a question: - is it OK to release a tarball when the socket activation patches are merged? Or do we want to merge something else? - should we call the release 1.15 Alpha

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages mzidek-rh commented: """ Hi Justin! I agree with jhrozek that the debug level is not correct and that the message is confusing, because there is relationship between the status of internal port

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages mzidek-rh commented: """ Hi Justin! I agree with jhrozek that the debug level is not correct and that the message is confusing, because there is relationship between the status of internal port

[SSSD] [sssd PR#107][comment] WATCHDOG: Avoid non async-signal-safe from the signal_handler

2016-12-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/107 Title: #107: WATCHDOG: Avoid non async-signal-safe from the signal_handler fidencio commented: """ Not sure why CentOS CI failed. Internal CI has passed in the most of the supported distros and the failures doesn't seem related to this patch: http://s

[SSSD] [sssd PR#112][synchronized] FAILOVER: Improve port status log messages

2016-12-21 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/112 Author: justin-stephenson Title: #112: FAILOVER: Improve port status log messages Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/112/head:pr112 git checkout pr112 From b5ae3e

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages justin-stephenson commented: """ Hello Jakub/Michal, thanks a lot for your comments and review. I updated the PR to provide a better explanation which uses elements of both suggestions mentioned.