[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ I'm sorry this review stalled. I think the current patch is fine. About the duplicate messages -- the messages from get_server_status and get_port_status are quite low

[SSSD] [sssd PR#112][+Accepted] FAILOVER: Improve port status log messages

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#138][comment] IPA: Skip conflict entries associated with sudo rules

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules jhrozek commented: """ Hi Justin, thank you very much for th epatches and sorry the review took so long. In general I like the approach, an extra parameter is probably the right way

[SSSD] [sssd PR#138][comment] IPA: Skip conflict entries associated with sudo rules

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules jhrozek commented: """ Hi Justin, thank you very much for th epatches and sorry the review took so long. In general I like the approach, an extra parameter is probably the right way

[SSSD] [sssd PR#138][+Changes requested] IPA: Skip conflict entries associated with sudo rules

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ On Thu, Feb 02, 2017 at 08:29:15AM -0800, lslebodn wrote: > On (02/02/17 08:14), Jakub Hrozek wrote: > >On Tue, Jan 31, 2017 at 12:18:44AM -0800, fidencio wrote: > >> Looking

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework lslebodn commented: """ On (02/02/17 08:14), Jakub Hrozek wrote: >On Tue, Jan 31, 2017 at 12:18:44AM -0800, fidencio wrote: >> Looking at the patches I see this can be a completely new library

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ On Tue, Jan 31, 2017 at 12:18:44AM -0800, fidencio wrote: > Looking at the patches I see this can be a completely new library instead of > being part of SSSD. > Knowing this

[SSSD] [sssd PR#112][-Changes requested] FAILOVER: Improve port status log messages

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ The code looks good to me now but I found one regression - if you set default_domain_suffix to the AD domain and try to look up a host, the ssh responder will query the AD domain. Since hosts can

[SSSD] Re: sssd-1.14.3 milestone cleanup

2017-02-02 Thread Jakub Hrozek
On Thu, Feb 02, 2017 at 01:43:55PM +0100, Lukas Slebodnik wrote: > On (02/02/17 11:36), Jakub Hrozek wrote: > >On Wed, Jan 11, 2017 at 06:52:32PM +0100, Lukas Slebodnik wrote: > >> On (11/01/17 16:31), Jakub Hrozek wrote: > >> >* https://fedorahosted.org/sssd/ticket/3074 - Move timestamp cache

[SSSD] Re: sssd-1.14.3 milestone cleanup

2017-02-02 Thread Lukas Slebodnik
On (02/02/17 11:36), Jakub Hrozek wrote: >On Wed, Jan 11, 2017 at 06:52:32PM +0100, Lukas Slebodnik wrote: >> On (11/01/17 16:31), Jakub Hrozek wrote: >> >* https://fedorahosted.org/sssd/ticket/3074 - Move timestamp cache to >> > tmpfs >> >* https://fedorahosted.org/sssd/ticket/3097 -

[SSSD] Re: sssd-1.14.3 milestone cleanup

2017-02-02 Thread Jakub Hrozek
On Thu, Feb 02, 2017 at 12:30:16PM +0100, Michal Židek wrote: > > > >* https://fedorahosted.org/sssd/ticket/3208 - Need detailed > > > > information > > > >about config-check option > > > > - what is this ticket about? Do we need it? I suggest we just close > > > > it > > > > > > >

[SSSD] Re: sssd-1.14.3 milestone cleanup

2017-02-02 Thread Michal Židek
On 02/02/2017 11:36 AM, Jakub Hrozek wrote: On Wed, Jan 11, 2017 at 06:52:32PM +0100, Lukas Slebodnik wrote: On (11/01/17 16:31), Jakub Hrozek wrote: Hi, despite new development happening in the sssd-1-15 branch (aka master), there are still too many tickets in the 1.14.3 milestone. The

[SSSD] Re: sssd-1.14.3 milestone cleanup

2017-02-02 Thread Jakub Hrozek
On Thu, Jan 12, 2017 at 05:02:26PM +0100, Lukas Slebodnik wrote: > On (12/01/17 15:29), Petr Cech wrote: > >On 01/12/2017 02:02 PM, Pavel Březina wrote: > >> > > > >> > > * https://fedorahosted.org/sssd/ticket/3113 - Please move > >> > > sudo_timed option to sssd-sudo man page > >> > > -

[SSSD] Re: sssd-1.14.3 milestone cleanup

2017-02-02 Thread Jakub Hrozek
On Wed, Jan 11, 2017 at 06:52:32PM +0100, Lukas Slebodnik wrote: > On (11/01/17 16:31), Jakub Hrozek wrote: > >Hi, > > > >despite new development happening in the sssd-1-15 branch (aka master), > >there are still too many tickets in the 1.14.3 milestone. The tickets > >should be moved out to

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework lslebodn commented: """ There are some trailing white spaces ``` sh$ ABS_TOP_SRCDIR=$PWD src/tests/whitespace_test Trailing whitespace found: src/tests/python/README.rst:4:`sssd.testlib`_ is a

[SSSD] [sssd PR#139][+Changes requested] Initial revision of sssd pytest framework

2017-02-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to