[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set lslebodn commented: """ On (14/02/17 08:17), Jakub Hrozek wrote: >> Last but not least, @lslebodn suggested (in face to face conversation in >> the office) that maybe we could add an

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ On Tue, Feb 14, 2017 at 05:41:34AM -0800, fidencio wrote: > On Tue, Feb 14, 2017 at 2:07 PM, lslebodn wrote: > > > On (14/02/17 01:57), fidencio wrote: > > >

[SSSD] [sssd PR#106][+Changes requested] Add a new "files" provider

2017-02-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface pbrezina commented: """ Thank you. So far I'm reading `secrets` code trying to figure out my needs to comment on `curl` implementation. Here are some comments on the `iobuf` modu

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ So, dnf repositories work again. I am able to test the functionality of my patch set. Unfortunately it doesnt work. I will fix it. """ See the full comment at

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-14 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ On Tue, Feb 14, 2017 at 2:07 PM, lslebodn wrote: > On (14/02/17 01:57), fidencio wrote: > >@lslebodn: > >Firstly, my answer may be incomplete due to the lac

[SSSD] [sssd PR#153][+Changes requested] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@list

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set lslebodn commented: """ On (14/02/17 01:57), fidencio wrote: >@lslebodn: >Firstly, my answer may be incomplete due to the lack of knowledge, but let's >try ... >1) As far as I under

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ FYI http://sssd-ci.duckdns.org/logs/job/62/59/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/153#issuecomment-279693430 _

[SSSD] [sssd PR#153][-Changes requested] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@list

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache fidencio commented: """ This approach seems less intrusive than the previous one and the integration tests passed locally (already asked @celestian to run our CI as well). I'll do a prop

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ I pushed new version (#2). I addressed Lukáš's comment. Now it works only for sss_cache case. In detail, I added functions ``` sysdb_invalidate_user_cache_entry(

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache celestian commented: """ I pushed new version (#2). I addressed Lukáš's comment. Now it works only for sss_cache case. In detail, I added functions ``` sysdb_invalidate_user_cache_entry(

[SSSD] [sssd PR#153][edited] sss_cache: User/groups invalidation in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: sss_cache: User/groups invalidation in domain cache Action: edited Changed field: title Original value: """ SYSDB: Changing dataExpireTimestamp in domain cache """ ___ sssd-d

[SSSD] [sssd PR#153][synchronized] SYSDB: Changing dataExpireTimestamp in domain cache

2017-02-14 Thread celestian
URL: https://github.com/SSSD/sssd/pull/153 Author: celestian Title: #153: SYSDB: Changing dataExpireTimestamp in domain cache Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/153/head:pr153 git checkout pr153 From e7fbe

[SSSD] [sssd PR#106][comment] Add a new "files" provider

2017-02-14 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/106 Title: #106: Add a new "files" provider pbrezina commented: """ > I hope this wouldn't be an issue because the inotify code doesn't call the > callbacks immediately but with a tevent timer (by default immediate tevent > action) which IIRC waits until

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-14 Thread spbnick
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups spbnick commented: """ I'll try to review this. """ See the full comment at https://github.com/SSSD/sssd/pull/141#issuecomment-279670819 ___ sssd

[SSSD] [sssd PR#128][-Accepted] Fix group renaming issue when "id_provider = ldap" is set

2017-02-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.f

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-14 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set lslebodn commented: """ On (14/02/17 01:25), Jakub Hrozek wrote: >The tests didn't find any regressions, ACK > I have a tiny question: What would happen if there ate two groups in d

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-14 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ @lslebodn: Firstly, my answer may be incomplete due to the lack of knowledge, but let's try ... 1) As far as I understand SSSD does not deal properly with mu

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ I tried to submit a new job for the centos CI because our CI "passed": http://sssd-ci.duckdns.org/logs/job/62/42/summary.html (there is an unrelated failu

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/152#issuecomment-279656176 __

[SSSD] [sssd PR#128][+Accepted] Fix group renaming issue when "id_provider = ldap" is set

2017-02-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.f

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-14 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set jhrozek commented: """ The tests didn't find any regressions, ACK """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-279653099 _