[SSSD] [sssd PR#189][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-04-03 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/189 Title: #189: SELINUX: Use getseuserbyname to get IPA seuser justin-stephenson commented: """ @lslebodn I tested the patch in #165 and it successfully resolves the original sssd errors `[libsemanage] (0x0020): could not query record value` however I

[SSSD] [sssd PR#165][comment] selinux: Do not fail if SELinux is not managed

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/165 Title: #165: selinux: Do not fail if SELinux is not managed lslebodn commented: """ if you do not want to use following pattern ``` if (ret != somerrror) { //mostly ENOENT //ignore this err ret = EOK } else (ret != EOK) //log error and fail

[SSSD] [sssd PR#189][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-04-03 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/189 Title: #189: SELINUX: Use getseuserbyname to get IPA seuser justin-stephenson commented: """ @lslebodn in my testing, the SELinux child process gets called twice during IPA client login. Before the patch the first call would error with similar

[SSSD] [sssd PR#222][+Pushed] ipa_s2n_get_acct_info_send: provide correct req_input name

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/222 Title: #222: ipa_s2n_get_acct_info_send: provide correct req_input name Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#222][closed] ipa_s2n_get_acct_info_send: provide correct req_input name

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/222 Author: pbrezina Title: #222: ipa_s2n_get_acct_info_send: provide correct req_input name Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/222/head:pr222 git checkout pr222

[SSSD] [sssd PR#222][comment] ipa_s2n_get_acct_info_send: provide correct req_input name

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/222 Title: #222: ipa_s2n_get_acct_info_send: provide correct req_input name lslebodn commented: """ master: * b07bcd8b99590bd404733fa7ff1add37c55126bc """ See the full comment at https://github.com/SSSD/sssd/pull/222#issuecomment-291156036

[SSSD] [sssd PR#202][comment] T3315 infopipe group users master

2017-04-03 Thread celestian
URL: https://github.com/SSSD/sssd/pull/202 Title: #202: T3315 infopipe group users master celestian commented: """ IMO, this patch set fix method org.freedesktop.sssd.infopipe.Groups.Group.UpdateMemberList() which you need call if you would like to see members of group. """ See the full

[SSSD] [sssd PR#224][+Pushed] responders: do not leak selinux context on clients destruction

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/224 Title: #224: responders: do not leak selinux context on clients destruction Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#224][comment] responders: do not leak selinux context on clients destruction

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/224 Title: #224: responders: do not leak selinux context on clients destruction lslebodn commented: """ master: * 05c2c3047912fca1c1a35ab1c8d3157b05383495 sssd-1-14: * cbb20c50d6ee247fb5c943e4368608fbb8e04741 """ See the full comment at

[SSSD] [sssd PR#224][closed] responders: do not leak selinux context on clients destruction

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/224 Author: pbrezina Title: #224: responders: do not leak selinux context on clients destruction Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/224/head:pr224 git checkout pr224

[SSSD] [sssd PR#224][comment] responders: do not leak selinux context on clients destruction

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/224 Title: #224: responders: do not leak selinux context on clients destruction lslebodn commented: """ tested with infinite loop "getent passwd" and it fixed the bug :-) ACK """ See the full comment at

[SSSD] [sssd PR#219][+Pushed] BUILD: Fix compilation of libsss_certmap with libcrypto

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/219 Title: #219: BUILD: Fix compilation of libsss_certmap with libcrypto Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#219][comment] BUILD: Fix compilation of libsss_certmap with libcrypto

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/219 Title: #219: BUILD: Fix compilation of libsss_certmap with libcrypto lslebodn commented: """ master: * 84fecc2fd535030bc56b5046ba2a1ba95c46bc34 """ See the full comment at https://github.com/SSSD/sssd/pull/219#issuecomment-291144657

[SSSD] [sssd PR#219][closed] BUILD: Fix compilation of libsss_certmap with libcrypto

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/219 Author: lslebodn Title: #219: BUILD: Fix compilation of libsss_certmap with libcrypto Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/219/head:pr219 git checkout pr219

[SSSD] [sssd PR#189][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/189 Title: #189: SELINUX: Use getseuserbyname to get IPA seuser lslebodn commented: """ @justin-stephenson are you able to reproduce bug with `semanage login -d testuser` Because I used a little bit complicated test-case and I still can reproduce bug

[SSSD] Re: Design discussion: Support for non-POSIX users and groups

2017-04-03 Thread Jakub Hrozek
On Tue, Mar 28, 2017 at 04:18:24PM +0200, Jakub Hrozek wrote: > On Tue, Mar 14, 2017 at 06:25:39AM -0400, Simo Sorce wrote: > > On Mon, 2017-03-06 at 14:49 +0100, Jakub Hrozek wrote: > > >     [sssd] > > > >     domains = appdomain.test, posixdomain.test > > > >    

[SSSD] [sssd PR#219][comment] BUILD: Fix compilation of libsss_certmap with libcrypto

2017-04-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/219 Title: #219: BUILD: Fix compilation of libsss_certmap with libcrypto sumit-bose commented: """ The patch looks good and fixes the issue for me. I did a manual CI run http://sssd-ci.duckdns.org/logs/job/67/33/summary.html with errors but imo all

[SSSD] [sssd PR#222][comment] ipa_s2n_get_acct_info_send: provide correct req_input name

2017-04-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/222 Title: #222: ipa_s2n_get_acct_info_send: provide correct req_input name sumit-bose commented: """ Looks like all concerns are resolved, ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/222#issuecomment-291127047

[SSSD] [sssd PR#222][comment] ipa_s2n_get_acct_info_send: provide correct req_input name

2017-04-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/222 Title: #222: ipa_s2n_get_acct_info_send: provide correct req_input name sumit-bose commented: """ > I though about it but choose not to since it is a trivial function. But I > updated the patch with `DEBUG_IS_SET Thank you, I agree that it is a

[SSSD] [sssd PR#224][comment] responders: do not leak selinux context on clients destruction

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/224 Title: #224: responders: do not leak selinux context on clients destruction lslebodn commented: """ LGTM """ See the full comment at https://github.com/SSSD/sssd/pull/224#issuecomment-291113466 ___

[SSSD] [sssd PR#222][comment] ipa_s2n_get_acct_info_send: provide correct req_input name

2017-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/222 Title: #222: ipa_s2n_get_acct_info_send: provide correct req_input name pbrezina commented: """ On 04/03/2017 12:43 PM, sumit-bose wrote: > *@sumit-bose* commented on this pull request. > >

[SSSD] [sssd PR#222][comment] ipa_s2n_get_acct_info_send: provide correct req_input name

2017-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/222 Title: #222: ipa_s2n_get_acct_info_send: provide correct req_input name pbrezina commented: """ On 04/03/2017 12:41 PM, lslebodn wrote: > *@lslebodn* commented on this pull request. > >

[SSSD] [sssd PR#222][synchronized] ipa_s2n_get_acct_info_send: provide correct req_input name

2017-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/222 Author: pbrezina Title: #222: ipa_s2n_get_acct_info_send: provide correct req_input name Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/222/head:pr222 git checkout pr222

[SSSD] [sssd PR#224][opened] responders: do not leak selinux context on clients destruction

2017-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/224 Author: pbrezina Title: #224: responders: do not leak selinux context on clients destruction Action: opened PR body: """ The SELinux context created in get_client_cred is not talloc bound and we were leaking it if available with each client's

[SSSD] [sssd PR#208][comment] IFP: Filter with * in Users.ListByName method

2017-04-03 Thread celestian
URL: https://github.com/SSSD/sssd/pull/208 Title: #208: IFP: Filter with * in Users.ListByName method celestian commented: """ CI passed: http://sssd-ci.duckdns.org/logs/job/67/31/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/208#issuecomment-291110759

[SSSD] [sssd PR#223][opened] KRB5_LOCATOR: add env variable to disable plugin

2017-04-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/223 Author: sumit-bose Title: #223: KRB5_LOCATOR: add env variable to disable plugin Action: opened PR body: """ If the new environment variable SSSD_KRB5_LOCATOR_DISABLE is set to any value SSSD's krb5 locator plugin is disabled. The variable is needed

[SSSD] [sssd PR#222][opened] ipa_s2n_get_acct_info_send: provide correct req_input name

2017-04-03 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/222 Author: pbrezina Title: #222: ipa_s2n_get_acct_info_send: provide correct req_input name Action: opened PR body: """ To avoid crash. Resolves: https://pagure.io/SSSD/sssd/issue/3358 """ To pull the PR as Git branch: git remote add ghsssd

[SSSD] Re: Fragile test enumeration

2017-04-03 Thread Pavel Březina
On 03/31/2017 11:58 AM, Lukas Slebodnik wrote: ehlo, we pushed recently many patches and I noticed increased amount of failures in enumeration test. http://sssd-ci.duckdns.org/logs/job/66/82/summary.html http://sssd-ci.duckdns.org/logs/job/66/83/summary.html

[SSSD] [sssd PR#221][closed] sss_cert_pem_to_der: Accept certificate with data before header

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/221 Author: dkupka Title: #221: sss_cert_pem_to_der: Accept certificate with data before header Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/221/head:pr221 git checkout pr221

[SSSD] [sssd PR#221][+Pushed] sss_cert_pem_to_der: Accept certificate with data before header

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/221 Title: #221: sss_cert_pem_to_der: Accept certificate with data before header Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#221][comment] sss_cert_pem_to_der: Accept certificate with data before header

2017-04-03 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/221 Title: #221: sss_cert_pem_to_der: Accept certificate with data before header lslebodn commented: """ master: * 5231ba679402eeb0705a3ecd41f97fdd67d42a69 """ See the full comment at https://github.com/SSSD/sssd/pull/221#issuecomment-291084002

[SSSD] Re: Remove https://github.com/SSSD/gh-mailinglist-notifications, add https://github.com/SSSD/docs

2017-04-03 Thread Pavel Březina
On 03/31/2017 03:23 PM, Jakub Hrozek wrote: On Fri, Mar 31, 2017 at 11:50:15AM +0200, Lukas Slebodnik wrote: On (31/03/17 11:00), Pavel Březina wrote: On 03/31/2017 10:35 AM, Lukas Slebodnik wrote: On (30/03/17 21:18), Jakub Hrozek wrote: Hi, I'd like to remove

[SSSD] [sssd PR#221][+Accepted] sss_cert_pem_to_der: Accept certificate with data before header

2017-04-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/221 Title: #221: sss_cert_pem_to_der: Accept certificate with data before header Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#221][comment] sss_cert_pem_to_der: Accept certificate with data before header

2017-04-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/221 Title: #221: sss_cert_pem_to_der: Accept certificate with data before header sumit-bose commented: """ I would have coded it more or less the same way, thank you for added a unit test. ACK """ See the full comment at

[SSSD] [sssd PR#208][comment] IFP: Filter with * in Users.ListByName method

2017-04-03 Thread celestian
URL: https://github.com/SSSD/sssd/pull/208 Title: #208: IFP: Filter with * in Users.ListByName method celestian commented: """ Yes. It is rebased now. This PR has to go before #211 IFP: Fix of limit = 0 (unlimited result). """ See the full comment at

[SSSD] [sssd PR#208][synchronized] IFP: Filter with * in Users.ListByName method

2017-04-03 Thread celestian
URL: https://github.com/SSSD/sssd/pull/208 Author: celestian Title: #208: IFP: Filter with * in Users.ListByName method Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/208/head:pr208 git checkout pr208 From