[SSSD] [sssd PR#321][comment] certmap: add OpenSSL implementation

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/321 Title: #321: certmap: add OpenSSL implementation lslebodn commented: """ @jhrozek LGTM. I would appreciate more unit test for corner cases but that can be done later. """ See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-3271

[SSSD] [sssd PR#321][comment] certmap: add OpenSSL implementation

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/321 Title: #321: certmap: add OpenSSL implementation lslebodn commented: """ @jhrozek LGTM. I would appreciate more unit test for corner cases but that can be done later. """ See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-3271

[SSSD] [sssd PR#301][comment] Introduce sysdb_search_by_orig_dn()

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/301 Title: #301: Introduce sysdb_search_by_orig_dn() lslebodn commented: """ @jhrozek LGTM. I would appreciate more unit test for corner cases but that can be done later. """ See the full comment at https://github.com/SSSD/sssd/pull/301#issuecomment-3271

[SSSD] Re: about access control reporting with id_provider=ad

2017-09-05 Thread Jakub Hrozek
On Wed, Aug 23, 2017 at 04:13:07PM +0200, Michal Židek wrote: > On 08/23/2017 03:26 PM, Jakub Hrozek wrote: > > On Tue, Aug 22, 2017 at 03:21:14PM +0200, Michal Židek wrote: > > > On 08/22/2017 12:31 PM, Jakub Hrozek wrote: > > > > On Tue, Aug 22, 2017 at 11:40:39AM +0200, Michal Židek wrote: > > >

[SSSD] [sssd PR#321][+Accepted] certmap: add OpenSSL implementation

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/321 Title: #321: certmap: add OpenSSL implementation Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#321][comment] certmap: add OpenSSL implementation

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/321 Title: #321: certmap: add OpenSSL implementation jhrozek commented: """ Adding the accepted label as per @lslebodn 's comment. """ See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-327113591 ___

[SSSD] [sssd PR#366][comment] SUDO: Use initgr_with_views when looking up a sudo user

2017-09-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/366 Title: #366: SUDO: Use initgr_with_views when looking up a sudo user pbrezina commented: """ Nack. ``` Searching sysdb with [(&(objectClass=sudoRule)(sudoUser=+*)(!(|(sudoUser=ALL)(sudoUser=tus...@ldap.pb)(sudoUser=#1)(sudoUser=%sup-grou...@ldap.p

[SSSD] [sssd PR#366][comment] SUDO: Use initgr_with_views when looking up a sudo user

2017-09-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/366 Title: #366: SUDO: Use initgr_with_views when looking up a sudo user pbrezina commented: """ Nack. ```bash [root: /dev/shm/sssd]# sss_override user-add user-1 -n tuser1 -u 1 [root: /dev/shm/sssd]# sss_override group-add group-1 -n tgroup1 [root: /d

[SSSD] [sssd PR#366][+Changes requested] SUDO: Use initgr_with_views when looking up a sudo user

2017-09-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/366 Title: #366: SUDO: Use initgr_with_views when looking up a sudo user Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@

[SSSD] [sssd PR#321][comment] certmap: add OpenSSL implementation

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/321 Title: #321: certmap: add OpenSSL implementation jhrozek commented: """ Actually it looks like @lslebodn 's comment was meant for a different PR, removing the Accepted label again, sorry for the spam. """ See the full comment at https://github.com/SS

[SSSD] [sssd PR#321][-Accepted] certmap: add OpenSSL implementation

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/321 Title: #321: certmap: add OpenSSL implementation Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#301][+Pushed] Introduce sysdb_search_by_orig_dn()

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/301 Title: #301: Introduce sysdb_search_by_orig_dn() Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#301][closed] Introduce sysdb_search_by_orig_dn()

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/301 Author: fidencio Title: #301: Introduce sysdb_search_by_orig_dn() Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/301/head:pr301 git checkout pr301 _

[SSSD] [sssd PR#301][comment] Introduce sysdb_search_by_orig_dn()

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/301 Title: #301: Introduce sysdb_search_by_orig_dn() jhrozek commented: """ * master: 59db26782d052ddbec633279d08e8627ca57fd41 e3d9ce0ac22796cb08ad2daed006021b44b28c69 4c508463be960682cf94b4e5a39be2f8f49067c8 a5e9d34fd39c0061ca284674a6fd7cad05c6056c 9a44e78

[SSSD] [sssd PR#325][comment] MAN: Improve description of 'trusted domain section' in sssd.conf's man page

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/325 Title: #325: MAN: Improve description of 'trusted domain section' in sssd.conf's man page jhrozek commented: """ * master: 781d231a12eb0c772353cc15e2c3ae1e7545e663 """ See the full comment at https://github.com/SSSD/sssd/pull/325#issuecomment-3271201

[SSSD] [sssd PR#325][+Pushed] MAN: Improve description of 'trusted domain section' in sssd.conf's man page

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/325 Title: #325: MAN: Improve description of 'trusted domain section' in sssd.conf's man page Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-d

[SSSD] [sssd PR#325][closed] MAN: Improve description of 'trusted domain section' in sssd.conf's man page

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/325 Author: amitkumar50 Title: #325: MAN: Improve description of 'trusted domain section' in sssd.conf's man page Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/325/head:pr325 git che

[SSSD] [sssd PR#368][opened] ipa: make sure view name is initialized at startup

2017-09-05 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/368 Author: sumit-bose Title: #368: ipa: make sure view name is initialized at startup Action: opened PR body: """ sysdb_master_domain_update() can only set the view name properly if it was not set before but it might be called multiple times before the v

[SSSD] [sssd PR#351][synchronized] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Author: lslebodn Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/351/head:pr351 git checkout pr351 From 65

[SSSD] [sssd PR#351][-Changes requested] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid lslebodn commented: """ sorry for long response. I'll provide intg test soon in PR. It needn't block this bug fix. """ See the full comment at https://github.com/SSSD/sssd/pull/351#

[SSSD] [sssd PR#326][synchronized] IPA: check if IPA hostname is a FQDN

2017-09-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/326 Author: amitkumar50 Title: #326: IPA: check if IPA hostname is a FQDN Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/326/head:pr326 git checkout pr326 From ddfe639c74406c1389

[SSSD] [sssd PR#326][comment] IPA: check if IPA hostname is a FQDN

2017-09-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/326 Title: #326: IPA: check if IPA hostname is a FQDN amitkumar50 commented: """ @jhrozek Agree with you. Done. Thanks """ See the full comment at https://github.com/SSSD/sssd/pull/326#issuecomment-327137863 ___

[SSSD] [sssd PR#334][comment] Print a warning when enumeration is requested but disabled

2017-09-05 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/334 Title: #334: Print a warning when enumeration is requested but disabled amitkumar50 commented: """ @jhrozek Working on this.. """ See the full comment at https://github.com/SSSD/sssd/pull/334#issuecomment-327140877

[SSSD] [sssd PR#369][opened] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/369 Author: lslebodn Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef Action: opened PR body: """ python2.6 already contains function/macro PyModule_AddObject and PyBytes_FromString. Related to: https://pagure.io/SSSD/sssd/issue/3491 """

[SSSD] [sssd PR#269][comment] Add support for ActiveDirectory's logonHours restrictions

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/269 Title: #269: Add support for ActiveDirectory's logonHours restrictions jhrozek commented: """ First, I'm sorry this PR stalled for several months. I finally had some time to re-check it and the primary thing I would suggest here is to not add the cod

[SSSD] [sssd PR#269][comment] Add support for ActiveDirectory's logonHours restrictions

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/269 Title: #269: Add support for ActiveDirectory's logonHours restrictions jhrozek commented: """ @sumit-bose what do you think? """ See the full comment at https://github.com/SSSD/sssd/pull/269#issuecomment-327159813 _

[SSSD] [sssd PR#326][comment] IPA: check if IPA hostname is a FQDN

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/326 Title: #326: IPA: check if IPA hostname is a FQDN jhrozek commented: """ @amitkumar50 sorry for noticing the check is misplaced earlier. Please move it and I'll ack.. """ See the full comment at https://github.com/SSSD/sssd/pull/326#issuecomment-3271

[SSSD] [sssd PR#321][comment] certmap: add OpenSSL implementation

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/321 Title: #321: certmap: add OpenSSL implementation lslebodn commented: """ master: * a20fb9cbd5f42a6ca895aea1b84347fdfea34b89 """ See the full comment at https://github.com/SSSD/sssd/pull/321#issuecomment-327168880 __

[SSSD] [sssd PR#321][closed] certmap: add OpenSSL implementation

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/321 Author: sumit-bose Title: #321: certmap: add OpenSSL implementation Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/321/head:pr321 git checkout pr321 ___

[SSSD] [sssd PR#321][+Pushed] certmap: add OpenSSL implementation

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/321 Title: #321: certmap: add OpenSSL implementation Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#261][comment] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/261 Title: #261: Add systemtap probes into the top-level data provider requests jhrozek commented: """ I'm really sorry this review took so long. I rebased the patches (I'll push them to this PR) and they look good to me. Here is example output: ``` stap /

[SSSD] [sssd PR#261][synchronized] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/261 Author: justin-stephenson Title: #261: Add systemtap probes into the top-level data provider requests Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/261/head:pr261 git checko

[SSSD] [sssd PR#261][+Accepted] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/261 Title: #261: Add systemtap probes into the top-level data provider requests Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@li

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/369 Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef jhrozek commented: """ Since @fidencio wrote the original patch, I'm assigning the PR review to him. """ See the full comment at https://github.com/SSSD/sssd/pull/369#issuecomment-327171

[SSSD] [sssd PR#316][comment] MAN: Improve failover documentation by explaining the timeout better

2017-09-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/316 Title: #316: MAN: Improve failover documentation by explaining the timeout better pbrezina commented: """ Nice :-) Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/316#issuecomment-327172730 _

[SSSD] [sssd PR#316][+Accepted] MAN: Improve failover documentation by explaining the timeout better

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/316 Title: #316: MAN: Improve failover documentation by explaining the timeout better Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-l

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid pbrezina commented: """ These attributes are consumed by `sss_get_name_from_msg` called from `cache_req_search_ncache_filter`. This function returns the name in the following order:

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/369 Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef fidencio commented: """ Wouldn't it change the behavior for py2 consumers? I didn't test the change, but I have the feeling it would and that's the reason I've decided to add the #ifdef'

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/369 Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef lslebodn commented: """ @fidencio What kind of changes do you have in mind? > I didn't test the change, but I have the feeling So test them and do not expect/feel anything before testin

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/369 Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef fidencio commented: """ Basically, can one of the constants be used as keys in the results returned by pysss_nss_idmap.getsidbyname or pysss_nss_idmap.getnamebysid after your patch, when

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid sumit-bose commented: """ The ORIGINALAD_PREFIX SYSDB_NAME is needed for sid_to_name requests. Sorry, I haven't check if the sid_to_name code-patch is involed here. """ See the full

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid pbrezina commented: """ But why should it be needed in `cache_req_search_ncache_filter` where it isn't used? I guess I'm missing something. """ See the full comment at https://githu

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/369 Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef lslebodn commented: """ > Basically, can one of the constants be used as keys in the results returned > by pysss_nss_idmap.getsidbyname or pysss_nss_idmap.getnamebysid after your > patch

[SSSD] [sssd PR#332][synchronized] sydb: index improvements

2017-09-05 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/332 Author: sumit-bose Title: #332: sydb: index improvements Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/332/head:pr332 git checkout pr332 From 5216eb85185e602f5f194102373

[SSSD] [sssd PR#332][comment] sydb: index improvements

2017-09-05 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/332 Title: #332: sydb: index improvements sumit-bose commented: """ I push a new, simplified version of the patch which only adds the missing indices. """ See the full comment at https://github.com/SSSD/sssd/pull/332#issuecomment-327199577 _

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/369 Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef lslebodn commented: """ @sumit-bose you are the author of this module. Could you explain why `getnamebysid` returns bytes for keys. ``` {'userlogin @domain.com': {b'sid': 'S-1-5-21-41859

[SSSD] [sssd PR#351][comment] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid lslebodn commented: """ >But why should it be needed in cache_req_search_ncache_filter where it isn't >used? I guess I'm missing something. It is not directly used by `cache_req_sear

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread bachradsusi
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser bachradsusi commented: """ When you need to manage - add/remove - SELinux login mappings you need to use libsemanage as you do now. There's no such interface in libselinux. As for the `getseu

[SSSD] [sssd PR#369][synchronized] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/369 Author: lslebodn Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/369/head:pr369 git checkout pr369 From 6e2547

[SSSD] [sssd PR#351][synchronized] NSS: Look for name attribute also in nss_cmd_getsidbyid

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/351 Author: lslebodn Title: #351: NSS: Look for name attribute also in nss_cmd_getsidbyid Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/351/head:pr351 git checkout pr351 From 6e

[SSSD] [sssd PR#369][synchronized] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/369 Author: lslebodn Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/369/head:pr369 git checkout pr369 From a25e70

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser lslebodn commented: """ @bachradsusi than you for checking. But I think there is a memory leak, (at leas based on libselinux documentation. ``` /* Get the SELinux username and level to use fo

[SSSD] [sssd PR#342][+Changes requested] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread bachradsusi
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser bachradsusi commented: """ You are right. `db_seuser` and `db_mls_range` need to be free()'d """ See the full comment at https://github.com/SSSD/sssd/pull/342#issuecomment-327214801 _

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser jhrozek commented: """ Thanks for the review. @justin-stephenson can you add the two free calls so we can finally merge this PR after so many months? :-) """ See the full comment at https:/

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/295 Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section jhrozek commented: """ @justin-stephenson does the new patch version look better? """ See the full comment at https://github.com/SSSD/sssd/pull/295#iss

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/369 Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef sumit-bose commented: """ @lslebodn, I guess it was originally an error on my side to use PyBytes_FromString() when generating the dicts and not using it for the constants. Of course st

[SSSD] [sssd PR#316][closed] MAN: Improve failover documentation by explaining the timeout better

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/316 Author: jhrozek Title: #316: MAN: Improve failover documentation by explaining the timeout better Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/316/head:pr316 git checkout pr316

[SSSD] [sssd PR#316][comment] MAN: Improve failover documentation by explaining the timeout better

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/316 Title: #316: MAN: Improve failover documentation by explaining the timeout better lslebodn commented: """ master: * 3bcf6b17a1bd8fbef99e1f8bfc33f4312b40e48b """ See the full comment at https://github.com/SSSD/sssd/pull/316#issuecomment-327225256

[SSSD] [sssd PR#316][+Pushed] MAN: Improve failover documentation by explaining the timeout better

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/316 Title: #316: MAN: Improve failover documentation by explaining the timeout better Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le.

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/369 Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef lslebodn commented: """ >Of course strings can be used, but I like bytes more because they better >indicate that to access the values not the string 'name' should be used but >pysss_nss_

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/369 Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef lslebodn commented: """ >Of course strings can be used, but I like bytes more because they better >indicate that to access the values not the string 'name' should be used but >pysss_nss_

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/295 Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section justin-stephenson commented: """ @jhrozek Looks good from my perspective. """ See the full comment at https://github.com/SSSD/sssd/pull/295#issuecommen

[SSSD] [sssd PR#247][comment] Subdomain inherit

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/247 Title: #247: Subdomain inherit lslebodn commented: """ Bump for 3rd time. Requested unit test has not been written for long time therefore priority for related upstream ticket was changed from critical to blocker """ See the full comment at https://g

[SSSD] [sssd PR#261][comment] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/261 Title: #261: Add systemtap probes into the top-level data provider requests lslebodn commented: """ Is there any reason why `%{_mandir}/man5/sssd-systemtap.5*` is added "twice" into sssd-common? and I assume we do not want to install that man page with

[SSSD] [sssd PR#261][-Accepted] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/261 Title: #261: Add systemtap probes into the top-level data provider requests Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@li

[SSSD] [sssd PR#261][+Changes requested] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/261 Title: #261: Add systemtap probes into the top-level data provider requests Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/295 Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section lslebodn commented: """ BTW we might use at least element quote for `[secrets/users/123] ` `[secrets/users/$uid] ` `[secrets]` or something like in appl

[SSSD] [sssd PR#342][synchronized] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/342 Author: justin-stephenson Title: #342: SELINUX: Use getseuserbyname to get IPA seuser Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/342/head:pr342 git checkout pr342 From 8e

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser justin-stephenson commented: """ PR Updated. """ See the full comment at https://github.com/SSSD/sssd/pull/342#issuecomment-327239761 ___ sssd-deve

[SSSD] [sssd PR#342][-Changes requested] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fed

[SSSD] [sssd PR#332][-Changes requested] sydb: index improvements

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/332 Title: #332: sydb: index improvements Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser jhrozek commented: """ LGTM, waiting for the tests to finish. """ See the full comment at https://github.com/SSSD/sssd/pull/342#issuecomment-327267318

[SSSD] [sssd PR#366][synchronized] SUDO: Use initgr_with_views when looking up a sudo user

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/366 Author: jhrozek Title: #366: SUDO: Use initgr_with_views when looking up a sudo user Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/366/head:pr366 git checkout pr366 From 2fa

[SSSD] [sssd PR#366][comment] SUDO: Use initgr_with_views when looking up a sudo user

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/366 Title: #366: SUDO: Use initgr_with_views when looking up a sudo user jhrozek commented: """ Thank you for the careful review. I pushed new patch, unfortunately I didn't have time to test it properly and I'm away tomorrow, but at least the sysdb search

[SSSD] [sssd PR#366][-Changes requested] SUDO: Use initgr_with_views when looking up a sudo user

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/366 Title: #366: SUDO: Use initgr_with_views when looking up a sudo user Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser jhrozek commented: """ tests passed. """ See the full comment at https://github.com/SSSD/sssd/pull/342#issuecomment-327290257 ___ sssd-devel mailin

[SSSD] [sssd PR#342][+Accepted] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted

[SSSD] [sssd PR#295][synchronized] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/295 Author: jhrozek Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/295/head:pr

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/295 Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section jhrozek commented: """ quote added. I'm away tomorrow, so please push yourself.. """ See the full comment at https://github.com/SSSD/sssd/pull/295#issu

[SSSD] [sssd PR#366][comment] SUDO: Use initgr_with_views when looking up a sudo user

2017-09-05 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/366 Title: #366: SUDO: Use initgr_with_views when looking up a sudo user jhrozek commented: """ retest this please. """ See the full comment at https://github.com/SSSD/sssd/pull/366#issuecomment-327291336 ___ ss

[SSSD] [sssd PR#261][synchronized] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/261 Author: justin-stephenson Title: #261: Add systemtap probes into the top-level data provider requests Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/261/head:pr261 git checko

[SSSD] [sssd PR#261][comment] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/261 Title: #261: Add systemtap probes into the top-level data provider requests justin-stephenson commented: """ Rebased this and addressed comments from @lslebodn With these changes I tested `reconfig --disable-systemtap` and `reconfig --enable-systemta

[SSSD] [sssd PR#275][synchronized] Implement access verification by rhost using ldap_access_order rhost option

2017-09-05 Thread akamensky
URL: https://github.com/SSSD/sssd/pull/275 Author: akamensky Title: #275: Implement access verification by rhost using ldap_access_order rhost option Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/275/head:pr275 git

[SSSD] [sssd PR#370][opened] certmap: Suppress warning Wmissing-braces

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/370 Author: lslebodn Title: #370: certmap: Suppress warning Wmissing-braces Action: opened PR body: """ Older version of gcc(e.g. gcc-4.8.5-11.el7) had a false positive warning with c99 struct initialisation "{ 0 }". https://gcc.gnu.org/bugzilla/show_bug.

[SSSD] [sssd PR#295][+Pushed] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/295 Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email

[SSSD] [sssd PR#295][comment] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/295 Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section lslebodn commented: """ master: * e8bad995fb1219df2a4fef8f55c80284c6ab36d3 """ See the full comment at https://github.com/SSSD/sssd/pull/295#issuecomme

[SSSD] [sssd PR#295][closed] MAN: Document that the secrets provider can only be specified in a per-client section

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/295 Author: jhrozek Title: #295: MAN: Document that the secrets provider can only be specified in a per-client section Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/295/head:pr295 gi

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser lslebodn commented: """ master: * cfe87ca0c4fded9cbf907697d08fa0e6c8f8ebce """ See the full comment at https://github.com/SSSD/sssd/pull/342#issuecomment-327386321 ___

[SSSD] [sssd PR#342][closed] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/342 Author: justin-stephenson Title: #342: SELINUX: Use getseuserbyname to get IPA seuser Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/342/head:pr342 git checkout pr342 _

[SSSD] [sssd PR#342][comment] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser lslebodn commented: """ I still thing that it is not ideal solution. libsemanage is already linked with libselinux so it shall be fixed there, Anyway majority wins and patch was pushed. """

[SSSD] [sssd PR#342][+Pushed] SELINUX: Use getseuserbyname to get IPA seuser

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/342 Title: #342: SELINUX: Use getseuserbyname to get IPA seuser Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o

[SSSD] [sssd PR#261][-Changes requested] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/261 Title: #261: Add systemtap probes into the top-level data provider requests Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel

[SSSD] [sssd PR#261][comment] Add systemtap probes into the top-level data provider requests

2017-09-05 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/261 Title: #261: Add systemtap probes into the top-level data provider requests lslebodn commented: """ @justin-stephenson. I am not sure what did you mean by last comment. Because last version works for me. ``` sh$ ./configure sh$ make V=0 -j8 sh$ make