On pe, 03 marras 2017, Lukas Slebodnik wrote:
On (03/11/17 07:55), Alexander Bokovoy wrote:
On pe, 03 marras 2017, smfre...@gmail.com wrote:
I am expecting that RHEL7.5 still has problems with Samba and SSSD
library problems e.g. I see this comment indicating that RHEL 7.5 beta
sssd (even with
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
On 11/03/2017 05:41 PM, lslebodn wrote:
> On (03/11/17 16:19), mzidek-rh wrote:
> >No, I used good example. Your example is the wrong one and would not
> trigger the
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedoraho
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
sumit-bose commented:
"""
Thank you for the review, I include all your comments in the latest version.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/433#issuecomment-341763543
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
lslebodn commented:
"""
On (03/11/17 16:36), mzidek-rh wrote:
>Sorry, but this:
>```
>(Fri Nov 3 15:52:42 2017) [sssd[nss]] [sysdb_getpwnam] (0x0020): Search for
>[ema...@ipadomain.test] ret
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
So, coverity found some issues:
- **Error: USE_AFTER_FREE (CWE-825): [#def1]**
```
sssd-1.16.1/src/sss_client/pam_sss.c:154: alias: Assigning: "cai" =
"cai->next". Now both
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
lslebodn commented:
"""
On (03/11/17 16:19), mzidek-rh wrote:
>No, I used good example. Your example is the wrong one and would not trigger
>the error.
>
There are more ways how you can sto
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
I have updated the comments in order to reflect on what we discussed on IRC.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/433#issuecomment-341759325
__
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
So, coverity found some issues:
- **Error: USE_AFTER_FREE (CWE-825): [#def1]**
```
sssd-1.16.1/src/sss_client/pam_sss.c:154: alias: Assigning: "cai" =
"cai->next". Now both
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
So, coverity found some issues:
- **Error: USE_AFTER_FREE (CWE-825): [#def1]**
```
sssd-1.16.1/src/sss_client/pam_sss.c:154: alias: Assigning: "cai" =
"cai->next". Now both
URL: https://github.com/SSSD/sssd/pull/436
Title: #436: subdomains: Remove code only used in tests
fidencio commented:
"""
@amitkumar50, please, when contributing to the project, always try to:
- run `$ make check` in your patches
- run `$ make intgcheck`
And in case you're fixing a bug, point
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
Sorry, but this:
```
(Fri Nov 3 15:52:42 2017) [sssd[nss]] [sysdb_getpwnam] (0x0020): Search for
[ema...@ipadomain.test] returned multiple results. It can be an emai
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
lslebodn commented:
"""
On (03/11/17 15:21), mzidek-rh wrote:
>About logging message to syslog. I am not against it. I wanted to solve it by
>MAN + DEBUG. MAN + DEBUG + SYSLOG, looked like o
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
No, I used good example. Your example is the wrong one and would not trigger
the error.
What do you think will happen if in my example scenario I search for 'getent
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
lslebodn commented:
"""
On (03/11/17 15:06), mzidek-rh wrote:
>It will not generate the message you wrote.
>It will never show shortname in the output.
Yes, I forgot to use fqname there. But
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
About logging message to syslog. I am not against it. I wanted to solve it by
MAN + DEBUG. MAN + DEBUG + SYSLOG, looked like overkill to me, especially
given that w
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
You are wrong.
It will not generate the message you wrote.
It will never show shortname in the output.
It will not generate the error if you search by username that is
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
benzea commented:
"""
@lslebodn I seriously don't know why it was restarting. I was guessing that it
was simply shutting down as it was idle or something like that.
"""
See the full comment at
https:
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
So, coverity found some issues:
- **Error: USE_AFTER_FREE (CWE-825): [#def1]**
```
sssd-1.16.1/src/sss_client/pam_sss.c:154: alias: Assigning: "cai" =
"cai->next". Now both
URL: https://github.com/SSSD/sssd/pull/436
Title: #436: subdomains: Remove code only used in tests
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorah
URL: https://github.com/SSSD/sssd/pull/436
Title: #436: subdomains: Remove code only used in tests
lslebodn commented:
"""
@amitkumar50 Removing code is not enough otherwise unit test will fail.
You need to also update related test.
```
FAIL: ad_common_tests
=
[==]
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
lslebodn commented:
"""
On (03/11/17 14:26), mzidek-rh wrote:
>mzidek-rh commented on this pull request.
>> @@ -218,6 +218,21 @@ int sysdb_getpwnam(TALLOC_CTX *mem_ctx,
> goto done;
>
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
I added a note to the commit message.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/432#issuecomment-341719462
__
URL: https://github.com/SSSD/sssd/pull/432
Author: mzidek-rh
Title: #432: CACHE_REQ: Better debugging for email conflicts
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/432/head:pr432
git checkout pr432
From c97878747
URL: https://github.com/SSSD/sssd/pull/436
Title: #436: subdomains: Remove code only used in tests
lslebodn commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/436#issuecomment-341718678
___
sssd-devel mailing list
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/437
Author: lslebodn
Title: #437: KCM: Fix restart during/after upgrade
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/437/head:pr437
git checkout pr437
___
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
lslebodn commented:
"""
master:
* 53d1459e9b87196b4f6e327f0f5db4d9229bf541
"""
See the full comment at
https://github.com/SSSD/sssd/pull/437#issuecomment-341714376
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
lslebodn commented:
"""
>Actually, I ran into this at least three times yesterday and today just
>normally working on my laptop (without doing upgrades).
@benzea
Do you really restart/upgrade sssd-kc
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
lslebodn commented:
"""
BTW all non-clear parts which were explained in PR should have been part of
commit message.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/432#issuec
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
lslebodn commented:
"""
>I disagree about the priority. I think it is urgent to get the fix into
>Fedora. On a quick look, the PR looks good, but I wonder if you had the time
>to ask the systemd devel
URL: https://github.com/SSSD/sssd/pull/438
Author: lslebodn
Title: #438: krb5_child: Distinguish between expired & disabled AD user
Action: opened
PR body:
"""
This is an updated version of patchset which was prepared a long time ago.
It had to be changed due to commit 78027feeb56d6fe216f699
URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report
fidencio commented:
"""
@pbrezina: Do you plan to update this PR? As @jhrozek is not working Today,
someone has to do that if we want to have it merged.
"""
See the full comment at
https://gi
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
@sumit-bose, as we discussed in our internal meeting, someone from our QA team
would do the functional testing.
So far I've taken a look at the code and came up with the fo
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedoraho
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
By namealias I meant SYSDB_NAME_ALIAS if it was not clear.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/432#issuecomment-341698043
_
URL: https://github.com/SSSD/sssd/pull/425
Title: #425: Fix issue #3451
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/425
Author: fidencio
Title: #425: Fix issue #3451
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/425/head:pr425
git checkout pr425
___
sssd-
URL: https://github.com/SSSD/sssd/pull/425
Title: #425: Fix issue #3451
lslebodn commented:
"""
master:
* add72860c7a7a2c418f4d8b6790b5caeaf7dfb7b
"""
See the full comment at
https://github.com/SSSD/sssd/pull/425#issuecomment-341696973
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
The problem is with multiple users sharing the same email in LDAP/IPA. The
email attribute from LDAP is stored twice in the local SYSDB database.
Once as the SYSDB_U
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
lslebodn commented:
"""
>You are wrong. As I wrote in one of the previous comments:
>"Just a note, we do not use SYSDB_USER_EMAIL in getpwnam searches. We
>lowercase the attribute >and store
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
lslebodn commented:
"""
>You are wrong. As I wrote in one of the previous comments:
>"Just a note, we do not use SYSDB_USER_EMAIL in getpwnam searches. We
>lowercase the attribute >and store
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
mzidek-rh commented:
"""
You are wrong. As I wrote in one of the previous comments:
"Just a note, we do not use SYSDB_USER_EMAIL in getpwnam searches. We lowercase
the attribute and store it
URL: https://github.com/SSSD/sssd/pull/432
Author: mzidek-rh
Title: #432: CACHE_REQ: Better debugging for email conflicts
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/432/head:pr432
git checkout pr432
From 887172014
URL: https://github.com/SSSD/sssd/pull/425
Title: #425: Fix issue #3451
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/425
Title: #425: Fix issue #3451
sumit-bose commented:
"""
Thanks, ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/425#issuecomment-341688345
___
sssd-devel mailing list -- sssd-devel@lists.fe
URL: https://github.com/SSSD/sssd/pull/425
Author: fidencio
Title: #425: Fix issue #3451
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/425/head:pr425
git checkout pr425
From 19e61de441988434d5823d769dcac4302f77032b M
URL: https://github.com/SSSD/sssd/pull/425
Title: #425: Fix issue #3451
fidencio commented:
"""
Sure:
```
diff --git a/src/providers/ldap/ldap_auth.c b/src/providers/ldap/ldap_auth.c
index 1bb151833..a3b1480aa 100644
--- a/src/providers/ldap/ldap_auth.c
+++ b/src/providers/ldap/ldap_auth.c
@@ -6
URL: https://github.com/SSSD/sssd/pull/434
Title: #434: sudo: require sudoHost attribute and do not merge rules
pbrezina commented:
"""
This is something I would like to do. But I'm not sure.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/434#issuecomment-341684729
_
URL: https://github.com/SSSD/sssd/pull/434
Author: pbrezina
Title: #434: sudo: require sudoHost attribute and do not merge rules
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/434/head:pr434
git checkout pr434
From 48
URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report
pbrezina commented:
"""
On 11/03/2017 09:56 AM, fidencio wrote:
> *@fidencio* commented on this pull request.
>
> And I've also found something a little bit weird in the code.
>
> --
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
fidencio commented:
"""
I also agree with the solution!
Please, refer to the
https://www.freedesktop.org/software/systemd/man/systemd.unit.html#Requires= in
case you want to see more details on what
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
benzea commented:
"""
Actually, I ran into this at least three times yesterday and today just
normally working on my laptop (without doing upgrades).
"Requires" does not imply any order, it just means
URL: https://github.com/SSSD/sssd/pull/425
Title: #425: Fix issue #3451
sumit-bose commented:
"""
Thank you, the patch works as expected. I only have a small request, can you
replace the variable name 'next_req' by 'subreq' which is what we typically use.
'next_req' comes from a time where the
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
jhrozek commented:
"""
I disagree about the priority. I think it is urgent to get the fix into Fedora.
On a quick look, the PR looks good, but I wonder if you had the time to ask the
systemd developer
URL: https://github.com/SSSD/sssd/pull/437
Title: #437: KCM: Fix restart during/after upgrade
lslebodn commented:
"""
It is not hight prio PR. So review can wait a bit.
But it was super fast to prepare it.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/437#issuecomment-341671183
URL: https://github.com/SSSD/sssd/pull/436
Author: amitkumar50
Title: #436: subdomains: Remove code only used in tests
Action: opened
PR body:
"""
When setting the ad_options in subdomain code there is an condition
if (cdb == NULL || conf_path == NULL)
True branch is only usable in tests that
URL: https://github.com/SSSD/sssd/pull/437
Author: lslebodn
Title: #437: KCM: Fix restart during/after upgrade
Action: opened
PR body:
"""
Oct 02 12:26:57 host systemd[1]: Closed SSSD Kerberos Cache Manager responder
socket.
Oct 02 12:26:57 host systemd[1]: Stopping SSSD Kerberos Cache Manage
URL: https://github.com/SSSD/sssd/pull/436
Title: #436: subdomains: Remove code only used in tests
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/436#issuecomment-341670960
URL: https://github.com/SSSD/sssd/pull/436
Title: #436: subdomains: Remove code only used in tests
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/436#issuecomment-341670959
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
lslebodn commented:
"""
I'm sorry the error message is still vague and it will not fix the bug.
NACK.
`SYSDB_USER_EMAIL` is part of attributes requested in `SYSDB_PW_ATTRS` and used
in
many
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fe
URL: https://github.com/SSSD/sssd/pull/426
Title: #426: nss-idmap: add nss like calls with timeout and flags
jhrozek commented:
"""
Thank you, I will run some downstream tests today again. FWIW, one test, about
netgroups midpoint refresh, seems to be failing with yesterday's patches, but
let
On (03/11/17 07:55), Alexander Bokovoy wrote:
>On pe, 03 marras 2017, smfre...@gmail.com wrote:
>> I am expecting that RHEL7.5 still has problems with Samba and SSSD
>> library problems e.g. I see this comment indicating that RHEL 7.5 beta
>> sssd (even with default Samba in RHEL) is broken
>> http
URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report
fidencio commented:
"""
CI with the whitespace changes fixed:
http://vm-031.{$abc}/logs/job/80/33/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/424#issuecomment-3
66 matches
Mail list logo
