URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
fidencio commented:
"""
@mrniranjan, on SSSD we, at least, try enforce 80. You can see by the
https://github.com/SSSD/sssd/pull/379.
So, in case we have that PR merged, we'd be officially enforcin
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
mrniranjan commented:
"""
I am unable to access the link given
"""
See the full comment at
https://github.com/SSSD/sssd/pull/139#issuecomment-344157048
___
URL: https://github.com/SSSD/sssd/pull/449
Title: #449: cache: Check for max_id/min_id in cache_req
fidencio commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/449#issuecomment-344157080
___
sssd-devel mailing lis
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
mrniranjan commented:
"""
I have fixed most of the errors suggested, i would like if you we don't enforce
80chars limit, the readeability really hampers, Can we have 90 or 100 character
limit .
"
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
mrniranjan commented:
"""
I am unable to access http://vm-031.$%7babc%7d/logs/job/81/13/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/139#issuecomment-344157048
_
URL: https://github.com/SSSD/sssd/pull/448
Title: #448: common: Correction of cache_req debug string ID format
fidencio commented:
"""
Ack! I'll fire an internal CI run just for the sake of the process and add the
"Accepted" label when I get the result.
Thanks for the contribution, @amitkumar5
URL: https://github.com/SSSD/sssd/pull/448
Title: #448: common: Correction of cache_req debug string ID format
fidencio commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/448#issuecomment-344156272
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/449
Title: #449: cache: Check for max_id/min_id in cache_req
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/449#issuecomment-344152517
___
URL: https://github.com/SSSD/sssd/pull/449
Title: #449: cache: Check for max_id/min_id in cache_req
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/449#issuecomment-344152516
___
URL: https://github.com/SSSD/sssd/pull/449
Author: amitkumar50
Title: #449: cache: Check for max_id/min_id in cache_req
Action: opened
PR body:
"""
The cache_req code doesn't check the min_id/max_id
boundaries for requests by ID.
Extending the .lookup_fn function in each plugin
that searches b
URL: https://github.com/SSSD/sssd/pull/448
Title: #448: common: Correction of cache_req debug string ID format
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/448#issuecomment-344130857
URL: https://github.com/SSSD/sssd/pull/448
Author: amitkumar50
Title: #448: common: Correction of cache_req debug string ID format
Action: opened
PR body:
"""
The cache-req debug string representation uses a wrong format
specifier for by-ID requests.
%d should be replaced with %"SPRIgid".
Re
URL: https://github.com/SSSD/sssd/pull/448
Title: #448: common: Correction of cache_req debug string ID format
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/448#issuecomment-344130858
URL: https://github.com/SSSD/sssd/pull/405
Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le.
URL: https://github.com/SSSD/sssd/pull/405
Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift
fidencio commented:
"""
Actually, I've just realised that the comment about unnecessarily adding
string.h was not fixed yet, thus adding the "Changes Requested" label.
"""
See the
URL: https://github.com/SSSD/sssd/pull/405
Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.
URL: https://github.com/SSSD/sssd/pull/405
Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.
URL: https://github.com/SSSD/sssd/pull/405
Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift
fidencio commented:
"""
Patch looks okay to me. I'm adding the "Accepted" label.
@vtapia, thanks for the contribution and sorry for the long delay to review it
and get it merged.
URL: https://github.com/SSSD/sssd/pull/444
Author: fidencio
Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.14
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/444/head:pr444
gi
URL: https://github.com/SSSD/sssd/pull/444
Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.14
fidencio commented:
"""
Changes done, thanks for the review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/444#issuecomment-343996647
URL: https://github.com/SSSD/sssd/pull/444
Author: fidencio
Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.14
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/444/head:pr444
gi
URL: https://github.com/SSSD/sssd/pull/445
Title: #445: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.13
lslebodn commented:
"""
Patch will be the same as in sssd-1-14 branch therefore closing.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/445#iss
URL: https://github.com/SSSD/sssd/pull/445
Title: #445: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.13
Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to ss
URL: https://github.com/SSSD/sssd/pull/445
Author: fidencio
Title: #445: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.13
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/445/head:pr445
git chec
URL: https://github.com/SSSD/sssd/pull/445
Title: #445: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.13
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to ss
URL: https://github.com/SSSD/sssd/pull/444
Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.14
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to ss
On Mon, Nov 13, 2017 at 11:16 AM, Pavel Březina wrote:
> Hello,
>
> It took me a lot longer than I expected but here it is at last. This is my
> set of scripts that use vagrant and Ansible to automatically provision
> virtual environment that I use to develop and test SSSD.
>
> To create this envi
URL: https://github.com/SSSD/sssd/pull/443
Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@l
URL: https://github.com/SSSD/sssd/pull/443
Author: fidencio
Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/443/head:pr443
git checkout pr443
___
URL: https://github.com/SSSD/sssd/pull/443
Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()
jhrozek commented:
"""
* master: f6a1cef87abdd983d6b5349cd341c9a249826577
"""
See the full comment at
https://github.com/SSSD/sssd/pull/443#issuecomment-343971982
_
URL: https://github.com/SSSD/sssd/pull/432
Author: mzidek-rh
Title: #432: CACHE_REQ: Better debugging for email conflicts
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/432/head:pr432
git checkout pr432
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
jhrozek commented:
"""
* master: 39d6a3be119b050b0690152b6b443117c8617b1c
"""
See the full comment at
https://github.com/SSSD/sssd/pull/432#issuecomment-343970599
___
URL: https://github.com/SSSD/sssd/pull/447
Title: #447: SYSDB: Remove code causing a covscan warning
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/447
Title: #447: SYSDB: Remove code causing a covscan warning
jhrozek commented:
"""
* master: b739b3e767c053bb3a7e6651514896b30502d838
"""
See the full comment at
https://github.com/SSSD/sssd/pull/447#issuecomment-343969806
__
URL: https://github.com/SSSD/sssd/pull/447
Author: fidencio
Title: #447: SYSDB: Remove code causing a covscan warning
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/447/head:pr447
git checkout pr447
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
fidencio commented:
"""
whitespace tests failed, please, take a look at:
http://vm-031.${abc}/logs/job/81/13/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/139#issueco
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
fidencio commented:
"""
@justin-stephenson, nice, thanks!
I'm adding the "Accepted" label to this PR based on the discussion we had
during the team meeting and in the feedback provided by @j
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
fidencio commented:
"""
So, just by running pep8 in the python files I've seen:
```
[ffidenci@pessoa sssd]$ pep8 src/tests/multihost/basic/conftest.py
src/tests/multihost/basic/test_basic.py src/te
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
fidencio commented:
"""
retest this, please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/139#issuecomment-343961592
___
sssd-devel mail
URL: https://github.com/SSSD/sssd/pull/432
Title: #432: CACHE_REQ: Better debugging for email conflicts
justin-stephenson commented:
"""
@fidencio man page verbiage looks good to me.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/432#issuecomment-343960502
__
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/433
Author: sumit-bose
Title: #433: PAM: Multiple certificates on a Smartcard
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/433/head:pr433
git checkout pr433
_
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
lslebodn commented:
"""
master:
* 57cefea8305a57c1c0491afb739813b7f17d5a25
* 177ab84f0e336b75289a3ac0b2df25bd5ab5198b
* 08d1f8c0d6eece6a48201d7f8824b282eac3458d
* fd6f4047b58686bd4057c9859c3c804a77b
On Thu, Nov 09, 2017 at 12:23:24PM +0100, Michal Židek wrote:
> On 11/08/2017 11:28 AM, Sumit Bose wrote:
> > Hi,
> >
> > while trying to prepare some diagrams to illustrate how the memory mapped
> > cache works I realized that we might not use the payload factor as
> > expected.
> >
> > In sss_m
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
fidencio commented:
"""
@mrniranjan, no updates on this at all.
Although it's on top of my TODO list, downstream work has been prioritized
(sorry about that).
"""
See the full comment at
https:/
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
mrniranjan commented:
"""
@lslebodn @fidencio any update on this.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/139#issuecomment-343939581
__
URL: https://github.com/SSSD/sssd/pull/443
Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...
URL: https://github.com/SSSD/sssd/pull/444
Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.14
fidencio commented:
"""
Adding "Accepted" label per @pbrezina's review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/444#issuecomment-3439076
URL: https://github.com/SSSD/sssd/pull/443
Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()
fidencio commented:
"""
Adding "Accepted" label per @pbrezina's review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/443#issuecomment-343907653
___
URL: https://github.com/SSSD/sssd/pull/444
Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.14
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to ss
URL: https://github.com/SSSD/sssd/pull/447
Title: #447: SYSDB: Remove code causing a covscan warning
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.o
URL: https://github.com/SSSD/sssd/pull/445
Title: #445: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.13
fidencio commented:
"""
Adding "Accepted" label per @pbrezina's review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/445#issuecomment-3439075
URL: https://github.com/SSSD/sssd/pull/445
Title: #445: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.13
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to ss
URL: https://github.com/SSSD/sssd/pull/447
Title: #447: SYSDB: Remove code causing a covscan warning
fidencio commented:
"""
Adding "Accepted" label per @pbrezina's review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/447#issuecomment-343907442
URL: https://github.com/SSSD/sssd/pull/444
Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.14
fidencio commented:
"""
@pbrezina, thanks for the review. I've changed the commit message.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/444#i
URL: https://github.com/SSSD/sssd/pull/445
Title: #445: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.13
fidencio commented:
"""
@pbrezina, thanks for the review. I've changed the commit message.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/445#i
URL: https://github.com/SSSD/sssd/pull/445
Author: fidencio
Title: #445: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.13
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/445/head:pr445
gi
URL: https://github.com/SSSD/sssd/pull/447
Title: #447: SYSDB: Remove code causing a covscan warning
pbrezina commented:
"""
Ack.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/447#issuecomment-343895443
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/445
Title: #445: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.13
pbrezina commented:
"""
Ack. Just the commit message still talkes about `enum_ctx` which is not present
on 1.13.
"""
See the full comment at
https://github.c
URL: https://github.com/SSSD/sssd/pull/444
Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch
for SSSD-1.14
pbrezina commented:
"""
Ack. Just the commit message still talkes about `enum_ctx` which is not present
on 1.14.
"""
See the full comment at
https://github.c
URL: https://github.com/SSSD/sssd/pull/443
Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()
pbrezina commented:
"""
If `enum_ctx` is freed than the timeout is canceled. Ack.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/443#issuecomment-343893828
_
URL: https://github.com/SSSD/sssd/pull/412
Title: #412: Gpo contributed patches
mzidek-rh commented:
"""
@fidencio Dan did run the tests and I had results, but the tests were all
failing due to SSSD not been able to start. IIRC it was due to wrong selinux
policy installed in the testing VM. So
Hello,
It took me a lot longer than I expected but here it is at last. This is
my set of scripts that use vagrant and Ansible to automatically
provision virtual environment that I use to develop and test SSSD.
To create this environment you only need to run one command:
$ ./setup.sh
and afte
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
sumit-bose commented:
"""
The latest version fixes @lslebodn's comment and modifies a filter in the
whitespace test so that the added NSS database files are skipped as well.
"""
See the full comme
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
lslebodn commented:
"""
BTW fix for whitespace on my laptop
```
echo "" >> src/tests/cmocka/p11_nssdb_2certs/key4.db
echo "" >> src/tests/cmocka/p11_nssdb_2certs/cert9.db
```
it was simpler than ad
URL: https://github.com/SSSD/sssd/pull/447
Author: fidencio
Title: #447: SYSDB: Remove code causing a covscan warning
Action: opened
PR body:
"""
There's no reason to check for both ret != EOK and sanitized == NULL, as
the second should never ever happen.
This check is causing a clang warning
URL: https://github.com/SSSD/sssd/pull/447
Author: fidencio
Title: #447: SYSDB: Remove code causing a covscan warning
Action: edited
Changed field: body
Original value:
"""
There's no reason to check for both ret != EOK and sanitized == NULL, as
the second should never ever happen.
This chec
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
lslebodn commented:
"""
FYI https://bugzilla.redhat.com/show_bug.cgi?id=1512212
"""
See the full comment at
https://github.com/SSSD/sssd/pull/433#issuecomment-343842285
___
URL: https://github.com/SSSD/sssd/pull/405
Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift
fidencio commented:
"""
@lslebodn, please, could you take a look in the second version of this patch or
let me know if you cannot?
This PR has been stuck for 18 days without **any
URL: https://github.com/SSSD/sssd/pull/412
Title: #412: Gpo contributed patches
fidencio commented:
"""
@mzidek-rh, I know you're busy with a few other stuff, but would be possible to
at least give an update on this ticket? It's already been 24 days without
**any** update.
So, Have you talked
72 matches
Mail list logo
