[SSSD] [sssd PR#405][comment] WATCHDOG: Restart providers with SIGUSR2 after time drift

2017-11-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/405 Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift lslebodn commented: """ @fidencio have you had a time to run regression tests? """ See the full comment at https://github.com/SSSD/sssd/pull/405#issuecomment-344841816 ___

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format fidencio commented: """ @amitkumar50, you made the changes addressing only half of @lslebodn's comments. @lslebodn said: "This one is for UID. So it should be SPRIuid ..." Okay, it's

[SSSD] [sssd PR#448][+Changes requested] common: Correction of cache_req debug string ID format

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@l

[SSSD] [sssd PR#448][-Changes requested] common: Correction of cache_req debug string ID format

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@l

[SSSD] [sssd PR#449][synchronized] cache: Check for max_id/min_id in cache_req

2017-11-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/449 Author: amitkumar50 Title: #449: cache: Check for max_id/min_id in cache_req Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/449/head:pr449 git checkout pr449 From 630b9fc87b5

[SSSD] [sssd PR#448][comment] common: Correction of cache_req debug string ID format

2017-11-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Title: #448: common: Correction of cache_req debug string ID format amitkumar50 commented: """ Are some changes required? Label is 'Changed Requested' """ See the full comment at https://github.com/SSSD/sssd/pull/448#issuecomment-344817280 ___

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-15 Thread mrniranjan
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework mrniranjan commented: """ Till we have some idea on the review process, the directory structure of where tests should be pushed and how to run those tests , i am okay with not having PUSH access.

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ Sure, thanks for the clarification. About the push privileges, I would just prefer to drop a mail to sssd-devel before granting push privileges to someone who was not previo

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework fidencio commented: """ So, based that the tests would be reviewed by people currently working on the test development, at least in the beginning, I'd like that @mrniranjan could have push access

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework jhrozek commented: """ Sure, but I'm not sure what exactly I'm supposed to do :-) What exact permissions does @mrniranjan need? Does this include push privileges in order to push patches? (IIRC wh

[SSSD] [sssd PR#443][comment] NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/443 Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout() fidencio commented: """ I didn't. As I said in the first comment, I was **not** able to reproduce the issue at all, even with the steps you mentioned in the bugzilla. """ S

[SSSD] [sssd PR#443][comment] NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout()

2017-11-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/443 Title: #443: NSS: Use enum_ctx as memory_context in _setnetgrent_set_timeout() lslebodn commented: """ @fidencio Have you find a reason why we reached timeout? I would expect that backend should return something to nss responder. """ See the full com

[SSSD] [sssd PR#444][comment] NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14

2017-11-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/444 Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14 lslebodn commented: """ sssd-1-14: * e2ee9ff3bcd321c5ab9746a83ce81aaaf71f5355 sssd-1-13: * 6c39572b99fc43979931d2f12f15343cdbfcf6a0 """ See the full comment a

[SSSD] [sssd PR#444][+Pushed] NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14

2017-11-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/444 Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd

[SSSD] [sssd PR#444][closed] NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14

2017-11-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/444 Author: fidencio Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/444/head:pr444 git chec

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework fidencio commented: """ With this code being pushed I'd like to ask for: - Add @mrniranjan as SSSD mantainer - Create a pagure session for issues related to this code @jhrozek, could you do both? "

[SSSD] [sssd PR#139][+Accepted] Initial revision of sssd pytest framework

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework fidencio commented: """ Ack! """ See the full comment at https://github.com/SSSD/sssd/pull/139#issuecomment-344591542 ___ sssd-devel mailing list -- sss

[SSSD] [sssd PR#444][comment] NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14

2017-11-15 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/444 Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14 pbrezina commented: """ Ah, sorry, you haven't pushed it, just closed it. My bad. Having it on `netgr` context is safer and more correct in my opinion. But fee

[SSSD] [sssd PR#444][comment] NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14

2017-11-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/444 Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14 lslebodn commented: """ On (15/11/17 11:54), Pavel Březina wrote: >You have already pushed version with `netgr` into 1.13 (#445). I don't think >we need to hav

[SSSD] [sssd PR#444][comment] NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14

2017-11-15 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/444 Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14 pbrezina commented: """ You have already pushed version with `netgr` into 1.13 (#445). I don't think we need to have three different patches in three different

[SSSD] [sssd PR#449][comment] cache: Check for max_id/min_id in cache_req

2017-11-15 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/449 Title: #449: cache: Check for max_id/min_id in cache_req jhrozek commented: """ @pbrezina I'm still running some tests with my patches, but in general they are ready and published in my gc_uid branch. btw see the downtream report - we were already ask

[SSSD] [sssd PR#139][-Changes requested] Initial revision of sssd pytest framework

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedoraho

[SSSD] [sssd PR#448][synchronized] common: Correction of cache_req debug string ID format

2017-11-15 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/448 Author: amitkumar50 Title: #448: common: Correction of cache_req debug string ID format Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/448/head:pr448 git checkout pr448 From

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-15 Thread mrniranjan
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework mrniranjan commented: """ Thanks will apply the changes suggested and resend the patch """ See the full comment at https://github.com/SSSD/sssd/pull/139#issuecomment-344558254 ___

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-11-15 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework fidencio commented: """ I've been able to test the patches with some documentation sent by @mrniranjan. As this documentation is related to provisioning downstream infra, it's not worth (nor allow

[SSSD] [sssd PR#444][comment] NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14

2017-11-15 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/444 Title: #444: NSS: Use netgr as memory context in set_netgr_lifetime() - Patch for SSSD-1.14 lslebodn commented: """ @pbrezina can it be pushed? """ See the full comment at https://github.com/SSSD/sssd/pull/444#issuecomment-344556887 _