[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user fidencio commented: """ Changes done according to your suggestion. Thanks for the review and I'm removing the "Changes Requested" label. """ See the full comment at https

[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user fidencio commented: """ Changes done according to your suggestion. Thanks for the review and I'm removing the "Changes Requested" label.u """ See the full comment at http

[SSSD] [sssd PR#516][-Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-

[SSSD] [sssd PR#516][synchronized] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/516 Author: fidencio Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/516/head:pr516 git checkout

[SSSD] [sssd PR#520][+Accepted] DESKPROFILE: Fix 'Improper use of negative value'

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/520 Title: #520: DESKPROFILE: Fix 'Improper use of negative value' Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahos

[SSSD] [sssd PR#520][comment] DESKPROFILE: Fix 'Improper use of negative value'

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/520 Title: #520: DESKPROFILE: Fix 'Improper use of negative value' fidencio commented: """ Ouch, I've missed it in just one place. Thanks for the patch, @sumit-bose! ACK! """ See the full comment at https://github.com/SSSD/sssd/pull/520#issuecomment-3668

[SSSD] [sssd PR#394][+Rejected] TESTS: Add an integration test for renaming incomplete groups during initgroups

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/394 Title: #394: TESTS: Add an integration test for renaming incomplete groups during initgroups Label: +Rejected ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#394][comment] TESTS: Add an integration test for renaming incomplete groups during initgroups

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/394 Title: #394: TESTS: Add an integration test for renaming incomplete groups during initgroups fidencio commented: """ Closing the PR as the very same patch is part of #128 """ See the full comment at https://github.com/SSSD/sssd/pull/394#issuecommen

[SSSD] [sssd PR#394][closed] TESTS: Add an integration test for renaming incomplete groups during initgroups

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/394 Author: jhrozek Title: #394: TESTS: Add an integration test for renaming incomplete groups during initgroups Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/394/head:pr394 git che

[SSSD] [sssd PR#394][-Changes requested] TESTS: Add an integration test for renaming incomplete groups during initgroups

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/394 Title: #394: TESTS: Add an integration test for renaming incomplete groups during initgroups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Patch set has been updated. It already includes the tests provided on #394. """ See the full comment at https://github.com/SSSD/sssd/pull/128#issuecomment-3

[SSSD] [sssd PR#128][-Changes requested] Fix group renaming issue when "id_provider = ldap" is set

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le..

[SSSD] [sssd PR#128][synchronized] Fix group renaming issue when "id_provider = ldap" is set

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Author: fidencio Title: #128: Fix group renaming issue when "id_provider = ldap" is set Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/128/head:pr128 git checkout pr128 From

[SSSD] [sssd PR#520][opened] DESKPROFILE: Fix 'Improper use of negative value'

2018-02-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/520 Author: sumit-bose Title: #520: DESKPROFILE: Fix 'Improper use of negative value' Action: opened PR body: """ This issue was found by Coverity. Similar as in code block before ret must be set to errno to allow proper log messages since initial ret wil

[SSSD] [sssd PR#517][comment] Fix two memory leaks in the AD provider

2018-02-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider sumit-bose commented: """ Sorry, there were some unrelated changes in the last commit. """ See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-366748803 __

[SSSD] [sssd PR#517][synchronized] Fix two memory leaks in the AD provider

2018-02-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/517 Author: sumit-bose Title: #517: Fix two memory leaks in the AD provider Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/517/head:pr517 git checkout pr517 From 3296630559b3dfd6

[SSSD] [sssd PR#517][-Changes requested] Fix two memory leaks in the AD provider

2018-02-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahost

[SSSD] [sssd PR#517][comment] Fix two memory leaks in the AD provider

2018-02-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider sumit-bose commented: """ oopsy, fixed version pushed. """ See the full comment at https://github.com/SSSD/sssd/pull/517#issuecomment-366703772 ___ sssd-

[SSSD] [sssd PR#517][synchronized] Fix two memory leaks in the AD provider

2018-02-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/517 Author: sumit-bose Title: #517: Fix two memory leaks in the AD provider Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/517/head:pr517 git checkout pr517 From 3296630559b3dfd6

[SSSD] [sssd PR#517][comment] Fix two memory leaks in the AD provider

2018-02-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider jhrozek commented: """ I think the patches look good in general, but the tests don't compile at the moment: ``` /home/remote/jhrozek/devel/sssd/src/tests/cmocka/test_ad_common.c: In function ‘test_u

[SSSD] [sssd PR#517][+Changes requested] Fix two memory leaks in the AD provider

2018-02-19 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahost

[SSSD] [sssd PR#519][comment] DEBUG: Print simple access provider allow and deny lists

2018-02-19 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/519 Title: #519: DEBUG: Print simple access provider allow and deny lists sumit-bose commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/519#issuecomment-366623797 ___ sssd-de

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-02-19 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ Okay, I'll work on Sumit's suggestion. Please, just mind that while I (theoretically) do have access* to the struct data_provider from the sdap_ad_save_grou