[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ CI: http://vm-031.${abc}/logs/job/87/16/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373840445 ___

[SSSD] [sssd PR#537][-Changes requested] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-l

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537 Fr

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ Fixed your request and fixed the el6 related issue. """ See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373805080

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537 Fr

[SSSD] [sssd PR#533][comment] KCM's payload related patches

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches fidencio commented: """ There's one issue found on fedora-rawhide by our CI but doesn't seem to be related to this patch: ``` Traceback (most recent call last): File "/usr/bin/py.test", line 6, in from

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) jhrozek commented: """ One more minor update is needed, but we're getting there! """ See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373794127 ___

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ === FAILURES === __ test_sssctl_domain_list_app_domain

[SSSD] [sssd PR#537][+Changes requested] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-l

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ The failure is el6 specific. """ See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373793680 ___

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ I also would like to ask for help in this one as I didn't find an easy way to test it without having to call "sss_cache" to invalidate the entries. The reas

[SSSD] [sssd PR#538][+Pushed] NSS: Remove dead code

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/538 Title: #538: NSS: Remove dead code Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#538][-Accepted] NSS: Remove dead code

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/538 Title: #538: NSS: Remove dead code Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#538][closed] NSS: Remove dead code

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/538 Author: fidencio Title: #538: NSS: Remove dead code Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/538/head:pr538 git checkout pr538 ___

[SSSD] [sssd PR#538][comment] NSS: Remove dead code

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/538 Title: #538: NSS: Remove dead code fidencio commented: """ master: 718bce1 """ See the full comment at https://github.com/SSSD/sssd/pull/538#issuecomment-373742223 ___ sssd-devel mailing list -- sssd-devel@l

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/537#issuecomment-373740679 _

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537 Fr

[SSSD] [sssd PR#537][-Changes requested] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-l

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) fidencio commented: """ @jhrozek, thanks for the review. I didn't know a ldb_transaction_start() would be a no-op in case a transaction has already been started and that was the

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537 Fr

[SSSD] [sssd PR#537][synchronized] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/537 Author: fidencio Title: #537: confdb_expand_application_domains() related issues (round 1) Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/537/head:pr537 git checkout pr537 Fr

[SSSD] [sssd PR#533][comment] KCM's payload related patches

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches fidencio commented: """ I've updated the patch set and moved the allocation of the payload under kcm_req_ctx. I'm removing the "Changes Requested" label. """ See the full comment at https://github.com/SSSD/s

[SSSD] [sssd PR#533][-Changes requested] KCM's payload related patches

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#533][synchronized] KCM's payload related patches

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/533 Author: fidencio Title: #533: KCM's payload related patches Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/533/head:pr533 git checkout pr533 From a9fb7741a15cbb6e146a7a2e788b

[SSSD] [sssd PR#540][opened] Fix python3 issue in the integration test

2018-03-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/540 Author: sumit-bose Title: #540: Fix python3 issue in the integration test Action: opened PR body: """ With this patch the integration tests can run with python3. To test make sure $(PYTHON2) in src/tests/intg/Makefile.am is replaced with $(PYHTON3).

[SSSD] [sssd PR#515][-Changes requested] sssctl: Showing help even when sssd not configured

2018-03-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists

[SSSD] [sssd PR#537][+Changes requested] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-l

[SSSD] [sssd PR#537][comment] confdb_expand_application_domains() related issues (round 1)

2018-03-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/537 Title: #537: confdb_expand_application_domains() related issues (round 1) jhrozek commented: """ About the tests, I thought I submitted some, but looking at the tests, I guess it was only in the PAM responder tests.. """ See the full comment at https

[SSSD] [sssd PR#538][+Accepted] NSS: Remove dead code

2018-03-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/538 Title: #538: NSS: Remove dead code Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#539][comment] Make nss netgroup requests more robust

2018-03-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/539 Title: #539: Make nss netgroup requests more robust jhrozek commented: """ I think the patches make sense, I will just run the downstream tests before approving them. """ See the full comment at https://github.com/SSSD/sssd/pull/539#issuecomment-3736

[SSSD] [sssd PR#533][+Changes requested] KCM's payload related patches

2018-03-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#533][comment] KCM's payload related patches

2018-03-16 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/533 Title: #533: KCM's payload related patches jhrozek commented: """ In general, this PR is a good improvement, I just left some comments that might improve the readability of the code. """ See the full comment at https://github.com/SSSD/sssd/pull/533#i

[SSSD] [sssd PR#464][synchronized] SYSDB: Properly handle name/gid override when using domain resolution order

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Author: fidencio Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/464/head:pr464 git c

[SSSD] [sssd PR#464][comment] SYSDB: Properly handle name/gid override when using domain resolution order

2018-03-16 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/464 Title: #464: SYSDB: Properly handle name/gid override when using domain resolution order fidencio commented: """ Before I get back to this and spend some time fighting windmills ... I'd like to know: - Is the approach valid? Can someone make a review

[SSSD] Re: New sbus implementation

2018-03-16 Thread Jakub Hrozek
> On 14 Feb 2018, at 20:55, Jakub Hrozek wrote: > > On Sat, Feb 03, 2018 at 12:58:26PM +0100, Pavel Březina wrote: >> Hi team, >> as you know, I have been working on this occasionally for a long time now. >> The code can be found at [1]. >> >> It is completely new implementation of our interna

[SSSD] [sssd PR#535][comment] Backport of PR#525 and PR#534 to sssd-1-13

2018-03-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/535 Title: #535: Backport of PR#525 and PR#534 to sssd-1-13 sumit-bose commented: """ The latest update just fixes the cherry pick reference of the last patch. """ See the full comment at https://github.com/SSSD/sssd/pull/535#issuecomment-373643556 __

[SSSD] [sssd PR#535][synchronized] Backport of PR#525 and PR#534 to sssd-1-13

2018-03-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/535 Author: sumit-bose Title: #535: Backport of PR#525 and PR#534 to sssd-1-13 Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/535/head:pr535 git checkout pr535 From 8265a6c82d583

[SSSD] [sssd PR#536][synchronized] Backport of PR#525 and PR#534 to sssd-1-14

2018-03-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/536 Author: sumit-bose Title: #536: Backport of PR#525 and PR#534 to sssd-1-14 Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/536/head:pr536 git checkout pr536 From 9458d2abb4a20

[SSSD] [sssd PR#536][comment] Backport of PR#525 and PR#534 to sssd-1-14

2018-03-16 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/536 Title: #536: Backport of PR#525 and PR#534 to sssd-1-14 sumit-bose commented: """ The latest update just fixed the cherry pick reference of the last patch since the patch is now available in master. """ See the full comment at https://github.com/SSSD