[SSSD] [sssd PR#667][comment] WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno mzidek-rh commented: """ > I’m torn on this. On one hand, this would be nice to have a clean code, but > I’m a bit afraid that it would make backporting patches from sysdb code

[SSSD] [sssd PR#667][synchronized] WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread thalman
URL: https://github.com/SSSD/sssd/pull/667 Author: thalman Title: #667: WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/667/head:pr667 git checkout pr667 F

[SSSD] [sssd PR#667][comment] WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno jhrozek commented: """ > On 3 Oct 2018, at 13:23, mzidek-rh wrote: > > Hi, the patches look good and in general I have no problem accepting them > (when CI finishes). But I

[SSSD] [sssd PR#667][edited] WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread thalman
URL: https://github.com/SSSD/sssd/pull/667 Author: thalman Title: #667: WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno Action: edited Changed field: title Original value: """ UTIL: rename & cleanup sysdb_error_to_errno """ ___ sssd-

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread thalman
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno thalman commented: """ I will take a look at it and extend PR """ See the full comment at https://github.com/SSSD/sssd/pull/667#issuecomment-426631938 ___

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno jhrozek commented: """ btw this PR should also include another patch (I know it's not specified in the ticket, but it was actually the reason we created the ticket). There are several calls to L

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno mzidek-rh commented: """ Hi, the patches look good and in general I have no problem accepting them (when CI finishes). But I would like to see follow up pull request that these two things: - cre

[SSSD] [sssd PR#667][opened] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread thalman
URL: https://github.com/SSSD/sssd/pull/667 Author: thalman Title: #667: UTIL: rename & cleanup sysdb_error_to_errno Action: opened PR body: """ * UTIL: move and rename sysdb_error_to_errno to utils * UTIL: Use new ldb_error_to_errno function in code """ To pull the PR as Git branch: git remot

[SSSD] [sssd PR#667][comment] UTIL: rename & cleanup sysdb_error_to_errno

2018-10-03 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/667 Title: #667: UTIL: rename & cleanup sysdb_error_to_errno centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/667#issuecomment-426596474 ___

[SSSD] [sssd PR#650][comment] Implement a hybrid mode of generating private groups

2018-10-03 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups mzidek-rh commented: """ I pushed the rebased patches to CI. """ See the full comment at https://github.com/SSSD/sssd/pull/650#issuecomment-426594956 _

[SSSD] [sssd PR#665][comment] p11: handle multiple certs during auth with OpenSSL

2018-10-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/665 Title: #665: p11: handle multiple certs during auth with OpenSSL sumit-bose commented: """ > Just for my education, how does this work together with > ah, sorry, I should have copied the related comment from the NSS code as well. The latest version h

[SSSD] [sssd PR#665][synchronized] p11: handle multiple certs during auth with OpenSSL

2018-10-03 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/665 Author: sumit-bose Title: #665: p11: handle multiple certs during auth with OpenSSL Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/665/head:pr665 git checkout pr665 From 1e76

[SSSD] [sssd PR#657][comment] be: use be_is_offline for the main domain when asking for domain status

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status jhrozek commented: """ * master: dfa7bf1133f002a9fbbd3495a70909913db25b16 """ See the full comment at https://github.com/SSSD/sssd/pull/657#issuecomment-426572354 __

[SSSD] [sssd PR#657][+Pushed] be: use be_is_offline for the main domain when asking for domain status

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/657 Title: #657: be: use be_is_offline for the main domain when asking for domain status Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-

[SSSD] [sssd PR#657][closed] be: use be_is_offline for the main domain when asking for domain status

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/657 Author: pbrezina Title: #657: be: use be_is_offline for the main domain when asking for domain status Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/657/head:pr657 git checkout pr

[SSSD] [sssd PR#663][comment] confdb: log an error when domain is misconfigured

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/663 Title: #663: confdb: log an error when domain is misconfigured jhrozek commented: """ * master: 081b18e75c746f9a2ad1fb412c825293090311f8 """ See the full comment at https://github.com/SSSD/sssd/pull/663#issuecomment-426570987 _

[SSSD] [sssd PR#663][closed] confdb: log an error when domain is misconfigured

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/663 Author: thalman Title: #663: confdb: log an error when domain is misconfigured Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/663/head:pr663 git checkout pr663

[SSSD] [sssd PR#663][+Pushed] confdb: log an error when domain is misconfigured

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/663 Title: #663: confdb: log an error when domain is misconfigured Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#664][+Pushed] pep8: Ignore W504 and W605 to silence warnings on Debian

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedo

[SSSD] [sssd PR#664][closed] pep8: Ignore W504 and W605 to silence warnings on Debian

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/664 Author: jhrozek Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/664/head:pr664 git checkout pr664 _

[SSSD] [sssd PR#664][comment] pep8: Ignore W504 and W605 to silence warnings on Debian

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/664 Title: #664: pep8: Ignore W504 and W605 to silence warnings on Debian jhrozek commented: """ * master:ec7665973936897ab6be58308e655f08d91bec5c * sssd-1-16: bca1935761a8ac21a45abcda9f82feec259dc65c """ See the full comment at https://github.com/SSSD/ss

[SSSD] [sssd PR#666][+Pushed] ci: add http-parser-devel for Fedora

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/666 Title: #666: ci: add http-parser-devel for Fedora Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora

[SSSD] [sssd PR#666][closed] ci: add http-parser-devel for Fedora

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/666 Author: sumit-bose Title: #666: ci: add http-parser-devel for Fedora Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/666/head:pr666 git checkout pr666 __

[SSSD] [sssd PR#666][comment] ci: add http-parser-devel for Fedora

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/666 Title: #666: ci: add http-parser-devel for Fedora jhrozek commented: """ * master: e18c67c38a3f645549ebd5117b49a4d3e1c94018 """ See the full comment at https://github.com/SSSD/sssd/pull/666#issuecomment-426569919 __

[SSSD] [sssd PR#650][comment] Implement a hybrid mode of generating private groups

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups jhrozek commented: """ Thank you, the fixups were squashed """ See the full comment at https://github.com/SSSD/sssd/pull/650#issuecomment-426568647 _

[SSSD] [sssd PR#650][synchronized] Implement a hybrid mode of generating private groups

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Author: jhrozek Title: #650: Implement a hybrid mode of generating private groups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/650/head:pr650 git checkout pr650 From 6fb4da

[SSSD] [sssd PR#650][-Changes requested] Implement a hybrid mode of generating private groups

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Title: #650: Implement a hybrid mode of generating private groups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lis

[SSSD] [sssd PR#650][synchronized] Implement a hybrid mode of generating private groups

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/650 Author: jhrozek Title: #650: Implement a hybrid mode of generating private groups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/650/head:pr650 git checkout pr650 From 6fb4da

[SSSD] [sssd PR#662][+Changes requested] doc: Add nsswitch.conf note to manpage

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/662 Title: #662: doc: Add nsswitch.conf note to manpage Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste

[SSSD] [sssd PR#663][+Accepted] confdb: log an error when domain is misconfigured

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/663 Title: #663: confdb: log an error when domain is misconfigured Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahos

[SSSD] [sssd PR#665][comment] p11: handle multiple certs during auth with OpenSSL

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/665 Title: #665: p11: handle multiple certs during auth with OpenSSL jhrozek commented: """ Just for my education, how does this work together with https://github.com/SSSD/sssd/blob/4ff183ecbe4d8e70715eee186f1fedecc335163e/src/p11_child/p11_child_openssl.c

[SSSD] [sssd PR#665][comment] p11: handle multiple certs during auth with OpenSSL

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/665 Title: #665: p11: handle multiple certs during auth with OpenSSL jhrozek commented: """ Just for my education, how does this work together with https://github.com/SSSD/sssd/blob/4ff183ecbe4d8e70715eee186f1fedecc335163e/src/p11_child/p11_child_openssl.c

[SSSD] [sssd PR#666][+Accepted] ci: add http-parser-devel for Fedora

2018-10-03 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/666 Title: #666: ci: add http-parser-devel for Fedora Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedor