URL: https://github.com/SSSD/sssd/pull/667 Title: #667: WIP, do not merge, UTIL: rename & cleanup sysdb_error_to_errno
jhrozek commented: """ > On 3 Oct 2018, at 13:23, mzidek-rh <notificati...@github.com> wrote: > > Hi, the patches look good and in general I have no problem accepting them > (when CI finishes). But I would like to see follow up pull request that these > two things: > > • create one patch for every file that uses sysdb_error_to_errno to use > the new function (or alternatively one big patch for all files) I’m torn on this. On one hand, this would be nice to have a clean code, but I’m a bit afraid that it would make backporting patches from sysdb code to 1.16 harder later and create conflicts. But since the sysdb code is relatively stable, it might be good to do this actually. > • as last patch, remove the sysdb_error_to_errno alias (the sysdb_* > prefix is just obfuscating IMO and we should not use in new code) > Or you can do the above in this PR as well (up to you). If you do not plan to > do the follow up PR soon then please make a ticket so that we track it for > later. > > Let me know how you prefer to proceed. > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub, or mute the thread. > """ See the full comment at https://github.com/SSSD/sssd/pull/667#issuecomment-426644386
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
