URL: https://github.com/SSSD/sssd/pull/907
Title: #907: Update README.md
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct:
URL: https://github.com/SSSD/sssd/pull/907
Title: #907: Update README.md
mzidek-rh commented:
"""
ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/907#issuecomment-543795901
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache
alexey-tikhonov commented:
"""
ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/906#issuecomment-543786192
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache
mzidek-rh commented:
"""
(1) man/sssd.8.xml: " ... client applications will not use the fast in memory
cache."
This one is ok. The fast in-memory cache is what memcache is, so it is
URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache
mzidek-rh commented:
"""
(1) man/sssd.8.xml: " ... client applications will not use the fast in memory
cache."
This one is ok. The fast in-memory cache is what memcache is, so it is
URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
Title: #906: memcache: Stop using the word fastcache for memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/906/head:pr906
git checkout pr906
From
URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially
mzidek-rh commented:
"""
Thanks @frozencemetery for your input.
ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/904#issuecomment-543783226
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
sumit-bose commented:
"""
Hi Alexey,
thanks for adding the comment. ACK.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/883#issuecomment-543780844
URL: https://github.com/SSSD/sssd/pull/904
Title: #904: KCM: Set kdc_offset to zero initially
frozencemetery commented:
"""
Thanks for your patience while I was PTO.
In the abstract, I think that 0 makes a lot more sense as an "unset" value than
INT32_MAX :) rhbz#1757224 was exposed because
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache
alexey-tikhonov commented:
"""
Hi @mzidek-rh,
> I think we should really stick to calling it memcache in
> the documentation and debug messages
Does
(1) man/sssd.8.xml: " ... client
URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
Title: #906: memcache: Stop using the word fastcache for memcache
Action: edited
Changed field: body
Original value:
"""
This patch removes the word fastche from our codebase.
We do not reffer to the fast in-memory mmaped cache
URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache
mzidek-rh commented:
"""
Fixed some spelling errors in the commit message as per Alexey's feedback.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
Title: #906: memcache: Stop using the word fastcache for memcache
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/906/head:pr906
git checkout pr906
From
URL: https://github.com/SSSD/sssd/pull/899
Title: #899: sss_ptr_hash: pass new hash_entry_t to custom delete callback
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/899
Title: #899: sss_ptr_hash: pass new hash_entry_t to custom delete callback
mzidek-rh commented:
"""
Hmm... not sure, but maybe I was trying to reproduce it with the patches
already applied :/ Sorry.
In any case, I could reproduce it with master and
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/883#issuecomment-543729809
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/883#issuecomment-543729809
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
alexey-tikhonov commented:
"""
Hi,
> I only have a minor nitpick about ` static char buff[512];`. The `512` comes
> a bit out of the blue and one might ask why not 256 or 1024? I'd like to ask
> you to
URL: https://github.com/SSSD/sssd/pull/907
Title: #907: Update README.md
alexey-tikhonov commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/907#issuecomment-543727996
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/907
Author: alexal
Title: #907: Update README.md
Action: opened
PR body:
"""
A few changes in README.md file:
1. Google+ is no longer available for consumer (personal) and brand accounts.
I've removed the link to Google+ page as that link is no longer
URL: https://github.com/SSSD/sssd/pull/907
Title: #907: Update README.md
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/907#issuecomment-543726894
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/883#issuecomment-543714317
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/883
Title: #883: Minor fixes to util/sss_krb5
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/883#issuecomment-543714317
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/883
Author: alexey-tikhonov
Title: #883: Minor fixes to util/sss_krb5
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/883/head:pr883
git checkout pr883
From
URL: https://github.com/SSSD/sssd/pull/883
Author: alexey-tikhonov
Title: #883: Minor fixes to util/sss_krb5
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/883/head:pr883
git checkout pr883
From
URL: https://github.com/SSSD/sssd/pull/899
Title: #899: sss_ptr_hash: pass new hash_entry_t to custom delete callback
pbrezina commented:
"""
This works evertime:
```
# rm -f /var/log/sssd/* && systemctl start sssd && sleep 5 && systemctl stop
sssd && grep "Invalid data type detected"
URL: https://github.com/SSSD/sssd/pull/899
Title: #899: sss_ptr_hash: pass new hash_entry_t to custom delete callback
pbrezina commented:
"""
This works evertime:
```bash
# rm -f /var/log/sssd/* && systemctl start sssd && sleep 5 && systemctl stop
sssd && grep "Invalid data type detected"
URL: https://github.com/SSSD/sssd/pull/899
Title: #899: sss_ptr_hash: pass new hash_entry_t to custom delete callback
pbrezina commented:
"""
This works evertime:
```
# rm -f /var/log/sssd/* && systemctl start sssd && sleep 5 && systemctl stop
sssd && grep "Invalid data type detected"
URL: https://github.com/SSSD/sssd/pull/906
Title: #906: memcache: Stop using the word fastcache for memcache
mzidek-rh commented:
"""
This is a simple fix, but I think we should not have multiple ways to call one
thing in our debug logs and documentation. And thankfully we do not use
URL: https://github.com/SSSD/sssd/pull/906
Author: mzidek-rh
Title: #906: memcache: Stop using the word fastcache for memcache
Action: opened
PR body:
"""
This patch removes the word fastche from our codebase.
We do not reffer to the fast in-memory mmaped cache consistantly.
Sometimes we
URL: https://github.com/SSSD/sssd/pull/903
Title: #903: Gpo man page updates
sumit-bose commented:
"""
Thanks, I'm fine with the second patch and since you are already reviewed the
first, ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/903#issuecomment-543676945
URL: https://github.com/SSSD/sssd/pull/903
Title: #903: Gpo man page updates
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: WIP: Don't ignore host entries in Group Policy security filters
abbra commented:
"""
Few observations:
- we already have code to translate between string/structure for SIDs, why
there is a need for another one?
- may be you can simplify
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: WIP: Don't ignore host entries in Group Policy security filters
sumit-bose commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/905#issuecomment-543549922
___
40 matches
Mail list logo
