URL: https://github.com/SSSD/sssd/pull/5760
Author: dpward
Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card()
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5760/head:pr5760
git checkout pr5760
From 47bf9
URL: https://github.com/SSSD/sssd/pull/5760
Author: dpward
Title: #5760: p11_child: Fixes for init_p11_ctx() and do_card()
Action: opened
PR body:
"""
This restores the previous behavior of `--wait_for_card`, and fixes issues with
initialization and cleanup.
"""
To pull the PR as Git branch:
URL: https://github.com/SSSD/sssd/pull/5746
Title: #5746: p11_child: do_card partially fix loop exit condition (redo of
#5705)
dpward commented:
"""
@sumit-bose I don't think a simple patch can fix this. I think some
re-factoring of `do_card()` and `wait_for_card()` is what is really needed
h
URL: https://github.com/SSSD/sssd/pull/5758
Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
elkoniu commented:
"""
> @elkoniu, do you have other comments?
Code LGTM so I set Accepted flag. The only question I would have is that
`remove_tree_with_ctx()` result is not evalua
URL: https://github.com/SSSD/sssd/pull/5758
Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fe
URL: https://github.com/SSSD/sssd/pull/5758
Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
alexey-tikhonov commented:
"""
@elkoniu, do you have other comments?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5758#issuecomment-904910413
__
URL: https://github.com/SSSD/sssd/pull/5740
Title: #5740: Test: Fix RHEL9.0 Regression - alltests-tier1
alexey-tikhonov commented:
"""
Is this really way to go?
I mean, of course it's easy to enable files provider explicitly to keep
existing tests working.
But that's not default on RHEL9...
"
URL: https://github.com/SSSD/sssd/pull/5740
Title: #5740: Test: Fix RHEL9.0 Regression - alltests-tier1
alexey-tikhonov commented:
"""
Is this really way to go?
I mean, of course it's easy to enabled files provider explicitly to keep
existing tests working.
But that's not default on RHEL9...
URL: https://github.com/SSSD/sssd/pull/5740
Title: #5740: Test: Fix RHEL9.0 Regression - alltests-tier1
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahoste
URL: https://github.com/SSSD/sssd/pull/5750
Title: #5750: fix compilation warnings
Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedor
URL: https://github.com/SSSD/sssd/pull/5750
Title: #5750: fix compilation warnings
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of
URL: https://github.com/SSSD/sssd/pull/5750
Title: #5750: fix compilation warnings
alexey-tikhonov commented:
"""
Thank you, ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5750#issuecomment-904585632
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/5750
Title: #5750: fix compilation warnings
pbrezina commented:
"""
See new patch. Diff:
https://github.com/SSSD/sssd/compare/1944174d47711a26b2a8c3e6024b4fc056d5db0d..922cfbf4bf8a9d3aa9581bf034b044f2aa035ea7
"""
See the full comment at
https://github.co
URL: https://github.com/SSSD/sssd/pull/5750
Author: pbrezina
Title: #5750: fix compilation warnings
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5750/head:pr5750
git checkout pr5750
From e284006aebdc8f0163b28969a958
URL: https://github.com/SSSD/sssd/pull/5750
Title: #5750: fix compilation warnings
alexey-tikhonov commented:
"""
About 2nd patch: can we increase log level in `DEBUG(SSSDBG_TRACE_ALL,
"sss_getenv() failed\n");` in `sysdb_ldb_connect()`?
Users of this function don't quote fail reason: it's just
URL: https://github.com/SSSD/sssd/pull/5750
Title: #5750: fix compilation warnings
alexey-tikhonov commented:
"""
About 2nd patch: can we increase log level in `DEBUG(SSSDBG_TRACE_ALL,
"sss_getenv() failed\n");` in `sysdb_ldb_connect()`? Otherwise patch looks good
to me.
(I know this is origi
URL: https://github.com/SSSD/sssd/pull/5750
Title: #5750: fix compilation warnings
alexey-tikhonov commented:
"""
About 2nd patch: can we increase log level in `DEBUG(SSSDBG_TRACE_ALL,
"sss_getenv() failed\n");` in `sysdb_ldb_connect()`? Otherwise patch looks good
to me.
"""
See the full comm
URL: https://github.com/SSSD/sssd/pull/5758
Title: #5758: file utils: reduce log level in remove_tree_with_ctx()
Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le..
URL: https://github.com/SSSD/sssd/pull/5750
Title: #5750: fix compilation warnings
alexey-tikhonov commented:
"""
About 1st patch: frankly, I think use of `_DEPRECATED_` keyword in libtalloc
header is unjustified.
But since the patch just implements/copies (simplified) original libtalloc code
URL: https://github.com/SSSD/sssd/pull/5757
Title: #5757: CI: unset DEBUGINFOD_URLS
pbrezina commented:
"""
We need to update the box since f35 branched of rawhide.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5757#issuecomment-904443492
___
URL: https://github.com/SSSD/sssd/pull/5746
Title: #5746: p11_child: do_card partially fix loop exit condition (redo of
#5705)
sumit-bose commented:
"""
Hi,
thanks for the hint, I have to admit that I didn't test the patch with
`wait_for_card`.
@assafmo, would you like to add a patch that fi
21 matches
Mail list logo
