Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-02-05 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2010 08:49 AM, Jakub Hrozek wrote: > On 02/05/2010 02:18 PM, Stephen Gallagher wrote: >> New patch attached. > > ACK Pushed to master. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-02-05 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2010 02:18 PM, Stephen Gallagher wrote: > New patch attached. ACK -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAktsIdwACgkQHsardTLnvCVm5wCgj16EBL4

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-02-05 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/05/2010 08:12 AM, Jakub Hrozek wrote: >> I made chpass_provider and access_provider optional > > The only glitch I found was that in order for the unittests to keep > working, you also need to remove chpass_provider and access_provider > from S

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-02-05 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/04/2010 09:20 PM, Stephen Gallagher wrote: > On 01/11/2010 09:58 AM, Jakub Hrozek wrote: >> On 01/07/2010 05:54 PM, Stephen Gallagher wrote: >>> Address https://fedorahosted.org/sssd/ticket/349 > > >>> After a bit of thought, I decided to break

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-02-04 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/2010 09:58 AM, Jakub Hrozek wrote: > On 01/07/2010 05:54 PM, Stephen Gallagher wrote: >> Address https://fedorahosted.org/sssd/ticket/349 > > >> After a bit of thought, I decided to break this into two separate >> patches to make it more cle

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-01-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/2010 10:07 AM, Tomas Mraz wrote: > On Thu, 2010-01-07 at 11:54 -0500, Stephen Gallagher wrote: >> Address https://fedorahosted.org/sssd/ticket/349 >> >> >> After a bit of thought, I decided to break this into two separate >> patches to make i

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-01-11 Thread Tomas Mraz
On Thu, 2010-01-07 at 11:54 -0500, Stephen Gallagher wrote: > Address https://fedorahosted.org/sssd/ticket/349 > > > After a bit of thought, I decided to break this into two separate > patches to make it more clear. New patches attached. > > Patch 0002: Remove the explicit defaults where they'r

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-01-11 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/11/2010 09:58 AM, Jakub Hrozek wrote: > On 01/07/2010 05:54 PM, Stephen Gallagher wrote: >> Address https://fedorahosted.org/sssd/ticket/349 > > >> After a bit of thought, I decided to break this into two separate >> patches to make it more cle

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-01-11 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/07/2010 05:54 PM, Stephen Gallagher wrote: > Address https://fedorahosted.org/sssd/ticket/349 > > > After a bit of thought, I decided to break this into two separate > patches to make it more clear. New patches attached. > > Patch 0002: Remove

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-01-07 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/05/2010 11:11 AM, Jakub Hrozek wrote: > On 01/04/2010 07:31 PM, Stephen Gallagher wrote: >> Also add list_mandatory_options() to both SSSDService and >> SSSDDomain objects. > >> There is a new list_options_with_mandatory() function that will >>

Re: [SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-01-05 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/04/2010 07:31 PM, Stephen Gallagher wrote: > Also add list_mandatory_options() to both SSSDService and > SSSDDomain objects. > > There is a new list_options_with_mandatory() function that will > return a longer tuple than list_options(), includi

[SSSD] [PATCH] Add mandatory flag to SSSD config schema

2010-01-04 Thread Stephen Gallagher
Also add list_mandatory_options() to both SSSDService and SSSDDomain objects. There is a new list_options_with_mandatory() function that will return a longer tuple than list_options(), including the mandatory flag directly. list_options() will still return the shorter tuple, for backwards-compati