Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-15 Thread Jakub Hrozek
On Wed, Aug 15, 2012 at 05:04:23PM +0200, Jakub Hrozek wrote: > On Wed, Aug 15, 2012 at 04:17:21PM +0200, Pavel Březina wrote: > > On 08/15/2012 03:56 PM, Jakub Hrozek wrote: > > >On Tue, Aug 14, 2012 at 01:38:15PM +0200, Pavel Březina wrote: > > >>On 08/13/2012 11:42 AM, Jakub Hrozek wrote: > > >>

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-15 Thread Stephen Gallagher
On Wed, 2012-08-15 at 15:56 +0200, Jakub Hrozek wrote: > > I wouldn't expect tevent_req_post to be called in any other function > that *_send. Also checking the SSSD code shows that we only call > tevent_req_post from *_send elsewhere. This is a mandatory part of the tevent_req style. tevent_req_

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-15 Thread Jakub Hrozek
On Wed, Aug 15, 2012 at 04:17:21PM +0200, Pavel Březina wrote: > On 08/15/2012 03:56 PM, Jakub Hrozek wrote: > >On Tue, Aug 14, 2012 at 01:38:15PM +0200, Pavel Březina wrote: > >>On 08/13/2012 11:42 AM, Jakub Hrozek wrote: > >>>On Mon, Aug 13, 2012 at 11:10:36AM +0200, Jakub Hrozek wrote: > On

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-15 Thread Pavel Březina
On 08/15/2012 03:56 PM, Jakub Hrozek wrote: On Tue, Aug 14, 2012 at 01:38:15PM +0200, Pavel Březina wrote: On 08/13/2012 11:42 AM, Jakub Hrozek wrote: On Mon, Aug 13, 2012 at 11:10:36AM +0200, Jakub Hrozek wrote: On Fri, Aug 10, 2012 at 09:26:49AM +0200, Pavel Březina wrote: On 08/08/2012 04:

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-15 Thread Jakub Hrozek
On Tue, Aug 14, 2012 at 01:38:15PM +0200, Pavel Březina wrote: > On 08/13/2012 11:42 AM, Jakub Hrozek wrote: > >On Mon, Aug 13, 2012 at 11:10:36AM +0200, Jakub Hrozek wrote: > >>On Fri, Aug 10, 2012 at 09:26:49AM +0200, Pavel Březina wrote: > >>>On 08/08/2012 04:24 PM, Jakub Hrozek wrote: > On

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-14 Thread Pavel Březina
On 08/13/2012 11:42 AM, Jakub Hrozek wrote: On Mon, Aug 13, 2012 at 11:10:36AM +0200, Jakub Hrozek wrote: On Fri, Aug 10, 2012 at 09:26:49AM +0200, Pavel Březina wrote: On 08/08/2012 04:24 PM, Jakub Hrozek wrote: On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote: This bug was prob

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-13 Thread Jakub Hrozek
On Mon, Aug 13, 2012 at 11:10:36AM +0200, Jakub Hrozek wrote: > On Fri, Aug 10, 2012 at 09:26:49AM +0200, Pavel Březina wrote: > > On 08/08/2012 04:24 PM, Jakub Hrozek wrote: > > >On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote: > > >>This bug was probably introduced with the subdomai

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-13 Thread Jakub Hrozek
On Fri, Aug 10, 2012 at 09:26:49AM +0200, Pavel Březina wrote: > On 08/08/2012 04:24 PM, Jakub Hrozek wrote: > >On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote: > >>This bug was probably introduced with the subdomain patches. The > >>problem was that sss_dp_get_domains_send() is calle

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-10 Thread Pavel Březina
On 08/08/2012 04:24 PM, Jakub Hrozek wrote: On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote: This bug was probably introduced with the subdomain patches. The problem was that sss_dp_get_domains_send() is called even for the local provider. There are certainly many possible solution

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-09 Thread Jakub Hrozek
On Thu, Aug 09, 2012 at 09:40:36AM +0200, Pavel Březina wrote: > On 08/08/2012 04:36 PM, Stephen Gallagher wrote: > >On Wed, 2012-08-08 at 16:24 +0200, Jakub Hrozek wrote: > >>On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote: > >>>This bug was probably introduced with the subdomain pat

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-09 Thread Pavel Březina
On 08/08/2012 04:36 PM, Stephen Gallagher wrote: On Wed, 2012-08-08 at 16:24 +0200, Jakub Hrozek wrote: On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote: This bug was probably introduced with the subdomain patches. The problem was that sss_dp_get_domains_send() is called even for t

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-08 Thread Stephen Gallagher
On Wed, 2012-08-08 at 16:24 +0200, Jakub Hrozek wrote: > On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote: > > This bug was probably introduced with the subdomain patches. The > > problem was that sss_dp_get_domains_send() is called even for the local > > provider. There are certainly

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-08 Thread Jakub Hrozek
On Wed, Aug 08, 2012 at 04:24:47PM +0200, Jakub Hrozek wrote: > 2) The work we'll be doing later on #1126 would merge all the loops > into one common place. There is a WIP code for the merge in the "refactor" branch in my fedorapeople.org repository. I started working on it earlier and the

Re: [SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-08 Thread Jakub Hrozek
On Wed, Aug 08, 2012 at 02:23:04PM +0200, Pavel Březina wrote: > This bug was probably introduced with the subdomain patches. The > problem was that sss_dp_get_domains_send() is called even for the local > provider. There are certainly many possible solutions of this issue. I > decided to modify ss

[SSSD] [PATCH] Fix LOCAL domain lookups

2012-08-08 Thread Pavel Březina
This bug was probably introduced with the subdomain patches. The problem was that sss_dp_get_domains_send() is called even for the local provider. There are certainly many possible solutions of this issue. I decided to modify sss_dp_issue_request() to call the callback immediately if it is issued