Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/03/2010 07:42 AM, Stephen Gallagher wrote: On 09/03/2010 07:39 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote: On 09/01/2010 05:56 AM, Jan Zelený wrote: Both your points are valid. I'm attaching a patch where the check is

Re: [SSSD] [PATCH] Minor fixes in various places

Stephen Gallagher sgall...@redhat.com wrote: On 09/01/2010 05:56 AM, Jan Zelený wrote: Both your points are valid. I'm attaching a patch where the check is performed. I still think it is redundant, but it might be more safe in the future in case the code around it changes. Nack. This

Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/03/2010 07:39 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote: On 09/01/2010 05:56 AM, Jan Zelený wrote: Both your points are valid. I'm attaching a patch where the check is performed. I still think it is redundant, but it

Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/01/2010 05:56 AM, Jan Zelený wrote: Both your points are valid. I'm attaching a patch where the check is performed. I still think it is redundant, but it might be more safe in the future in case the code around it changes. Nack. This

Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2010 07:56 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote: On 08/31/2010 07:39 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote: 0003-Fixed-printing-of-undefined-value-in-sdap_async_acco.patch Ticket:

Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/02/2010 12:18 PM, Stephen Gallagher wrote: On 08/31/2010 07:56 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote: On 08/31/2010 07:39 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote:

Re: [SSSD] [PATCH] Minor fixes in various places

Stephen Gallagher sgall...@redhat.com wrote: On 08/31/2010 07:57 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote: 0005-Deleted-some-needless-assignments.patch Ticket: #582 I think we should check for potential errors from sdap_id_op_done() calls instead of removing

[SSSD] [PATCH] Minor fixes in various places

I'm attaching some patches fixing various minor issues found by clang: 0001-Initialized-return-value-in-dp_copy_options.patch Ticket: #577 0002-Fixed-potential-comparison-of-undefined-variable.patch Ticket: #578 0003-Fixed-printing-of-undefined-value-in-sdap_async_acco.patch Ticket: #579

Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2010 09:59 AM, Jan Zelený wrote: I'm attaching some patches fixing various minor issues found by clang: 0001-Initialized-return-value-in-dp_copy_options.patch Ticket: #577 ACK

Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2010 05:41 AM, Jakub Hrozek wrote: On 08/31/2010 09:59 AM, Jan Zelený wrote: I'm attaching some patches fixing various minor issues found by clang: 0001-Initialized-return-value-in-dp_copy_options.patch Ticket: #577 ACK

Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2010 01:11 PM, Stephen Gallagher wrote: 0004-Fixed-uninialized-value-in-proxy_id-provider.patch Ticket: #580 I guess NSS_STATUS_UNAVAIL is as good as any of the others in this case, so ACK I don't understand this comment,

Re: [SSSD] [PATCH] Minor fixes in various places

Stephen Gallagher sgall...@redhat.com wrote: 0003-Fixed-printing-of-undefined-value-in-sdap_async_acco.patch Ticket: #579 Provided that it is safe to pass a NULL pointer to fprintf(), this is OK. I know that glibc handles this, but I'm not entirely sure if that it is good behaviour

Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2010 07:39 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote: 0003-Fixed-printing-of-undefined-value-in-sdap_async_acco.patch Ticket: #579 Provided that it is safe to pass a NULL pointer to fprintf(), this is OK. I know

Re: [SSSD] [PATCH] Minor fixes in various places

Stephen Gallagher sgall...@redhat.com wrote: On 08/31/2010 07:39 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote: 0003-Fixed-printing-of-undefined-value-in-sdap_async_acco.patch Ticket: #579 Provided that it is safe to pass a NULL pointer to fprintf(), this is OK. I

Re: [SSSD] [PATCH] Minor fixes in various places

Stephen Gallagher sgall...@redhat.com wrote: 0005-Deleted-some-needless-assignments.patch Ticket: #582 I think we should check for potential errors from sdap_id_op_done() calls instead of removing the assignments altogether. I agree with Jakub. These assignments shouldn't be removed,

Re: [SSSD] [PATCH] Minor fixes in various places

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/31/2010 07:57 AM, Jan Zelený wrote: Stephen Gallagher sgall...@redhat.com wrote: 0005-Deleted-some-needless-assignments.patch Ticket: #582 I think we should check for potential errors from sdap_id_op_done() calls instead of removing the

Re: [SSSD] [PATCH] Minor fixes

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/14/2009 01:42 PM, Stephen Gallagher wrote: On 12/11/2009 10:38 AM, Sumit Bose wrote: Hi, 0001: I got an error with older python version when just calling exit(). 'TypeError: 'str' object is not callable' Ack. Good catch. Pushed

Re: [SSSD] [PATCH] Minor fixes

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/11/2009 10:38 AM, Sumit Bose wrote: Hi, 0001: I got an error with older python version when just calling exit(). 'TypeError: 'str' object is not callable' Ack. Good catch. 0002: make check failed when using the tar ball, because

[SSSD] [PATCH] Minor fixes

Hi, 0001: I got an error with older python version when just calling exit(). 'TypeError: 'str' object is not callable' 0002: make check failed when using the tar ball, because elapi_ut.conf was missing 0003: Older versions of check do not have test loops. bye, Sumit From