Re: [SSSD] [PATCH] Wrong paramater to sysdb_attrs_add_uint32

2011-08-01 Thread Stephen Gallagher
On Fri, 2011-07-29 at 08:50 +0200, Jakub Hrozek wrote: > On 07/28/2011 06:32 PM, Stephen Gallagher wrote: > > On Thu, 2011-07-28 at 17:56 +0200, Jakub Hrozek wrote: > >> While reviewing Jan's sysdb patches I noticed that a call to > >> sysdb_attrs_add_uint32() I added recently is wrong. > >> > >> T

Re: [SSSD] [PATCH] Wrong paramater to sysdb_attrs_add_uint32

2011-07-28 Thread Jakub Hrozek
On 07/28/2011 06:32 PM, Stephen Gallagher wrote: > On Thu, 2011-07-28 at 17:56 +0200, Jakub Hrozek wrote: >> While reviewing Jan's sysdb patches I noticed that a call to >> sysdb_attrs_add_uint32() I added recently is wrong. >> >> The reason the code worked and the compiler did not complain was sim

Re: [SSSD] [PATCH] Wrong paramater to sysdb_attrs_add_uint32

2011-07-28 Thread Stephen Gallagher
On Thu, 2011-07-28 at 17:56 +0200, Jakub Hrozek wrote: > While reviewing Jan's sysdb patches I noticed that a call to > sysdb_attrs_add_uint32() I added recently is wrong. > > The reason the code worked and the compiler did not complain was simple > - there's only one place that calls sdap_store_g

[SSSD] [PATCH] Wrong paramater to sysdb_attrs_add_uint32

2011-07-28 Thread Jakub Hrozek
While reviewing Jan's sysdb patches I noticed that a call to sysdb_attrs_add_uint32() I added recently is wrong. The reason the code worked and the compiler did not complain was simple - there's only one place that calls sdap_store_group_with_gid() and it passes group_attrs for mem_ctx. If we ever