Re: [SSSD] [PATCH] mmap_cache: Check if slot and name_ptr are not invalid.

2013-08-11 Thread Jakub Hrozek
On Sun, Aug 11, 2013 at 07:35:48PM +0200, Jakub Hrozek wrote: > On Wed, Aug 07, 2013 at 06:38:47PM +0200, Michal Židek wrote: > > On 08/05/2013 09:30 PM, Simo Sorce wrote: > > > On Mon, 2013-08-05 at 21:13 +0200, Michal Židek wrote: > > >> This is very ugly hotfix for ticket: > > >> https://fedora

Re: [SSSD] [PATCH] mmap_cache: Check if slot and name_ptr are not invalid.

2013-08-11 Thread Jakub Hrozek
On Wed, Aug 07, 2013 at 06:38:47PM +0200, Michal Židek wrote: > On 08/05/2013 09:30 PM, Simo Sorce wrote: > > On Mon, 2013-08-05 at 21:13 +0200, Michal Židek wrote: > >> This is very ugly hotfix for ticket: > >> https://fedorahosted.org/sssd/ticket/2018 > >> > >> So far we were not able to find ou

Re: [SSSD] [PATCH] mmap_cache: Check if slot and name_ptr are not invalid.

2013-08-07 Thread Michal Židek
On 08/05/2013 09:30 PM, Simo Sorce wrote: > On Mon, 2013-08-05 at 21:13 +0200, Michal Židek wrote: >> This is very ugly hotfix for ticket: >> https://fedorahosted.org/sssd/ticket/2018 >> >> So far we were not able to find out why the slot or name_ptr >> values were corrupted, but this should at l

Re: [SSSD] [PATCH] mmap_cache: Check if slot and name_ptr are not invalid.

2013-08-05 Thread Jakub Hrozek
On Mon, Aug 05, 2013 at 03:30:43PM -0400, Simo Sorce wrote: > Optional (may be should be a separate ticket) > We currently reinit by closing the file and creating a new one. We > should not do that, we should rather reset the header and then just zero > all the data and reinitialize all the various

Re: [SSSD] [PATCH] mmap_cache: Check if slot and name_ptr are not invalid.

2013-08-05 Thread Simo Sorce
On Mon, 2013-08-05 at 21:13 +0200, Michal Židek wrote: > This is very ugly hotfix for ticket: > https://fedorahosted.org/sssd/ticket/2018 > > So far we were not able to find out why the slot or name_ptr > values were corrupted, but this should at least prevent segfaults. NACK, (but close) Please

[SSSD] [PATCH] mmap_cache: Check if slot and name_ptr are not invalid.

2013-08-05 Thread Michal Židek
This is very ugly hotfix for ticket: https://fedorahosted.org/sssd/ticket/2018 So far we were not able to find out why the slot or name_ptr values were corrupted, but this should at least prevent segfaults. Comments are highly appreciated. Thanks Michal >From 6c376710b0dd09fc75d65eba68f22facb31