Re: [SSSD] [PATCH 1/1] LDAP: Better debug logging when saving groups

2012-11-01 Thread Jakub Hrozek
On Wed, Oct 31, 2012 at 03:10:12PM -0400, Simo Sorce wrote: > On Wed, 2012-10-31 at 14:36 -0400, Stephen Gallagher wrote: > > On Wed 31 Oct 2012 02:16:02 PM EDT, Simo Sorce wrote: > > > On Wed, 2012-10-31 at 13:18 -0400, Stephen Gallagher wrote: > > >> fail: > > >> -DEBUG(2, ("Failed to save

Re: [SSSD] [PATCH 1/1] LDAP: Better debug logging when saving groups

2012-11-01 Thread Jakub Hrozek
On Wed, Oct 31, 2012 at 02:36:38PM -0400, Stephen Gallagher wrote: > [1] See Jakub's patch about the off-by-one error. Basically, we were > trying to allocate an array of zero length, getting NULL back and > treating it as an out-of-memory error. For the record, that patch was fixing another issue

Re: [SSSD] [PATCH 1/1] LDAP: Better debug logging when saving groups

2012-10-31 Thread Stephen Gallagher
On Wed 31 Oct 2012 02:16:02 PM EDT, Simo Sorce wrote: On Wed, 2012-10-31 at 13:18 -0400, Stephen Gallagher wrote: fail: -DEBUG(2, ("Failed to save group [%s]\n", - name ? name : "Unknown")); +DEBUG(SSSDBG_MINOR_FAILURE, + ("Failed to save group [%s]: [%s]\n", +

Re: [SSSD] [PATCH 1/1] LDAP: Better debug logging when saving groups

2012-10-31 Thread Simo Sorce
On Wed, 2012-10-31 at 14:36 -0400, Stephen Gallagher wrote: > On Wed 31 Oct 2012 02:16:02 PM EDT, Simo Sorce wrote: > > On Wed, 2012-10-31 at 13:18 -0400, Stephen Gallagher wrote: > >> fail: > >> -DEBUG(2, ("Failed to save group [%s]\n", > >> - name ? name : "Unknown")); > >> +

Re: [SSSD] [PATCH 1/1] LDAP: Better debug logging when saving groups

2012-10-31 Thread Simo Sorce
On Wed, 2012-10-31 at 13:18 -0400, Stephen Gallagher wrote: > fail: > -DEBUG(2, ("Failed to save group [%s]\n", > - name ? name : "Unknown")); > +DEBUG(SSSDBG_MINOR_FAILURE, > + ("Failed to save group [%s]: [%s]\n", > + name ? name : "Unknown", > +

[SSSD] [PATCH 1/1] LDAP: Better debug logging when saving groups

2012-10-31 Thread Stephen Gallagher
--- src/providers/ldap/sdap_async_groups.c | 86 +- 1 file changed, 75 insertions(+), 11 deletions(-) diff --git a/src/providers/ldap/sdap_async_groups.c b/src/providers/ldap/sdap_async_groups.c index 60cbcea7727f5d7e614f339acf979e513b114efd..cb372d2cf38a85298066