Re: [SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-09 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/07/2009 09:51 AM, Dmitri Pal wrote: Hi, Please find a series of patches related to $subj. 0001 - Trace improvements. See patch comments. (independent patch) Ack 0003 - Collection enhancements needed for ELAPI Ack. 0006 - Cleaning

Re: [SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-08 Thread Simo Sorce
On Mon, 2009-12-07 at 09:51 -0500, Dmitri Pal wrote: 0002 - Dhash improvement. See patch comments. (independent patch) I am leaning on nacking this one. It is redundant and basically just duplicates code. The only difference between hash_lookup+hash_delete and hash_remove is one less lookup, if

Re: [SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-08 Thread Dmitri Pal
Simo Sorce wrote: On Mon, 2009-12-07 at 09:51 -0500, Dmitri Pal wrote: 0002 - Dhash improvement. See patch comments. (independent patch) I am leaning on nacking this one. It is redundant and basically just duplicates code. The only difference between hash_lookup+hash_delete and

Re: [SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-08 Thread John Dennis
On 12/08/2009 12:35 PM, Dmitri Pal wrote: Simo Sorce wrote: On Mon, 2009-12-07 at 09:51 -0500, Dmitri Pal wrote: 0002 - Dhash improvement. See patch comments. (independent patch) I am leaning on nacking this one. It is redundant and basically just duplicates code. The only difference

Re: [SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-08 Thread Simo Sorce
On Tue, 2009-12-08 at 12:43 -0500, John Dennis wrote: I think Simo's suggestion of using the delete callback in these cases is the best idea. If you allow returning values from the delete operation you have the potential for inconsistencies. How do you know if value returned is still

[SSSD] [PATCHES] Collection, INI, Trace, DHASH

2009-12-07 Thread Dmitri Pal
Hi, Please find a series of patches related to $subj. 0001 - Trace improvements. See patch comments. (independent patch) 0002 - Dhash improvement. See patch comments. (independent patch) 0003 - Collection enhancements needed for ELAPI 0006 - Cleaning FIXME comments in collection (ticket #157)