[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ * master: 1c7f9a676088ecee4c14df14b8688b391fb32a05 """ See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-277713445

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2017-02-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ I'm sorry this review stalled. I think the current patch is fine. About the duplicate messages -- the messages from get_server_status and get_port_status are quite low

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages justin-stephenson commented: """ Hello Jakub/Michal, thanks a lot for your comments and review. I updated the PR to provide a better explanation which uses elements of both suggestions

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages mzidek-rh commented: """ Hi Justin! I agree with jhrozek that the debug level is not correct and that the message is confusing, because there is relationship between the status of internal port

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages mzidek-rh commented: """ Hi Justin! I agree with jhrozek that the debug level is not correct and that the message is confusing, because there is relationship between the status of internal port

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ I wonder if @mzidek-rh has any more comments """ See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268471546

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ I have two comments: 1. The new debug message has "louder" debug level than the one that sets the port as non-working. I would suggest to also change the 'not working'

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268183489 ___ sssd-devel mailing list

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-19 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268095628

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2016-12-19 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-268095633