URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
Ah, somehow seems that I cannot reopen the PR. So, I'm opening a new one.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/50#issuecomment-328271998
_
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
So, I've re-worked those patches a little bit and here is the time difference
when running reconfing with the patches:
```
real0m26.047s
user0m21.318s
sys 0m4.635s
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
It's been almost 2 months this code has been around and there's anyone
interested to review.
So, I'm closing the PR (as "rejected") as this patchset doesn't seem to be
useful
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
So, here are some stats about the configure time that you complained before:
So, I've ran the contrib/ci/run script on our F25 machine on Jenkins.
This is what we have **withou
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
So, here are some stats about the configure time that you complained before:
So, I've ran the contrib/ci/run script on our F25 machine on Jenkins.
This is what we have **withou
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
@lslebodn:
After some proper checking, seems that all "-Wunitialized" reports are false
positives, so I've removed the patches from this series.
I've added "Reviewed-by: " to t
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
Lukáš,
I'm afraid you didn't understand how the usage of the GNULIB's compiler
warnings is supposed to be.
There are basically 3 essential files:
- warnings.m4
- manywarnings.
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
Disabling Werror on RHEL6 will be just a matter of passing "--enable-werror=no"
to configure. It should be **really** simple as long as we agree on doing that.
About the extra
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
lslebodn commented:
"""
On (09/11/16 07:54), fidencio wrote:
>@lslebodn, a way easier solution would be to disable -Werror when running CI
>on RHEL6 than fixing those issues only caught there. Is ther
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
@lslebodn, a way easier solution would be to disable -Werror when running CI on
RHEL6 than fixing those issues only caught there. Is there a simple way to do
that?
"""
See th
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
lslebodn commented:
"""
I do not think that initialisation to NULL is the best solution for
Wunitialized on RHLE6.
My experience is that such bugs occurs when there is some suspicious code in
functi
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
http://sssd-ci.duckdns.org/logs/job/56/78/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/50#issuecomment-259444704
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
fidencio commented:
"""
I've updated this series and I'm still waiting for CI to finish.
A lot of warnings were just caught when building on RHEL6 machine (which passes
gracefully now).
I'll post the
URL: https://github.com/SSSD/sssd/pull/50
Title: #50: [RFC] Use GNULIB's compiler warning code
lslebodn commented:
"""
It seems that resolv patches broke `resolv-tests` on fedora 22 and fedora 23.
The test has been running for 30 hours without any result. I've just cancelled
it.
BTW CI did no
14 matches
Mail list logo
