URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
alexey-tikhonov commented:
"""
JFTR, the above comment was addressed via
37ba37a425453d8222584176ae5975a795422091
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
sumit-bose commented:
"""
Hi @pbrezina,
I came across an issue with `current_forest` and `current_site`. After some
calls to `ad_cldap_ping_send()` with `renew_site == False` the value was
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5300
* `master`
* f0d650799d4390f90890d17c56a4e395e931d8cb - tevent: correctly handle req
timeout error
*
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
sumit-bose commented:
"""
Hi,
thanks, ACK.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5300#issuecomment-702188350
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
pbrezina commented:
"""
Done. I only changed comment in `ad_cldap_ping_parallel_batch`.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5300#issuecomment-702138924
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
sumit-bose commented:
"""
Hi,
thanks for the changes, the patches are working well and with
`debug_microseconds = True` one can actually see the time SSSD is waiting for
replies for the
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
pbrezina commented:
"""
Done. I added `ad_cldap_ping_parallel_batch` and logic around it.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5300#issuecomment-701338948
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
sumit-bose commented:
"""
> So do you suggest to implement 3 batches that are sent at time T (5 servers),
> T+400ms (5 servers), T+600ms (remainder) or to iterate over it sequentially
>
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
pbrezina commented:
"""
So do you suggest to implement 3 batches that are sent at time T (5 servers),
T+400ms (5 servers), T+600ms (remainder) or to iterate over it sequentially
with slow
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
sumit-bose commented:
"""
> Do you mean there is 100ms timeout for the DC's to deliver a reply? That's
> quite low, isn't it?
If I understand the MFST document correctly the client still
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
pbrezina commented:
"""
Do you mean there is 100ms timeout for the DC's to deliver a reply? That's
quite low, isn't it?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
sumit-bose commented:
"""
Hi,
maybe there should be some limit in the for-loop so that SSSD does not
accidentally tries to ping hundreds of DC in a larger AD environment.
adcli implements
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
sumit-bose commented:
"""
Hi,
thanks for the patches. My tests with various configurations with multiple
existing, not-existing or not responding DCs went well. Coverity didn't had
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
alexey-tikhonov commented:
"""
> @pbrezina I see linking failures:
>
> ```
> /usr/bin/ld: /tmp/nss-srv-tests.hGpNig.ltrans0.ltrans.o: in function
> `__wrap_sss_packet_get_body':
...
> ```
URL: https://github.com/SSSD/sssd/pull/5300
Title: #5300: ad: use parallel cldap ping for site discovery
abbra commented:
"""
@pbrezina I see linking failures:
```
/usr/bin/ld: /tmp/nss-srv-tests.hGpNig.ltrans0.ltrans.o: in function
`__wrap_sss_packet_get_body':
15 matches
Mail list logo