URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5474
* `master`
* 78323d44efc657cde1ec4bfaf2cbba9dd04f614c - configure: libcollection is
not required
*
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
sumit-bose commented:
"""
> Hi @sumit-bose,
>
> would you like to take a look at this version?
Hi,
I have no further comments, ACK.
bye,
Sumit
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
Hi @sumit-bose,
would you like to take a look at this version?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5474#issuecomment-773221017
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
pbrezina commented:
"""
Ok, I just removed it completely, given we don't use it directly.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5474#issuecomment-773216953
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
IIUC, the only thing left to address is libcollection in configure?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5474#issuecomment-772598978
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
pbrezina commented:
"""
Agreed. I run rpmdiff and the multilib regression in pyc/pyo files did not show
up so I it seems it is either no longer needed or it is handled by autosetup.
There is
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
I think with a recent patch removing UpdateTimestamps() `BuildRequires:
diffstat` isn't needed anymore.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
And, btw, we don't check for ref_array at configure time, which is probably
wrong since we use it explictly, but isn't a real issue since ini_config pulls
it in.
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
> > Another thing: on "src/external/libcollection.m4" error message is "Please
> > install libcollection-devel" but we do not require "-devel", merely
> >
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
> > Another thing: on "src/external/libcollection.m4" error message is "Please
> > install libcollection-devel" but we do not require "-devel", merely
> >
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
pbrezina commented:
"""
> Another thing: on "src/external/libcollection.m4" error message is "Please
> install libcollection-devel" but we do not require "-devel", merely binaries.
Do we need
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
pbrezina commented:
"""
> libcollection-devel
Do we need it at all? AFAIK its pulled by libini but we don't use it directly
in SSSD, do we?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
Another thing: on "src/external/libcollection.m4" error message is "Please
install libcollection-devel" but we do not require "-devel", merely binaries.
"""
See
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
> Fedora33:
>
> ```
> /usr/bin/ld: /builddir/build/BUILD/sssd-2.4.1/.libs/libsss_child.so:
> undefined reference to `sss_hash_create'
> /usr/bin/ld:
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
Fedora33:
```
/usr/bin/ld: /builddir/build/BUILD/sssd-2.4.1/.libs/libsss_child.so: undefined
reference to `sss_hash_create'
/usr/bin/ld:
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
I think this patch - `sudo: do not search by low usn value to improve
performance ` - was included by a mistake..?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
pbrezina commented:
"""
Thanks. See new patches.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5474#issuecomment-770811398
___
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
Hi,
1) I think we can remove:
```
BuildRequires: libcollection-devel
BuildRequires: nspr-devel
```
2) do we really need
```
BuildRequires: dbus-libs
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
Hi,
1) I think we can remove:
```
BuildRequires: libcollection-devel
BuildRequires: nspr-devel
2) do we really need
```
BuildRequires: dbus-libs
BuildRequires:
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
pbrezina commented:
"""
See updated patches. I added lots of additional commits to sync with what we
currently use in RHEL 8.4.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
There was also a comment in sssd.spec.in that I would like to keep:
```
# p11tool from the gnutls-utils package and softhsm2-util from the softhsm
package
# are
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
sumit-bose commented:
"""
>
> Yes. i also wonder if we need to keep all versioned requires and conflicts
> like:
>
> ```
> BuildRequires: libcmocka-devel >= 1.0.0
> ...
> Conflicts:
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
pbrezina commented:
"""
> Hi,
>
> besides questions I raised in comments, I have following questions/remarks:
>
> 1. Don't we need `Requires(postun): /sbin/ldconfig` in `%package client`?
URL: https://github.com/SSSD/sssd/pull/5474
Title: #5474: spec: synchronize with Fedora 34 spec file
alexey-tikhonov commented:
"""
Hi,
besides questions I raised in comments, I have following questions/remarks:
1) Don't we need `Requires(postun): /sbin/ldconfig` in `%package client`?
2) I
24 matches
Mail list logo
