URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5558
* `master`
* 65c90d8f98b3ed17574972f1e1bd77d2f2fcf64f - sssd.spec: BuildRequires on
openssl tool
* 7e3edb0622b
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
sumit-bose commented:
"""
Hi,
CI looks better now :-), ACK.
bye,
Sumit
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5558#issuecomment-816542437
_
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
3v1n0 commented:
"""
> Do I understand correctly that your patches do not need `faketime` and you
> add the BuildRequires to just run the missing existing tests? If that's the
> case I would r
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
sumit-bose commented:
"""
> Mhmh, not sure what's this failure is about:
>
> ```
> rpmbuild --define "_topdir /shared/sssd/rpmbuild" -ba SPECS/sssd.spec
> setting SOURCE_DATE_EPOCH=1611187200
>
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
3v1n0 commented:
"""
Mhmh, not sure what's this failure is about:
```
rpmbuild --define "_topdir /shared/sssd/rpmbuild" -ba SPECS/sssd.spec
setting SOURCE_DATE_EPOCH=1611187200
error: Failed bu
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
3v1n0 commented:
"""
> the RHEL/Fedora package is called `libfaketime`
Yeah, sorry... I think it is somewhat aliased with faketime as when `dnf
install`ing that was working too.
> if you cha
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
sumit-bose commented:
"""
Hi,
the RHEL/Fedora package is called `libfaketime`, if you change this hopefully
more CI tests should pass.
bye,
Sumit
"""
See the full comment at
https://github.
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
3v1n0 commented:
"""
> to make sure all tests start with unset `pam_cert_verification`?
Done!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/5558#issuecomment-810670606
___
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
sumit-bose commented:
"""
Hi,
can you add something like
```
diff --git a/src/tests/cmocka/test_pam_srv.c b/src/tests/cmocka/test_pam_srv.c
index ab47e2986..8d69eaf07 100644
--- a/src/tests/cmo
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
3v1n0 commented:
"""
> and here `X509_V_FLAG_CRL_CHECK_ALL` enforces a CRL check of the whole chain,
> i.e. you need the CRL of each CA in the chain. I wonder if `partial_chain`
> should have
URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support
sumit-bose commented:
"""
Hi,
thank you for the patches and especially for the extensive tests. I think both
`partial_chain` and `pam_cert_verification` are useful. I will run some tests,
but
11 matches
Mail list logo
