[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-10 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ > `test_pam_responder.py::test_krb5_auth` seems to be broken on Debian target. I installed Debian11 in local VM, compiled master branch (i.e. without my patches) and tried a

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-10 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ > `test_pam_responder.py::test_krb5_auth` seems to be broken on Debian target. I installed Debian11 in local VM, compiled **master** branch (i.e. without my patches) and tri

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-08 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ `test_pam_responder.py::test_krb5_auth` seems to be broken on Debian target. """ See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-915118038 __

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-08 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ Covscan is clean: https://cov01.lab.eng.brq.redhat.com/covscanhub/task/232093/log/added.err """ See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ I opened two new tickets for remaining steps: #5777 and #5778, but those are out of initial scope. So this PR is ready for review. """ See the full comment at https://gith

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ I opened two new tickets for remaining steps: #5777 and #5778, but those are out of initial scope. So this PR is ready for review "as is". """ See the full comment at http

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ I opened two new tickets for remaining steps: #5777 and #5778, but those are out of initial scope. I think this PR is ready for review "as is". """ See the full comment at

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ I opened two new ticket for remaining steps: #5777 and #5778, but those are out of initial scope. I think this PR is ready for review "as is". """ See the full comment at

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ I opened two new ticket for remaining steps: #5777 and #5778 I think this PR is ready for review "as is". """ See the full comment at https://github.com/SSSD/sssd/pull/5766

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-07 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ Sorry I didn't indicate this is work-in-progress yet. Remaining steps here are: - incorporate "lib secrets" into KCM since there are no other users - to check if `kcm_ops_q

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-03 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ @aborah-sudo, is this test executed in PR CI? At the moment I don't understand how both methods can succeed, because it seems depending on execution order either 'nsswitch.co

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-03 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ @aborah-sudo, is this test executed in PR CI? At the moment I don't understand how both methods can succeed, because it seems depending on execution order either 'nsswitch.co

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-09-01 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ > Also there is an issues with a spec file: > > ``` > /usr/bin/install -p -m 644 src/sysv/systemd/sssd.service > src/sysv/systemd/sssd-nss.socket src/sysv/systemd/sssd-nss.

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-08-30 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. pbrezina commented: """ > > > * incorporate "lib secrets" into KCM since there are no other users > > > > > > If you want to touch this, it might be good to investigate if it is still > > needed. libsecr

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-08-30 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ > > * incorporate "lib secrets" into KCM since there are no other users > > If you want to touch this, it might be good to investigate if it is still > needed. libsecrets wa

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-08-30 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. pbrezina commented: """ > Sorry I didn't indicate this is work-in-progress yet. > > Remaining steps here are: > > * incorporate "lib secrets" into KCM since there are no other users If you want to to

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-08-30 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ Also there is an issues with a spec file: ``` /usr/bin/install -p -m 644 src/sysv/systemd/sssd.service src/sysv/systemd/sssd-nss.socket src/sysv/systemd/sssd-nss.service sr

[SSSD] [sssd PR#5766][comment] [WiP] Sources cleanup - part 3.

2021-08-30 Thread alexey-tikhonov
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: [WiP] Sources cleanup - part 3. alexey-tikhonov commented: """ Sorry I didn't indicate this is work-in-progress yet. Remaining steps here are: - incorporate "lib secrets" into KCM since there are no other users - to check if `kcm_ops_q