URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
* master: 2c965b04f693df4ca89eda7a4cff9d1900523837
"""
See the full comment at
https://github.com/SSSD/sssd/pull/677#issuecomment-508238642
___
sssd-de
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
Internal CI passed everywhere but Debian which is known to be broken ->
Accepted.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/677#issuecomment-508190215
___
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
thalman commented:
"""
I fixed formatting/space typos as well as errno_t definition issue.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/677#issuecomment-508025769
__
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
thalman commented:
"""
> One more question (and maybe I already asked it in the months before :-)) but
> did you consider preferring pcre2? Or would you prefer to do it in a separate
> patch?
Separate patch definitely
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
One more question (and maybe I already asked it in the months before :-)) but
did you consider preferring pcre2? Or would you prefer to do it in a separate
patch?
"""
See the full comment at
ht
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
btw about testing: I cheated a little because removing pcre on Fedora removes
also glib-devel. So I just removed one of the .pc files from pcre-devel and
then configured sssd using --with-unicode
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
I'm sorry to keep beating the error code from *sss_regexp_new...but why not
just return int from that function, which would be EOK on success, in which
case a **self pointer would also be returne
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/677#issuecomment-432579282
___
sssd-devel mailing list -- sssd-devel@l
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
thalman commented:
"""
Re-formatted to 80 columns
"""
See the full comment at
https://github.com/SSSD/sssd/pull/677#issuecomment-431803305
___
sssd-devel mailing list -- sssd
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
I added some style comments. Please don't take them the wrong way, I didn't
mean to needlessly pick on your code (I think in general the patches are good!)
but because SSSD is such a big project
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
CI detected some memory leaks on RHEL-7:
```
=11224== 228 bytes in 1 blocks are possibly lost in loss record 256 of 384
==11224==at 0x4C29BC3: malloc (vg_replace_malloc.c:299)
==11224==by 0
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
(Hopefully CI will run automatically for you the next time..)
"""
See the full comment at
https://github.com/SSSD/sssd/pull/677#issuecomment-429936817
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
jhrozek commented:
"""
add to whitelist
"""
See the full comment at
https://github.com/SSSD/sssd/pull/677#issuecomment-429936705
___
sssd-devel mailing list -- sssd-devel@lis
URL: https://github.com/SSSD/sssd/pull/677
Title: #677: pcre: port to pcre2
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/677#issuecomment-429850535
___
sssd-devel mail
14 matches
Mail list logo
