URL: https://github.com/SSSD/sssd/pull/905
Title: #905: WIP: Don't ignore host entries in Group Policy security filters
mzidek-rh commented:
"""
Marking this as waiting for a review for now, so that someone from SSSD will
also take a look at this.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: WIP: Don't ignore host entries in Group Policy security filters
abbra commented:
"""
Sure, David.
See src/lib/idmap/sss_idmap.h for SID-related functions.
For accessing `ad_hostname`, you have it already in the `struct
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: WIP: Don't ignore host entries in Group Policy security filters
dmulder commented:
"""
@abbra I assumed there was probably sid conversion code somewhere, but I'm not
very familiar with sssd and couldn't find it.
Also, I agree using
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: WIP: Don't ignore host entries in Group Policy security filters
abbra commented:
"""
Few observations:
- we already have code to translate between string/structure for SIDs, why
there is a need for another one?
- may be you can simplify
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: WIP: Don't ignore host entries in Group Policy security filters
sumit-bose commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/905#issuecomment-543549922
___
URL: https://github.com/SSSD/sssd/pull/905
Title: #905: WIP: Don't ignore host entries in Group Policy security filters
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/905#issuecomment-543347505