Hi Dan,
On 03/09/2017 12:33 PM, Dan Lavu wrote:
Thanks for the review, the responses are inline.
On Wed, Mar 8, 2017 at 1:59 AM, Nikolai Kondrashov mailto:nikolai.kondras...@redhat.com>> wrote:
def _setup_config(self):
"""Setup the instance initial configuration.""
Nik,
Thanks for the review, the responses are inline.
On Wed, Mar 8, 2017 at 1:59 AM, Nikolai Kondrashov <
nikolai.kondras...@redhat.com> wrote:
> On 03/07/2017 05:05 PM, Dan Lavu wrote:
>
>> Updated.
>>
>
> Thanks! Please see my comments below.
>
> On 03/07/2017 05:05 PM, Dan Lavu wrote:
>
>> d
On 03/07/2017 05:05 PM, Dan Lavu wrote:
Updated.
Thanks! Please see my comments below.
On 03/07/2017 05:05 PM, Dan Lavu wrote:
diff --git src/tests/intg/ds.py src/tests/intg/ds.py
index 66cb887..13c0778 100644
--- src/tests/intg/ds.py
+++ src/tests/intg/ds.py
@@ -23,7 +23,7 @@ import ldap
cl
Nik,
Updated.
Dan
On Tue, Mar 7, 2017 at 4:11 AM, Nikolai Kondrashov <
nikolai.kondras...@redhat.com> wrote:
> On 03/06/2017 09:34 PM, Dan Lavu wrote:
>
>> Since we last spoken, here is an update patch for review. Adding an
>> optional
>> ssl parameter to the DS class. When enabled, right now t
On 03/06/2017 09:34 PM, Dan Lavu wrote:
Since we last spoken, here is an update patch for review. Adding an optional
ssl parameter to the DS class. When enabled, right now the tests fail
because SSL is not configured properly on the client, but I'll get to that
in my next patch?
Glad to see you
Nikolai,
Since we last spoken, here is an update patch for review. Adding an
optional ssl parameter to the DS class. When enabled, right now the tests
fail because SSL is not configured properly on the client, but I'll get to
that in my next patch?
Dan
On Fri, Mar 11, 2016 at 1:16 PM, Nikolai Ko
Hi Dan,
On 03/12/2016 12:20 AM, Dan Lavu wrote:
WOAH, that's a lot of comments! ;) Thanks for taking the time, I have some
questions inline and I'll start working on improving the code.
Sorry, missed your reply somehow. Answering the only question Lukas didn't
answer, below.
On Fri, Mar 11,
On (11/03/16 17:20), Dan Lavu wrote:
>WOAH, that's a lot of comments! ;) Thanks for taking the time, I have some
>questions inline and I'll start working on improving the code.
>
>On Fri, Mar 11, 2016 at 1:16 PM, Nikolai Kondrashov <
>nikolai.kondras...@redhat.com> wrote:
>> Hi Dan,
>>
>> Thanks a
WOAH, that's a lot of comments! ;) Thanks for taking the time, I have some
questions inline and I'll start working on improving the code.
On Fri, Mar 11, 2016 at 1:16 PM, Nikolai Kondrashov <
nikolai.kondras...@redhat.com> wrote:
> Hi Dan,
>
> Thanks a lot for your work! Please see my comments bel
Hi Dan,
Thanks a lot for your work! Please see my comments below.
On 03/11/2016 06:29 AM, Dan Lavu wrote:
Updated patch is attached,
There were a few more packages I had to install to get CI running for Debian,
should we had these to the makefile?
root@sssd2:~# apt-get python-openssl
dpkg
Updated patch is attached,
There were a few more packages I had to install to get CI running for
Debian, should we had these to the makefile?
root@sssd2:~# apt-get python-openssl
dpkg
-ihttp://ftp.us.debian.org/debian/pool/main/n/nss-wrapper/libnss-wrapper_1.1.2-1_amd64.deb
dpkg
-ihttp://se
On Sun, Feb 28, 2016 at 08:19:57PM -0500, Dan Lavu wrote:
> I've made most of the the suggested changes but I'm going to take sometime
> and get the test running on Debian as well (Mostly to find out if /etc/pki
> is a Red Hat thing or not). Fedora and Debian are the only distros we are
> testing/s
I've made most of the the suggested changes but I'm going to take
sometime and get the test running on Debian as well (Mostly to find out
if /etc/pki is a Red Hat thing or not). Fedora and Debian are the only
distros we are testing/supporting against correct? Also wondering if the
ci setup issu
On (26/02/16 11:53), Jakub Hrozek wrote:
>On Thu, Feb 25, 2016 at 05:18:09PM -0500, Dan Lavu wrote:
>> Here is a patch for https://fedorahosted.org/sssd/ticket/2820
>>
>> First real patch... criticisms to for what I need to improve on are welcome,
>> including concepts that I should learn, thanks.
On Thu, Feb 25, 2016 at 05:18:09PM -0500, Dan Lavu wrote:
> Here is a patch for https://fedorahosted.org/sssd/ticket/2820
>
> First real patch... criticisms to for what I need to improve on are welcome,
> including concepts that I should learn, thanks.
Thanks a lot for the patch!
See my comments
15 matches
Mail list logo
