Re: [PATCH] netlink: introduce a dummy netlink attributes parser

2017-06-16 Thread JingPiao Chen
On Sat, Jun 17, 2017 at 12:22:48AM +0300, Dmitry V. Levin wrote: > On Fri, Jun 16, 2017 at 01:35:07PM +0800, JingPiao Chen wrote: > > * defs.h (decode_nlattr): New prototype. > > * linux/unix_diag.h (UNIX_DIAG_*): New enum. > > * netlink.c (fetch_nlattr, print_nlattr, > > decode_nlattr_with_data, d

Re: [PATCH] netlink: decode AF_INET diag attributes

2017-06-16 Thread Dmitry V. Levin
On Mon, May 22, 2017 at 09:18:09PM +0800, JingPiao Chen wrote: > * netlink_sock_diag.c: Include . > (decode_inet_attrs): New function. > (decode_inet_diag_msg): Use decode_inet_attrs. > * linux/inet_diag.h (inet_diag_meminfo, tcpvegas_info, > tcp_dctcp_info, tcp_bbr_info): New structures. > * linux

Re: [PATCH] netlink: introduce nla_policy system to parse netlink attribute data

2017-06-16 Thread Dmitry V. Levin
On Sat, May 20, 2017 at 07:42:19PM +0800, JingPiao Chen wrote: > * defs.h (NLA_*): New enum. > (nla_policy): New struct. > (decode_nlattr): Adapt prototype. > * netlink.c (decode_nlattr_data): New function. > (decode_nlattr_with_data): Use decode_nlattr_data. > * netlink_sock_diag.c (decode_inet_di

Re: [PATCH] netlink: introduce a dummy netlink attributes parser

2017-06-16 Thread Dmitry V. Levin
On Fri, Jun 16, 2017 at 01:35:07PM +0800, JingPiao Chen wrote: > * defs.h (decode_nlattr): New prototype. > * linux/unix_diag.h (UNIX_DIAG_*): New enum. > * netlink.c (fetch_nlattr, print_nlattr, > decode_nlattr_with_data, decode_nlattr): New functions. Looks like there is no necessity to place th

Re: [PATCH v3 1/5] dyxlat: building xlat dynamically

2017-06-16 Thread Dmitry V. Levin
On Sat, Jun 17, 2017 at 03:48:06AM +0900, Masatake YAMATO wrote: > On Wed, 14 Jun 2017 00:55:03 +0300, "Dmitry V. Levin" > wrote: > > On Tue, Jun 13, 2017 at 05:26:41PM +0900, Masatake YAMATO wrote: > >> xlat tables are generating in built-time of strace. > >> > >> printxval is suitable for prin

Re: [PATCH v3 1/5] dyxlat: building xlat dynamically

2017-06-16 Thread Masatake YAMATO
On Wed, 14 Jun 2017 00:55:03 +0300, "Dmitry V. Levin" wrote: > On Tue, Jun 13, 2017 at 05:26:41PM +0900, Masatake YAMATO wrote: >> xlat tables are generating in built-time of strace. >> >> printxval is suitable for printing `family' field of Netlink GENERIC >> protocol. However, contents of the x

[PATCH RFC v2 1/1] Initial support for Lua scripting

2017-06-16 Thread Victor Krapivensky
This change also defines currpers field of struct tcb if LuaJIT is enabled, even if SUPPORTED_PERSONALITIES == 1. * Makefile.am: Build with LuaJIT if configured so. (strace_SOURCES): Add defs_tcb.h, syscall_class.h. * configure.ac: Add new --with-luajit configure option. * defs.h (QUAL_HOOK_ENTRY,

Re: [PATCH RFC v1 1/1] Initial support for Lua scripting

2017-06-16 Thread Dmitry V. Levin
On Fri, Jun 16, 2017 at 05:39:01PM +0300, Victor Krapivensky wrote: > On Thu, Jun 15, 2017 at 05:39:25PM +, Eugene Syromyatnikov wrote: > > On Thu, Jun 15, 2017 at 3:28 PM, Eugene Syromiatnikov > > wrote: > > > Overall looks good. > > > > Well, except that mpers_defs.h also has STRINGIFY() m

Re: [PATCH RFC v1 1/1] Initial support for Lua scripting

2017-06-16 Thread Eugene Syromyatnikov
On Fri, Jun 16, 2017 at 2:39 PM, Victor Krapivensky wrote: > On Thu, Jun 15, 2017 at 05:39:25PM +, Eugene Syromyatnikov wrote: >> On Thu, Jun 15, 2017 at 3:28 PM, Eugene Syromiatnikov >> wrote: >> > Overall looks good. >> >> Well, except that mpers_defs.h also has STRINGIFY() macro and >> un

Re: [PATCH RFC v1 1/1] Initial support for Lua scripting

2017-06-16 Thread Victor Krapivensky
On Thu, Jun 15, 2017 at 05:39:25PM +, Eugene Syromyatnikov wrote: > On Thu, Jun 15, 2017 at 3:28 PM, Eugene Syromiatnikov wrote: > > Overall looks good. > > Well, except that mpers_defs.h also has STRINGIFY() macro and > undef'ing it in defs_reuse.h leads to breaking of mpers header > generat

Re: [PATCH RFC v1 1/1] Initial support for Lua scripting

2017-06-16 Thread Victor Krapivensky
On Thu, Jun 15, 2017 at 05:28:53PM +0200, Eugene Syromiatnikov wrote: > Do you really consider multiple -l arguments in a command line an error > incompatible with continuation of strace execution? Well, yes. We don't support multiple scripts, and specifying multiple -l arguments is a usage error.

Re: [PATCH v2 8/8] tests: check decoding of NETLINK_SOCK_DIAG AF_SMC messages

2017-06-16 Thread JingPiao Chen
On Fri, Jun 16, 2017 at 04:07:10AM +0300, Dmitry V. Levin wrote: > On Thu, Jun 15, 2017 at 12:30:54PM +0800, JingPiao Chen wrote: > > * tests/netlink_sock_diag.c: Include . > > (SMC_ACTIVE): New macro. > > (test_smc_diag_req, test_smc_diag_msg): New functions. > > (main): Use them. > > Thanks, appl