On Fri, Jun 16, 2017 at 05:39:01PM +0300, Victor Krapivensky wrote: > On Thu, Jun 15, 2017 at 05:39:25PM +0000, Eugene Syromyatnikov wrote: > > On Thu, Jun 15, 2017 at 3:28 PM, Eugene Syromiatnikov <e...@redhat.com> > > wrote: > > > Overall looks good. > > > > Well, except that mpers_defs.h also has STRINGIFY() macro and > > undef'ing it in defs_reuse.h leads to breaking of mpers header > > generation and breaking of the (clean) build, as a result. I'd suggest > > renaming STRINGIFY() macro in defs_reuse.h. > > I think it would be better to rename STRINGIFY() macro in mpers_defs.h, > so that it does not pollute the global namespace.
Why not rename both macros then? -- ldv
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
