Re: [PATCH] Add btrfs ioctl support.

2016-05-14 Thread Jeff Mahoney
On 5/14/16 6:35 PM, Dmitry V. Levin wrote: > On Fri, May 13, 2016 at 08:13:22PM +0300, Dmitry V. Levin wrote: >> On Wed, May 04, 2016 at 08:07:13PM -0400, je...@suse.com wrote: >> [...] >>> +static void >>> +btrfs_print_objectid(uint64_t objectid) >>> +{ >>> + const char *str = xlookup(btrfs_tree

Re: [PATCH] Add btrfs ioctl support.

2016-05-14 Thread Dmitry V. Levin
On Fri, May 13, 2016 at 08:13:22PM +0300, Dmitry V. Levin wrote: > On Wed, May 04, 2016 at 08:07:13PM -0400, je...@suse.com wrote: > [...] > > +static void > > +btrfs_print_objectid(uint64_t objectid) > > +{ > > + const char *str = xlookup(btrfs_tree_objectids, objectid); > > > As we have both

Re: [PATCH] Add btrfs ioctl support.

2016-05-13 Thread Dmitry V. Levin
On Wed, May 04, 2016 at 08:07:13PM -0400, je...@suse.com wrote: [...] > +static void > +btrfs_print_objectid(uint64_t objectid) > +{ > + const char *str = xlookup(btrfs_tree_objectids, objectid); As we have both xlookup and xlookup64, you probably want to use xlookup64 at least in all 64-bit l

Re: [PATCH] Add btrfs ioctl support.

2016-05-13 Thread Dmitry V. Levin
On Fri, May 13, 2016 at 11:32:55AM -0400, Jeff Mahoney wrote: > On 5/13/16 11:30 AM, Line Printer wrote: > > On Fri, May 13, 2016 at 6:01 PM, Jeff Mahoney wrote: > >> On 5/13/16 10:57 AM, Line Printer wrote: > >>> On Thu, May 5, 2016 at 3:07 AM, wrote: > From: Jeff Mahoney > > b

Re: [PATCH] Add btrfs ioctl support.

2016-05-13 Thread Jeff Mahoney
On 5/13/16 11:30 AM, Line Printer wrote: > On Fri, May 13, 2016 at 6:01 PM, Jeff Mahoney wrote: >> On 5/13/16 10:57 AM, Line Printer wrote: >>> On Thu, May 5, 2016 at 3:07 AM, wrote: From: Jeff Mahoney btrfs.c| 1298 +

Re: [PATCH] Add btrfs ioctl support.

2016-05-13 Thread Line Printer
On Fri, May 13, 2016 at 6:01 PM, Jeff Mahoney wrote: > On 5/13/16 10:57 AM, Line Printer wrote: >> On Thu, May 5, 2016 at 3:07 AM, wrote: >>> From: Jeff Mahoney >>> >>> btrfs.c| 1298 >>> >> >> Would you care to enrich your code

Re: [PATCH] Add btrfs ioctl support.

2016-05-13 Thread Jeff Mahoney
On 5/13/16 10:57 AM, Line Printer wrote: > On Thu, May 5, 2016 at 3:07 AM, wrote: >> From: Jeff Mahoney >> >> btrfs.c| 1298 >> > > Would you care to enrich your code with a number of tests? You seem to > be most suitable for thi

Re: [PATCH] Add btrfs ioctl support.

2016-05-13 Thread Line Printer
On Thu, May 5, 2016 at 3:07 AM, wrote: > From: Jeff Mahoney > > btrfs.c| 1298 > Would you care to enrich your code with a number of tests? You seem to be most suitable for this task.

[PATCH] Add btrfs ioctl support.

2016-05-04 Thread jeffm
From: Jeff Mahoney * btrfs.c: New file. * file_ioctl.c: New file. * Makefile.am (strace_SOURCES): Add it. * defs.h [LINUX] (btrfs_ioctl): New function. * ioctls.c (ioctl_decode) [LINUX]: Use it to decode BTRFS_* ioctls. * configure.ac: Add check for struct btrfs_ioctl_feature_flags. Add check f