Re: Struts Tools

2003-01-07 Thread David Morris
Ted, I was able to automate this using Ant and the fixcrlf task. By adding a pretty simple target to most builds, it is easy to generate a source version of most Jakarta builds. Here is a sample from the beanutils build: Running this target before the jar tar

RE: Struts Coding Standard

2003-01-07 Thread Andrew Hill
Personally as a user rather than a contributor or extender (well Ive actually extended a fair bit but only to provide support for some wierd stuff my app is doing) Ive found the source to be invaluable as a form of documentation (once I straighten out all those sun-style-misaligned curly brackets s

cvs commit: jakarta-struts/contrib/struts-el/src/share/org/apache/strutsel/taglib/html ELOptionTagBeanInfo.java

2003-01-07 Thread dmkarr
dmkarr 2003/01/07 15:40:18 Modified:contrib/struts-el/src/share/org/apache/strutsel/taglib/html ELOptionTagBeanInfo.java Log: Adding missing reference to "bundle" attribute. Revision ChangesPath 1.2 +13 -11 jakarta-struts/contrib/struts-

RE: Struts Coding Standard

2003-01-07 Thread Martin Cooper
On Tue, 7 Jan 2003, Martin Cooper wrote: > > > On Tue, 7 Jan 2003, David Graham wrote: > > > Like you said, Struts does not use the source as the documentation. The > > majority of people looking at the source are contributors and people looking > > to extend the framework. Member variables sh

RE: Struts Coding Standard

2003-01-07 Thread Craig R. McClanahan
On Tue, 7 Jan 2003, David Graham wrote: > Date: Tue, 07 Jan 2003 12:17:12 -0700 > From: David Graham <[EMAIL PROTECTED]> > Reply-To: Struts Developers List <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Subject: RE: Struts Coding Standard > > Like you said, Struts does not use the source as the d

Re: Struts Coding Standard

2003-01-07 Thread Robert Leland
David Graham wrote: Member variables should be at the top if for no other reason > than that's where people expect them to be. It's one of those acquired tastes. Like I said it's not on my list of must haves, and that's ok! When I first saw variables at the bottom of a class I cursed, and could

RE: Struts Coding Standard

2003-01-07 Thread James Higginbotham
Heh.. This is why I cringed at the thought of revamping standards for Struts - so many people have seen and like so many things. ;) Craig - pick a few trusted folks, change them and make people stick with them, or leave them alone. Please don't let this get too out of hand.. I know, everyone is tr

RE: Struts Coding Standard

2003-01-07 Thread Martin Cooper
On Tue, 7 Jan 2003, David Graham wrote: > Like you said, Struts does not use the source as the documentation. The > majority of people looking at the source are contributors and people looking > to extend the framework. Member variables should be at the top if for no > other reason than that's

RE: Struts Coding Standard

2003-01-07 Thread David Graham
Like you said, Struts does not use the source as the documentation. The majority of people looking at the source are contributors and people looking to extend the framework. Member variables should be at the top if for no other reason than that's where people expect them to be. David Fr

DO NOT REPLY [Bug 15849] New: - Incorrect documentation for "Developing Your Own MessageResources Implementation"

2003-01-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: Struts Coding Standard

2003-01-07 Thread James Higginbotham
I'm not a contributer, but just to mention about putting field at the end of a class definition, I agree.. It tends to jive better with the concept of encapsulation.. Anyone reading the source can see what constructors and public methods (sorted to the top) are available first. They shouldn't have

Re: What happened to getDynaActionFormClass( )?

2003-01-07 Thread Craig R. McClanahan
On 7 Jan 2003, Paul Vincent Craven wrote: > Date: 07 Jan 2003 09:06:10 -0600 > From: Paul Vincent Craven <[EMAIL PROTECTED]> > Reply-To: Struts Developers List <[EMAIL PROTECTED]> > To: Struts Developers List <[EMAIL PROTECTED]> > Subject: Re: What happened to getDynaActionFormClass( )? > > On M

Re: Struts Coding Standard

2003-01-07 Thread David Graham
Another practice I reciently started is placing fields at the very end of a class definition, after all methods. It makes comparing the class and it's interface. But since struts doesn't use many interfaces this isn't a must for me. -Rob That's certainly not a common practice and would confuse

Re: Struts Coding Standard

2003-01-07 Thread Robert Leland
Martin Cooper wrote: In any case, I'd prefer to separate the discussion of a set of coding conventions from the discussion on whether or not to automate them around the checkout/checkin process. +1, I'll table the auto discussion for now. My only pet peeves on formatting is no spaces between

DO NOT REPLY [Bug 15816] - html:form focus in pages with several forms

2003-01-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 15829] - Create the tag 'instanceof' in logic TLD

2003-01-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: What happened to getDynaActionFormClass( )?

2003-01-07 Thread Paul Vincent Craven
On Mon, 2003-01-06 at 16:46, Craig R. McClanahan wrote: > RequestUtils.createActionForm(), which does all the required work for > either standard ActionForm or DynaActionForm type form beans. Thanks. This works well when I am inside an action. But I have one place I want to do it from a JSP. I don

DO NOT REPLY [Bug 15829] - Create the tag 'instanceof' in logic TLD

2003-01-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 15829] - Create the tag 'instanceof' in logic TLD

2003-01-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: Beta 3 PlugIn interface change

2003-01-07 Thread V. Cekvenich
I hope one day Struts menu tags makes it to Jakarta Taglibs or something. .V Matt Raible wrote: I figured out the change in the PlugIn interface the hard way. BTW, I've made some recent improvements to Struts Menu, for supporting CoolMenus4 and role-based permissions. If you prod Scott a little,

DO NOT REPLY [Bug 15832] New: - Missing key in resource file causes html:logic tag messagesPresent message="true" to fail...

2003-01-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 15829] New: - Create the tag 'instanceof' in logic TLD

2003-01-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu