DO NOT REPLY [Bug 26168] New: - wildcard action mapping doesn't work

2004-01-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: why are form beans required for html:form?

2004-01-15 Thread Joe Germuska
At 8:59 PM -0700 1/14/04, Richard Hightower wrote: how about another attribute, i.e., The checkFormBean defaults to true so it is backwards compatible with other versions. I like the idea that html:form checks for the form bean. It makes it easier to debug the way it is. However, I can see when

Feedback on xml-filtering for message parameters (#26112) ?

2004-01-15 Thread Roberto Tyley
If anyone with a bit of experience has got a second, could they venture a one-line opinion on the patch I submitted for #26112? The xml-filtering for message parameters is only a minor feature, and I'd just like to know if what I'm submitting is ok, whether the feature itself is just a dumb idea,

tiles and struts-chain

2004-01-15 Thread Joe Germuska
I just committed a new command and a support class to the struts-chain to support using Tiles with Struts chain. I tried to explain it all in the JavaDoc, but basically, if you plug this command in somewhere after the action has executed (or something else has placed a ForwardConfig into the c

DO NOT REPLY [Bug 26168] - wildcard action mapping doesn't work

2004-01-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: tiles and struts-chain

2004-01-15 Thread Greg Reddin
Thank you very much for doing this. I've looked at implementing Tiles support on several occasions and just haven't had the time to do it. Soon as I get a chance I'll download it and see how it works. Greg Joe Germuska wrote: I just committed a new command and a support class to the struts-cha

Validating Formatted Numbers Patch [Bugzilla 26151]

2004-01-15 Thread Niall Pemberton
I need to validate numbers which are formatted and have posted a patch to bugzilla which enhances validator the existing number validations to do this. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26151 This patch allows an optional "numberPattern" variable to be specified for the existing

Action Config wild cards -- why not use regular expressions?

2004-01-15 Thread Joe Germuska
Since Struts already depends on jakarta-oro, is there a reason not to use it for doing pattern-based mapping, rather than the home-grown methodology that's in the current builds? I don't have a use case for it yet, but since I was a perl hacker before I came to Java, I speak regex reasonably fl

RE: why are form beans required for html:form?

2004-01-15 Thread gvanmatre
I think this is a great idea. We often use buttons on the form for navigation between inquiry/dispaly pages which requires that we use a default formbean. Maybe you could add the attributre to the action noded of the struts config file instead of making it a custom tag attribute? This would allow

RE: why are form beans required for html:form?

2004-01-15 Thread Joe Germuska
At 8:25 AM -0700 1/15/04, <[EMAIL PROTECTED]> wrote: I think this is a great idea. We often use buttons on the form for navigation between inquiry/dispaly pages which requires that we use a default formbean. Maybe you could add the attributre to the action noded of the struts config file instead

Re: Action Config wild cards -- why not use regular expressions?

2004-01-15 Thread David Graham
Unless there's a solid use case, I'd prefer to leave things as they are. You're right that only Validator uses ORO and the plan for Validator 2.0 is to replace it with the standard java.util.regex system which is twice as fast. Since Struts 2.0 will depend on Java 1.4 we could add regex action ma

Re: Action Config wild cards -- why not use regular expressions?

2004-01-15 Thread Robert Leland
Joe Germuska wrote: Since Struts already depends on jakarta-oro, is there a reason not to use it for doing pattern-based mapping, rather than the home-grown methodology that's in the current builds? I don't have a use case for it yet, but since I was a perl hacker before I came to Java, I spea

RE: why are form beans required for html:form?

2004-01-15 Thread Mike Jasnowski
as long as it was clear, the distinction between a form bean missing because it "should" be there, and a form bean missing because it was "optional". I would think it might be better as a tag attr, because a form could be shared with different actions, and it might be sticky if it's optional for "s

Re: Validating Formatted Numbers Patch [Bugzilla 26151]

2004-01-15 Thread Robert Leland
Niall Pemberton wrote: I need to validate numbers which are formatted and have posted a patch to bugzilla which enhances validator the existing number validations to do this. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26151 This patch allows an optional "numberPattern" variable to be spec

RE: why are form beans required for html:form?

2004-01-15 Thread gvanmatre
Joe: I was lobbying for the optional form bean when using the struts tag. My suggestion was directed at an implementation strategy. Instead of adding the extra attribute to the , I thought it might be simpler to add a "default" attribute to the action xml definition. Or, a "reserved word" in t

RE: why are form beans required for html:form?

2004-01-15 Thread Joe Germuska
At 12:25 PM -0500 1/15/04, Mike Jasnowski wrote: as long as it was clear, the distinction between a form bean missing because it "should" be there, and a form bean missing because it was "optional". I would think it might be better as a tag attr, because a form could be shared with different action

Re: Action Config wild cards -- why not use regular expressions?

2004-01-15 Thread Don Brown
Certainly we could adopt the Cocoon model of pluggable matchers; I just used the wildcard matcher as it is easy and straight forward. Using complex pattern matching like Perl5-compatible regex as the default would be more difficult for the average developer and my guess not necessary for most case

Re: Validating Formatted Numbers Patch [Bugzilla 26151]

2004-01-15 Thread Niall Pemberton
Robert, I tried to get mask to work (although until today I had no knowledge of regular expressions) using the ORA demonstration applet and I couldn't get it to (including your suggestion). I'm not saying regular expressions couldn't work (only I don't know how to make them!), but the pattern's

Re: Validating Formatted Numbers Patch [Bugzilla 26151]

2004-01-15 Thread David Graham
The point of having the mask validation is so we don't have to support all variations of patterns. I'm -1 on adding validators that duplicate what can already be done with mask. David --- Niall Pemberton <[EMAIL PROTECTED]> wrote: > Robert, > > I tried to get mask to work (although until today

Re: Validating Formatted Numbers Patch [Bugzilla 26151]

2004-01-15 Thread Niall Pemberton
OK so how can it be done with mask? also, it doesn't get more basic than numbers...if it can be done with mask, but its complicated, doesn't ease of use cut any ice? Niall - Original Message - From: "David Graham" <[EMAIL PROTECTED]> To: "Struts Developers List" <[EMAIL PROTECTED]> Sent:

Using Tiles With Message Resource Bundles

2004-01-15 Thread Rajan Gupta
I want customize the text inside a tile using Message Resources. e.g. Obviously, the above usage of bean:message is illegal. What is the option with tiles. How can we specify a reference to a key in resource bundles to be used as a value into an tiles attribute Thanks _

Re: Using Tiles With Message Resource Bundles

2004-01-15 Thread Rajan Gupta
Sorry, this was not meant for struts-dev. --- Rajan Gupta <[EMAIL PROTECTED]> wrote: > I want customize the text inside a tile using Message Resources. e.g. > > > > > Obviously, the above usage of bean:message is illegal. What is the > option > with tiles. How can we specify a reference to

cvs commit: jakarta-struts/web/examples/exercise index.html

2004-01-15 Thread husted
husted 2004/01/15 19:51:31 Modified:web/examples/WEB-INF/exercise struts-config.xml web/examples/exercise index.html Log: Add test pages for html:img and logic:forward,redirect tags Revision ChangesPath 1.2 +9 -2 jakarta-struts/web/examples/WEB-

cvs commit: jakarta-struts/web/examples/exercise logic-redirect-test-page.jsp logic-redirect-test-forward.jsp logic-redirect-test-action.jsp logic-forward.jsp logic-forward-test-forward.jsp html-img.jsp

2004-01-15 Thread husted
husted 2004/01/15 19:52:15 Added: web/examples/exercise logic-redirect-test-page.jsp logic-redirect-test-forward.jsp logic-redirect-test-action.jsp logic-forward.jsp logic-forward-test-forward.jsp html-img.jsp L

RE: Validating Formatted Numbers Patch [Bugzilla 26151]

2004-01-15 Thread Richard Hightower
Niall, I don't get a vote. I am not a committer. But if I did I would vote +1 on the idea (I have not studied your implementation). I can write regular expressions in a pinch, but why not support all of the java.text.* in the validator rules (including currencey). I like the idea. Rick Highto

cvs commit: jakarta-struts build-webapps.xml

2004-01-15 Thread husted
husted 2004/01/15 19:54:52 Modified:.build-webapps.xml Log: Add test pages for html:img and logic:forward,redirect tags Revision ChangesPath 1.26 +3 -0 jakarta-struts/build-webapps.xml Index: build-webapps.xml

DO NOT REPLY [Bug 26127] - tag lacks "action" attribute

2004-01-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: Validating Formatted Numbers Patch [Bugzilla 26151]

2004-01-15 Thread Ted Husted
In principle, I'd agree with Rick, since these type of patterns are the standard way of doing this sort of thing on the Java platform. But, the sticky wicket is lack of a JavaScript implementation. People would expect an implementation like this to include client-side support, as the other valid

cvs commit: jakarta-struts/contrib/struts-el/doc/userGuide struts-bean-el.xml struts-html-el.xml struts-logic-el.xml struts-tiles-el.xml

2004-01-15 Thread rleland
rleland 2004/01/15 20:10:58 Modified:contrib/struts-el/doc/userGuide struts-bean-el.xml struts-html-el.xml struts-logic-el.xml struts-tiles-el.xml Log: Update tlibversion to read 1.2 Revision ChangesPath 1.7 +1 -1

cvs commit: jakarta-struts/doc/userGuide struts-bean.xml struts-html.xml struts-logic.xml struts-nested.xml struts-tiles.xml

2004-01-15 Thread rleland
rleland 2004/01/15 20:12:07 Modified:doc/userGuide struts-bean.xml struts-html.xml struts-logic.xml struts-nested.xml struts-tiles.xml Log: Update tlibversion to read 1.2 Revision ChangesPath 1.19 +1 -1 jakarta-struts/doc/userGuide/struts

RE: why are form beans required for html:form?

2004-01-15 Thread Ted Husted
On Thu, 15 Jan 2004 12:14:46 -0600, Joe Germuska wrote: > Now, at the risk of sidetracking this discussion, I have to bring > up my other Struts pet-peeve -- the over complexity of pre-filling > forms from data rather than from the request. I'm wondering if > bringing up some questions about how t

RE: why are form beans required for html:form?

2004-01-15 Thread Ted Husted
My only comment is that it seems we're throwing a lot of technology at a problem that could be solved by putting an empty DynaActionForm in the Struts config, and just referring to that. Perhaps something like: -Ted. On Thu, 15 Jan 2004 09:45:41 -0600, Joe Germuska wrote: > At 8:25 AM -0

RE: Validating Formatted Numbers Patch [Bugzilla 26151]

2004-01-15 Thread Richard Hightower
I agree about that sticky wicket, but There are already validation rules that do not have client-side support (via JavaScript). At least this type of stuff would be nice in the contrib area. -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED] Sent: Thursday, January 15, 200

Re: Feedback on xml-filtering for message parameters (#26112) ?

2004-01-15 Thread Ted Husted
We've been quite negligent when it comes to patches. There's at least 26 outstanding, the eldest dating to October 2002. As soon we roll out 1.2.0, handling these, one way or the other, is my next priority. -Ted. On Thu, 15 Jan 2004 14:25:54 +, Roberto Tyley wrote: > > > If anyone with a bi

cvs commit: jakarta-struts/web/examples/exercise logic-forward.jsp

2004-01-15 Thread husted
husted 2004/01/15 20:55:00 Modified:doc/userGuide struts-logic.xml src/share/org/apache/struts/taglib/logic RedirectTag.java web/examples/WEB-INF/exercise struts-config.xml web/examples/exercise logic-forward.jsp Log: Resolve #26133 " tag

DO NOT REPLY [Bug 26133] - tag lacks "action" attribute

2004-01-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: why are form beans required for html:form?

2004-01-15 Thread Andrew Hill
u, hmmm. This could answer the case where the target property is not a String (or boolean). imho, people who dont use strings exclusively in their AFs deserve whatever is coming to them... ;-> Seriously though, I dont think I like the idea of changing the form and view population methodolo

DO NOT REPLY [Bug 26184] New: - Update UploadResources_ja.properties

2004-01-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 26184] - Update UploadResources_ja.properties

2004-01-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu