* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 12 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 9 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 19 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 9 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 9 minutes
* Build Log:
The proposal to merge ~troyanov/maas:remove-maasdb-dump into maas:master has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442045
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing
Review: Approve
UNIT TESTS
-b fix_vmfs_layout lp:~alexsander-souza/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 5d215f859f4010310ad38f824bffef886df8c812
--
https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/442046
Your team MAAS Committers is
The proposal to merge ~troyanov/maas:remove-maasdb-dump into maas:master has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442045
--
Your team MAAS Committers is subscribed to branch maas:master.
--
jenkins: !test
--
https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/442046
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Approve
UNIT TESTS
-b remove-maasdb-dump lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 9ebe084a153bf1edcd497e759939ecf8893097b0
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442045
Your team MAAS Committers is subscribed to
jenkins: !test
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442045
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
UNIT TESTS
-b fix_vmfs_layout lp:~alexsander-souza/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2429/console
COMMIT: 5d215f859f4010310ad38f824bffef886df8c812
--
Alexsander de Souza has proposed merging ~alexsander-souza/maas:fix_vmfs_layout
into maas:master.
Commit message:
Update ESXi 7+ layout to new disk size
packer-maas template has been updated to use a 32GB image, and as consequence
the size of the partitions has grow. This patch reflects this
Review: Needs Fixing
UNIT TESTS
-b remove-maasdb-dump lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2428/console
COMMIT: 9ebe084a153bf1edcd497e759939ecf8893097b0
--
Review: Approve
+1
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442045
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Anton Troyanov has proposed merging ~troyanov/maas:remove-maasdb-dump into
maas:master.
Commit message:
chore: remove debug artefacts
Requested reviews:
MAAS Lander (maas-lander): unittests
MAAS Maintainers (maas-maintainers)
For more details, see:
Review: Approve
UNIT TESTS
-b go_network_discovery lp:~cgrabowski/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: d8911f319028252daf70ab6d999cbd57c4580ab4
--
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441702
Your team MAAS Committers is
Review: Needs Fixing
UNIT TESTS
-b go_network_discovery lp:~cgrabowski/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2426/console
COMMIT: 8fd3c2afb3fc210ac7235ccc8a9c218c55d2fa31
--
Diff comments:
> diff --git a/src/maasagent/cmd/netmon/main.go
> b/src/maasagent/cmd/netmon/main.go
> index e83655f..5acd102 100644
> --- a/src/maasagent/cmd/netmon/main.go
> +++ b/src/maasagent/cmd/netmon/main.go
> @@ -1,9 +1,80 @@
> package main
>
> +/*
> + Copyright 2023 Canonical
Review: Needs Fixing
UNIT TESTS
-b maasagent-cleanup lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2425/console
COMMIT: 8af3dcb3fa68b498a8cb6a3b969a5be647096938
--
Review: Needs Fixing
UNIT TESTS
-b strict-router-types lp:~petermakowski/maas-site-manager/+git/site-manager
into -b main lp:~maas-committers/maas-site-manager
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/528/console
COMMIT:
jenkins: !test
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442035
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Approve
UNIT TESTS
-b invalidate-queries-on-mutation
lp:~petermakowski/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: e139db3a087d62213e4b8329e5c6f05226611911
--
Diff comments:
> diff --git a/src/maasagent/cmd/netmon/main.go
> b/src/maasagent/cmd/netmon/main.go
> index e83655f..5acd102 100644
> --- a/src/maasagent/cmd/netmon/main.go
> +++ b/src/maasagent/cmd/netmon/main.go
> @@ -1,9 +1,80 @@
> package main
>
> +/*
> + Copyright 2023 Canonical
Review: Needs Fixing
UNIT TESTS
-b maasagent-cleanup lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2424/console
COMMIT: 8af3dcb3fa68b498a8cb6a3b969a5be647096938
--
Review: Approve
UNIT TESTS
-b invalidate-queries-on-mutation
lp:~petermakowski/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: 175c6a9c843bf5e7078d120267d35b739a93a061
--
Diff comments:
> diff --git a/Makefile b/Makefile
> index 53fc526..8215f4c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -189,8 +189,13 @@ lint-oapi: openapi.yaml
> .PHONY: lint-oapi
>
> # Go fmt
> +<<< Makefile
I didn't rebase onto latest master. Should be fixed now
> lint-go:
I prefer to have .gitignore files in different subdirectories, just not to have
everything in the root one. The patterns in the .gitignore files are matched
relative to the directory where the file resides.
But I am okay to drop it.
--
Diff comments:
> diff --git a/Makefile b/Makefile
> index 53fc526..8215f4c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -189,8 +189,13 @@ lint-oapi: openapi.yaml
> .PHONY: lint-oapi
>
> # Go fmt
> +<<< Makefile
seems like a merge conflict got committed?
> lint-go:
The proposal to merge
~petermakowski/maas-site-manager:invalidate-queries-on-mutation into
maas-site-manager:main has been updated.
Description changed to:
QA Steps
Go to /settings/tokens
Open developer tools in the network tab
Select a token and click Delete
Verify that a /tokens DELETE
Review: Approve
+1, although you have a conflict to fix
is the src/maasagent/.gitignore used at all or can it be dropped?
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442035
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list:
The proposal to merge
~petermakowski/maas-site-manager:invalidate-queries-on-mutation into
maas-site-manager:main has been updated.
Description changed to:
QA Steps
Go to /tokens
Open developer tools in the network tab
Select a token and click Delete
Verify that a DELETE request has been made
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:invalidate-queries-on-mutation into
maas-site-manager:main.
Commit message:
invalidate queries on mutation success
- fix displayed dates by using internal UTC formatting util functions
- update token post data to match
Review: Needs Fixing
UNIT TESTS
-b maasagent-cleanup lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2423/console
COMMIT: 28783553f9167b8588c0fb7ec4b6eef63dba00fc
--
The proposal to merge ~troyanov/maas:fix-2003940-3.3 into maas:3.3 has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442024
--
Your team MAAS Committers is subscribed to branch maas:3.3.
--
Mailing list:
Anton Troyanov has proposed merging ~troyanov/maas:maasagent-cleanup into
maas:master.
Commit message:
chore(ci): remove verbose print from golangci-lint
Requested reviews:
MAAS Maintainers (maas-maintainers)
For more details, see:
The proposal to merge ~troyanov/maas:fix-2003940-3.3 into maas:3.3 has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442024
--
Your team MAAS Committers is subscribed to branch maas:3.3.
--
Mailing list:
Review: Approve
UNIT TESTS
-b fix-2003940-3.3 lp:~troyanov/maas/+git/maas into -b 3.3
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 478dc737be6a05c10c31e55fff5370b82d93cb2e
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442024
Your team MAAS Committers is subscribed to branch
The proposal to merge ~ack/maas:1914762-install-ovs-testing into maas:master
has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442028
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Review: Approve
UNIT TESTS
-b 1914762-install-ovs-testing lp:~ack/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 6fe4e6248247607affe4039c0416f10c9be71338
--
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442028
Your team MAAS Committers is subscribed to
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 9 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 9 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 9 minutes
* Build Log:
Review: Approve
+1. Although considering your comments on Mattermost, I suspect this isn't
enough to get it working.
Let's get confirmation that it works before marking the bug as fixed.
--
https://code.launchpad.net/~ack/maas/+git/maas/+merge/442028
Your team MAAS Committers is subscribed to
Review: Approve
Self approving, since this backport is almost identical (but not a cherry-pick
tho)
https://git.launchpad.net/maas/commit/?id=3a3f3a99523aab3720697f9f0859def16b61
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442024
Your team MAAS Committers is subscribed to
Review: Approve
UNIT TESTS
-b fix-2003940 lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 97283388f46f3cefb9b517aac7c13ce1f787c7aa
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442021
Your team MAAS Committers is subscribed to branch
The proposal to merge ~troyanov/maas:fix-2003940 into maas:master has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442021
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list:
jenkins: !test
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442024
Your team MAAS Committers is subscribed to branch maas:3.3.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~sts-sponsors
Alberto Donato has proposed merging ~ack/maas:1914762-install-ovs-testing into
maas:master.
Commit message:
LP:1914762 install openvswitch package for network testing
Requested reviews:
MAAS Maintainers (maas-maintainers)
For more details, see:
Review: Needs Fixing
UNIT TESTS
-b fix-2003940-3.3 lp:~troyanov/maas/+git/maas into -b 3.3
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2418/console
COMMIT: 478dc737be6a05c10c31e55fff5370b82d93cb2e
--
The proposal to merge ~troyanov/maas:fix-2003940 into maas:master has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442021
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing
It can be reproduced only if machine has tags and if filtering is applied. If I
will remove filtering and tags -- then the test will work even without fix.
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442021
Your team MAAS Committers is subscribed to branch maas:master.
--
Review: Approve
+1
you can probably drop tags and the filtering in the list() call as they
shouldn't be needed
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442021
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list:
Review: Approve
UNIT TESTS
-b fix-2003940-3.3 lp:~troyanov/maas/+git/maas into -b 3.3
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: 68957d1035d803a2b9dbeb3f4000d4a5375f3469
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442024
Your team MAAS Committers is subscribed to branch
Anton Troyanov has proposed merging ~troyanov/maas:fix-2003940-3.3 into
maas:3.3.
Commit message:
fix(ws): incorrect storage amount
Combining multiple aggregations with annotate() will yield the wrong results
because joins are used instead of subqueries.
See related Django bug:
Review: Approve
UNIT TESTS
-b fix-2003940 lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: SUCCESS
COMMIT: d5d20f84973dfff5963d8a57dae36ef3c9b1423e
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442021
Your team MAAS Committers is subscribed to branch
Diff comments:
> diff --git a/src/maasagent/internal/netmon/service.go
> b/src/maasagent/internal/netmon/service.go
> index 14ebdc6..5ea5b00 100644
> --- a/src/maasagent/internal/netmon/service.go
> +++ b/src/maasagent/internal/netmon/service.go
> @@ -1,3 +1,243 @@
> package netmon
>
>
jenkins: !test
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442021
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
UNIT TESTS
-b dgx-platform-kernels-lookup lp:~igor-brovtsin/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2415/console
COMMIT: 8c501c747ab768a30746f07692db9d0ffd8b6fd1
--
Review: Needs Fixing
UNIT TESTS
-b fix-2003940 lp:~troyanov/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2414/console
COMMIT: 7ba51c382953effa7049c41e70f69bf8e9900aed
--
The proposal to merge ~troyanov/maas:fix-2003940 into maas:master has been
updated.
Commit message changed to:
fix(ws): incorrect storage amount
Combining multiple aggregations with annotate() will yield the wrong results
because joins are used instead of subqueries.
See related Django bug:
Anton Troyanov has proposed merging ~troyanov/maas:fix-2003940 into maas:master.
Commit message:
fix(ui): incorrect storage amount
Combining multiple aggregations with annotate() will yield the wrong results
because joins are used instead of subqueries.
See related Django bug:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 16 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 13 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
The proposal to merge ~petermakowski/maas-site-manager:pagination-e2e-test into
maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442000
--
Your team MAAS
Review: Needs Fixing
UNIT TESTS
-b dgx-platform-kernels-lookup lp:~igor-brovtsin/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2413/console
COMMIT: d4b70004475f7e01aa38e9e5e17744b45b0c8a92
--
Review: Needs Fixing
UNIT TESTS
-b dgx-platform-kernels-lookup lp:~igor-brovtsin/maas/+git/maas into -b master
lp:~maas-committers/maas
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/2412/console
COMMIT: fab36c4ac7d6bebc27d3b701fa85e084c1fe35ce
--
The proposal to merge ~bjornt/maas:current-script-set-foreign-key-constraints
into maas:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/441925
--
Your team MAAS Committers is subscribed to branch
The proposal to merge ~petermakowski/maas-site-manager:fix-iso-duration-value
into maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441958
--
Your team MAAS
The proposal to merge ~igor-brovtsin/maas:dgx-platform-kernels-lookup into
maas:master has been updated.
Description changed to:
This MP introduces multiple changes that allow better platform-optimised kernel
support. Namely, it changes the order of kernels returned by
`get_working_kernel`:
The proposal to merge
~petermakowski/maas-site-manager:non-unique-name-MAASENG-1578 into
maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442008
--
Your team MAAS
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 11 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
The proposal to merge ~petermakowski/maas-site-manager:fix-iso-duration-value
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441958
--
Your team MAAS
Review: Needs Fixing
UNIT TESTS
-b strict-router-types lp:~petermakowski/maas-site-manager/+git/site-manager
into -b main lp:~maas-committers/maas-site-manager
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/519/console
COMMIT:
The proposal to merge ~bjornt/maas:current-script-set-foreign-key-constraints
into maas:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/441925
--
Your team MAAS Committers is subscribed to branch
The proposal to merge ~petermakowski/maas-site-manager:pagination-e2e-test into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442000
--
Your team MAAS
The proposal to merge
~petermakowski/maas-site-manager:non-unique-name-MAASENG-1578 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442008
--
Your
Review: Needs Fixing
UNIT TESTS
-b strict-router-types lp:~petermakowski/maas-site-manager/+git/site-manager
into -b main lp:~maas-committers/maas-site-manager
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/518/console
COMMIT:
Review: Approve
UNIT TESTS
-b non-unique-name-MAASENG-1578
lp:~petermakowski/maas-site-manager/+git/site-manager into -b main
lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: 8e67c8b532fd3ddcc1d3f3623220f513d1ce7654
--
Review: Approve
QA and Code both looking good, nice one
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442008
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:non-unique-name-MAASENG-1578.
--
Mailing list:
Review: Approve
Nice one, LGTM
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442000
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:pagination-e2e-test.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:non-unique-name-MAASENG-1578 into
maas-site-manager:main.
Commit message:
add non-unique name warning MAASENG-1578
- remove default TooltipButton iconName
Requested reviews:
MAAS Lander (maas-lander): unittests
MAAS
The proposal to merge
~petermakowski/maas-site-manager:non-unique-name-MAASENG-1578 into
maas-site-manager:main has been updated.
Description changed to:
design spec: https://zpl.io/Z0vYxwq
QA Steps
go to /sites
hover over any displayed warning icons in the name column
verify that the correct
Review: Approve
UNIT TESTS
-b pagination-e2e-test lp:~petermakowski/maas-site-manager/+git/site-manager
into -b main lp:~maas-committers/maas-site-manager
STATUS: SUCCESS
COMMIT: cd6688d978aa71ce2b7251c47a00505e94bab0e6
--
The proposal to merge ~petermakowski/maas-site-manager:fix-iso-duration-value
into maas-site-manager:main has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441958
--
Your team MAAS
LANDING
-b fix-iso-duration-value lp:~petermakowski/maas-site-manager/+git/site-manager
into -b main lp:~maas-committers/maas-site-manager
STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/515/console
--
Review: Needs Fixing
UNIT TESTS
-b strict-router-types lp:~petermakowski/maas-site-manager/+git/site-manager
into -b main lp:~maas-committers/maas-site-manager
STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-site-manager-tester/514/console
COMMIT:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: arm64
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: s390x
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
* Snap Package: maas-master
* Archive: ~maas-committers/ubuntu/latest-deps
* Distroseries: None
* Architecture: ppc64el
* Pocket: UPDATES
* State: Failed to build
* Duration: 10 minutes
* Build Log:
The proposal to merge ~petermakowski/maas-site-manager:fix-iso-duration-value
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441958
--
Your team MAAS
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:pagination-e2e-test into
maas-site-manager:main.
Commit message:
fix pagination input index
- add e2e test for pagination
- add playwright yarn scripts
Requested reviews:
MAAS Committers (maas-committers)
For more
Diff comments:
> diff --git a/frontend/src/components/base/TablePagination/TablePagination.tsx
> b/frontend/src/components/base/TablePagination/TablePagination.tsx
> index c716638..070f187 100644
> --- a/frontend/src/components/base/TablePagination/TablePagination.tsx
> +++
Review: Approve
LGTM
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441958
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:fix-iso-duration-value.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
The proposal to merge ~petermakowski/maas-site-manager:add-a11y-tests into
maas-site-manager:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441890
--
Your team MAAS Committers is
The proposal to merge ~petermakowski/maas-site-manager:add-a11y-tests into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441890
--
Your team MAAS
1 - 100 of 111 matches
Mail list logo
